[INFO] updating cached repository mciantyre/ser2tcp
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mciantyre/ser2tcp
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mciantyre/ser2tcp" "work/ex/clippy-test-run/sources/stable/gh/mciantyre/ser2tcp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mciantyre/ser2tcp'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mciantyre/ser2tcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mciantyre/ser2tcp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mciantyre/ser2tcp'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e270ee663087bef483a9c455aef3b0827038271a
[INFO] sha for GitHub repo mciantyre/ser2tcp: e270ee663087bef483a9c455aef3b0827038271a
[INFO] validating manifest of mciantyre/ser2tcp on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mciantyre/ser2tcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mciantyre/ser2tcp
[INFO] finished frobbing mciantyre/ser2tcp
[INFO] frobbed toml for mciantyre/ser2tcp written to work/ex/clippy-test-run/sources/stable/gh/mciantyre/ser2tcp/Cargo.toml
[INFO] started frobbing mciantyre/ser2tcp
[INFO] finished frobbing mciantyre/ser2tcp
[INFO] frobbed toml for mciantyre/ser2tcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mciantyre/ser2tcp/Cargo.toml
[INFO] crate mciantyre/ser2tcp has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mciantyre/ser2tcp against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mciantyre/ser2tcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bf59d3078358126d77569b6e5bd10d140986a05ac8ba3ddef49cd6d599139711
[INFO] running `"docker" "start" "-a" "bf59d3078358126d77569b6e5bd10d140986a05ac8ba3ddef49cd6d599139711"`
[INFO] [stderr]    Compiling libudev-sys v0.1.4
[INFO] [stderr]     Checking nix v0.10.0
[INFO] [stderr]     Checking regex v1.0.0
[INFO] [stderr]     Checking libudev v0.2.0
[INFO] [stderr]     Checking env_logger v0.5.10
[INFO] [stderr]     Checking serialport v2.3.0
[INFO] [stderr]     Checking mio-serial v0.8.0
[INFO] [stderr]     Checking tokio-serial v0.8.0
[INFO] [stderr]     Checking ser2tcp v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:30:27
[INFO] [stderr]    |
[INFO] [stderr] 30 | const DEFAULT_BAUD: u32 = 115200;
[INFO] [stderr]    |                           ^^^^^^ help: consider: `115_200`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:30:27
[INFO] [stderr]    |
[INFO] [stderr] 30 | const DEFAULT_BAUD: u32 = 115200;
[INFO] [stderr]    |                           ^^^^^^ help: consider: `115_200`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead
[INFO] [stderr]    --> src/main.rs:182:28
[INFO] [stderr]     |
[INFO] [stderr] 182 |     let (_, reader) = port.framed(LinesCodec::new()).split();
[INFO] [stderr]     |                            ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead
[INFO] [stderr]    --> src/main.rs:182:28
[INFO] [stderr]     |
[INFO] [stderr] 182 |     let (_, reader) = port.framed(LinesCodec::new()).split();
[INFO] [stderr]     |                            ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |             .unwrap_or("UNKNOWN".to_owned());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "UNKNOWN".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/main.rs:192:24
[INFO] [stderr]     |
[INFO] [stderr] 192 |         for (_, tx) in &state.lock().unwrap().peers {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 192 |         for tx in state.lock().unwrap().peers.values() {
[INFO] [stderr]     |             ^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |             .unwrap_or("UNKNOWN".to_owned());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "UNKNOWN".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/main.rs:192:24
[INFO] [stderr]     |
[INFO] [stderr] 192 |         for (_, tx) in &state.lock().unwrap().peers {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 192 |         for tx in state.lock().unwrap().peers.values() {
[INFO] [stderr]     |             ^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.80s
[INFO] running `"docker" "inspect" "bf59d3078358126d77569b6e5bd10d140986a05ac8ba3ddef49cd6d599139711"`
[INFO] running `"docker" "rm" "-f" "bf59d3078358126d77569b6e5bd10d140986a05ac8ba3ddef49cd6d599139711"`
[INFO] [stdout] bf59d3078358126d77569b6e5bd10d140986a05ac8ba3ddef49cd6d599139711