[INFO] updating cached repository mcapell/worktrack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mcapell/worktrack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mcapell/worktrack" "work/ex/clippy-test-run/sources/stable/gh/mcapell/worktrack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcapell/worktrack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mcapell/worktrack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcapell/worktrack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcapell/worktrack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c8e187d27ef196ab3c2b3e174f3c487c91ca5d0a [INFO] sha for GitHub repo mcapell/worktrack: c8e187d27ef196ab3c2b3e174f3c487c91ca5d0a [INFO] validating manifest of mcapell/worktrack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcapell/worktrack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcapell/worktrack [INFO] finished frobbing mcapell/worktrack [INFO] frobbed toml for mcapell/worktrack written to work/ex/clippy-test-run/sources/stable/gh/mcapell/worktrack/Cargo.toml [INFO] started frobbing mcapell/worktrack [INFO] finished frobbing mcapell/worktrack [INFO] frobbed toml for mcapell/worktrack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcapell/worktrack/Cargo.toml [INFO] crate mcapell/worktrack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcapell/worktrack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mcapell/worktrack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d356332017cc09c5718951140e1800e187886ce072affb4903b460c64ee51e2e [INFO] running `"docker" "start" "-a" "d356332017cc09c5718951140e1800e187886ce072affb4903b460c64ee51e2e"` [INFO] [stderr] Checking worktrack v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | print_scrum_tasks(work.get(len - 1).unwrap(), &filters); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `work[len - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | print_scrum_tasks(work.get(len).unwrap(), &filters); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `work[len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:50 [INFO] [stderr] | [INFO] [stderr] 88 | fn print_scrum_tasks(workday: &WorkDay, filters: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 88 | fn print_scrum_tasks(workday: &WorkDay, filters: &[&str]) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: change `filters.clone()` to [INFO] [stderr] | [INFO] [stderr] 92 | for filter in filters.to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | let mut skip = if filters.len() > 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `filters.len() > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | let mut skip = if filters.len() > 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | print_scrum_tasks(work.get(len - 1).unwrap(), &filters); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `work[len - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | print_scrum_tasks(work.get(len).unwrap(), &filters); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `work[len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:50 [INFO] [stderr] | [INFO] [stderr] 88 | fn print_scrum_tasks(workday: &WorkDay, filters: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 88 | fn print_scrum_tasks(workday: &WorkDay, filters: &[&str]) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: change `filters.clone()` to [INFO] [stderr] | [INFO] [stderr] 92 | for filter in filters.to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | let mut skip = if filters.len() > 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `filters.len() > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:27 [INFO] [stderr] | [INFO] [stderr] 91 | let mut skip = if filters.len() > 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "d356332017cc09c5718951140e1800e187886ce072affb4903b460c64ee51e2e"` [INFO] running `"docker" "rm" "-f" "d356332017cc09c5718951140e1800e187886ce072affb4903b460c64ee51e2e"` [INFO] [stdout] d356332017cc09c5718951140e1800e187886ce072affb4903b460c64ee51e2e