[INFO] updating cached repository mbrubeck/robinson [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mbrubeck/robinson [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mbrubeck/robinson" "work/ex/clippy-test-run/sources/stable/gh/mbrubeck/robinson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mbrubeck/robinson'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mbrubeck/robinson" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbrubeck/robinson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbrubeck/robinson'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dfd5c3b3f88ebe10c5286414e87dea9bda60f611 [INFO] sha for GitHub repo mbrubeck/robinson: dfd5c3b3f88ebe10c5286414e87dea9bda60f611 [INFO] validating manifest of mbrubeck/robinson on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mbrubeck/robinson on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mbrubeck/robinson [INFO] finished frobbing mbrubeck/robinson [INFO] frobbed toml for mbrubeck/robinson written to work/ex/clippy-test-run/sources/stable/gh/mbrubeck/robinson/Cargo.toml [INFO] started frobbing mbrubeck/robinson [INFO] finished frobbing mbrubeck/robinson [INFO] frobbed toml for mbrubeck/robinson written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbrubeck/robinson/Cargo.toml [INFO] crate mbrubeck/robinson has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mbrubeck/robinson against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mbrubeck/robinson:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] deee444f5eb3a5b3549d25abc87de95515ce5daa20fae4e2b336da274dbec378 [INFO] running `"docker" "start" "-a" "deee444f5eb3a5b3549d25abc87de95515ce5daa20fae4e2b336da274dbec378"` [INFO] [stderr] Checking scopeguard v0.3.2 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking deflate v0.7.13 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking robinson v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/css.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | box_type: box_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `box_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/painting.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/painting.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pdf.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / write!(output, "{} {} {} sc {} {} {} {} re f\n", [INFO] [stderr] 33 | | // FIMXE: alpha transparency [INFO] [stderr] 34 | | color.r, color.g, color.b, [INFO] [stderr] 35 | | rect.x, rect.y, rect.width, rect.height) [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdf.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/css.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layout.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | box_type: box_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `box_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/painting.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/painting.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pdf.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / write!(output, "{} {} {} sc {} {} {} {} re f\n", [INFO] [stderr] 33 | | // FIMXE: alpha transparency [INFO] [stderr] 34 | | color.r, color.g, color.b, [INFO] [stderr] 35 | | rect.x, rect.y, rect.width, rect.height) [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pdf.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/layout.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | let mut width = style.value("width").unwrap_or(auto.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| auto.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/layout.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | d.content.height = d.content.height + child.dimensions.margin_box().height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d.content.height += child.dimensions.margin_box().height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/painting.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | get_color(layout_box, "background").map(|color| [INFO] [stderr] | _____^ [INFO] [stderr] | |_____| [INFO] [stderr] | || [INFO] [stderr] 43 | || list.push(DisplayCommand::SolidColor(color, layout_box.dimensions.border_box()))); [INFO] [stderr] | ||_________________________________________________________________________________________^- help: try this: `if let Some(color) = get_color(layout_box, "background") { list.push(DisplayCommand::SolidColor(color, layout_box.dimensions.border_box())) }` [INFO] [stderr] | |__________________________________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | matches.opt_str(flag).unwrap_or(default.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| default.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/layout.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | let mut width = style.value("width").unwrap_or(auto.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| auto.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/layout.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | d.content.height = d.content.height + child.dimensions.margin_box().height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d.content.height += child.dimensions.margin_box().height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/painting.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | get_color(layout_box, "background").map(|color| [INFO] [stderr] | _____^ [INFO] [stderr] | |_____| [INFO] [stderr] | || [INFO] [stderr] 43 | || list.push(DisplayCommand::SolidColor(color, layout_box.dimensions.border_box()))); [INFO] [stderr] | ||_________________________________________________________________________________________^- help: try this: `if let Some(color) = get_color(layout_box, "background") { list.push(DisplayCommand::SolidColor(color, layout_box.dimensions.border_box())) }` [INFO] [stderr] | |__________________________________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | matches.opt_str(flag).unwrap_or(default.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| default.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.07s [INFO] running `"docker" "inspect" "deee444f5eb3a5b3549d25abc87de95515ce5daa20fae4e2b336da274dbec378"` [INFO] running `"docker" "rm" "-f" "deee444f5eb3a5b3549d25abc87de95515ce5daa20fae4e2b336da274dbec378"` [INFO] [stdout] deee444f5eb3a5b3549d25abc87de95515ce5daa20fae4e2b336da274dbec378