[INFO] updating cached repository maxtnuk/dodge_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxtnuk/dodge_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxtnuk/dodge_rust" "work/ex/clippy-test-run/sources/stable/gh/maxtnuk/dodge_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxtnuk/dodge_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxtnuk/dodge_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxtnuk/dodge_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxtnuk/dodge_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6200e0b1ccd09e81f1cee7d9b304392fe9afaa0 [INFO] sha for GitHub repo maxtnuk/dodge_rust: e6200e0b1ccd09e81f1cee7d9b304392fe9afaa0 [INFO] validating manifest of maxtnuk/dodge_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxtnuk/dodge_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxtnuk/dodge_rust [INFO] finished frobbing maxtnuk/dodge_rust [INFO] frobbed toml for maxtnuk/dodge_rust written to work/ex/clippy-test-run/sources/stable/gh/maxtnuk/dodge_rust/Cargo.toml [INFO] started frobbing maxtnuk/dodge_rust [INFO] finished frobbing maxtnuk/dodge_rust [INFO] frobbed toml for maxtnuk/dodge_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxtnuk/dodge_rust/Cargo.toml [INFO] crate maxtnuk/dodge_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxtnuk/dodge_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxtnuk/dodge_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fdc5571af9173b7f466d3ad231835d52a3b47b7fcce9e194ab153200e833308 [INFO] running `"docker" "start" "-a" "6fdc5571af9173b7f466d3ad231835d52a3b47b7fcce9e194ab153200e833308"` [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking image v0.12.1 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-client v0.7.6 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking wayland-window v0.4.3 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking winit v0.5.8 [INFO] [stderr] Checking glutin v0.7.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking dodge_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | theta: theta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | self.current_speed = Speed::Go { scala: scala }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scala` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | theta: theta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | self.current_speed = Speed::Go { scala: scala }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scala` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:54 [INFO] [stderr] | [INFO] [stderr] 77 | let position_x = thread_rng().gen_range(0.0, r.width as f64 - self.size.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | let position_y = thread_rng().gen_range(0.0, r.height as f64 - self.size.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | Side::Right => (r.width as f64 - self.size.0, position_y), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | Side::Down => (position_x, r.height as f64 - self.size.1), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | Side::Center => (r.width as f64 / 2.0, r.height as f64 / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | Side::Center => (r.width as f64 / 2.0, r.height as f64 / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | fn is_wall(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | let available_x = self.background.0 as f64 - self.size.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:27 [INFO] [stderr] | [INFO] [stderr] 149 | let available_y = self.background.1 as f64 - self.size.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:155:27 [INFO] [stderr] | [INFO] [stderr] 155 | let available_x = self.background.0 as f64 - self.size.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | let available_y = self.background.1 as f64 - self.size.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:54 [INFO] [stderr] | [INFO] [stderr] 77 | let position_x = thread_rng().gen_range(0.0, r.width as f64 - self.size.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | let position_y = thread_rng().gen_range(0.0, r.height as f64 - self.size.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | Side::Right => (r.width as f64 - self.size.0, position_y), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | Side::Down => (position_x, r.height as f64 - self.size.1), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | Side::Center => (r.width as f64 / 2.0, r.height as f64 / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | Side::Center => (r.width as f64 / 2.0, r.height as f64 / 2.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | fn is_wall(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | let available_x = self.background.0 as f64 - self.size.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:27 [INFO] [stderr] | [INFO] [stderr] 149 | let available_y = self.background.1 as f64 - self.size.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:155:27 [INFO] [stderr] | [INFO] [stderr] 155 | let available_x = self.background.0 as f64 - self.size.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | let available_y = self.background.1 as f64 - self.size.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.background.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.10s [INFO] running `"docker" "inspect" "6fdc5571af9173b7f466d3ad231835d52a3b47b7fcce9e194ab153200e833308"` [INFO] running `"docker" "rm" "-f" "6fdc5571af9173b7f466d3ad231835d52a3b47b7fcce9e194ab153200e833308"` [INFO] [stdout] 6fdc5571af9173b7f466d3ad231835d52a3b47b7fcce9e194ab153200e833308