[INFO] updating cached repository maxjoehnk/pi-system-logger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxjoehnk/pi-system-logger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxjoehnk/pi-system-logger" "work/ex/clippy-test-run/sources/stable/gh/maxjoehnk/pi-system-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxjoehnk/pi-system-logger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxjoehnk/pi-system-logger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjoehnk/pi-system-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjoehnk/pi-system-logger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 94ca43bdba3ea46c2537c5938f06c28dc6df266e [INFO] sha for GitHub repo maxjoehnk/pi-system-logger: 94ca43bdba3ea46c2537c5938f06c28dc6df266e [INFO] validating manifest of maxjoehnk/pi-system-logger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxjoehnk/pi-system-logger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxjoehnk/pi-system-logger [INFO] finished frobbing maxjoehnk/pi-system-logger [INFO] frobbed toml for maxjoehnk/pi-system-logger written to work/ex/clippy-test-run/sources/stable/gh/maxjoehnk/pi-system-logger/Cargo.toml [INFO] started frobbing maxjoehnk/pi-system-logger [INFO] finished frobbing maxjoehnk/pi-system-logger [INFO] frobbed toml for maxjoehnk/pi-system-logger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjoehnk/pi-system-logger/Cargo.toml [INFO] crate maxjoehnk/pi-system-logger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxjoehnk/pi-system-logger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxjoehnk/pi-system-logger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32cf81ee93ad6fb35aafbf3a0a6196d1e35ea67aad6e1997dadc1d58320f219b [INFO] running `"docker" "start" "-a" "32cf81ee93ad6fb35aafbf3a0a6196d1e35ea67aad6e1997dadc1d58320f219b"` [INFO] [stderr] Checking strum v0.10.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Compiling strum_macros v0.10.0 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking influent v0.4.1 [INFO] [stderr] Checking pi-system-logging v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `err_msg` [INFO] [stderr] --> src/voltage.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use failure::{Error, err_msg}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `err_msg` [INFO] [stderr] --> src/voltage.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use failure::{Error, err_msg}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/clock_frequency.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | let caps = re.captures(&measure_clock_output).ok_or(err_msg("Invalid vcgencmd Output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Invalid vcgencmd Output"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/temperature.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | let caps = re.captures(&gpu_temp_output).ok_or(err_msg("Invalid vcgencmd Output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Invalid vcgencmd Output"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/voltage.rs:24:51 [INFO] [stderr] | [INFO] [stderr] 24 | let caps = re.captures(&measure_volts_output).ok_or(format_err!("Invalid vcgencmd Output: {}", measure_volts_output))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Invalid vcgencmd Output: {}", measure_volts_output))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/clock_frequency.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | let caps = re.captures(&measure_clock_output).ok_or(err_msg("Invalid vcgencmd Output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Invalid vcgencmd Output"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/temperature.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | let caps = re.captures(&gpu_temp_output).ok_or(err_msg("Invalid vcgencmd Output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Invalid vcgencmd Output"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/voltage.rs:24:51 [INFO] [stderr] | [INFO] [stderr] 24 | let caps = re.captures(&measure_volts_output).ok_or(format_err!("Invalid vcgencmd Output: {}", measure_volts_output))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Invalid vcgencmd Output: {}", measure_volts_output))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.33s [INFO] running `"docker" "inspect" "32cf81ee93ad6fb35aafbf3a0a6196d1e35ea67aad6e1997dadc1d58320f219b"` [INFO] running `"docker" "rm" "-f" "32cf81ee93ad6fb35aafbf3a0a6196d1e35ea67aad6e1997dadc1d58320f219b"` [INFO] [stdout] 32cf81ee93ad6fb35aafbf3a0a6196d1e35ea67aad6e1997dadc1d58320f219b