[INFO] updating cached repository maxjacobson/my-fancy-zsh-git-prompt
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/maxjacobson/my-fancy-zsh-git-prompt
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/my-fancy-zsh-git-prompt" "work/ex/clippy-test-run/sources/stable/gh/maxjacobson/my-fancy-zsh-git-prompt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxjacobson/my-fancy-zsh-git-prompt'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/my-fancy-zsh-git-prompt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/my-fancy-zsh-git-prompt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/my-fancy-zsh-git-prompt'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ee7e71830b3f00421b05e1b4384226dd56e46a1d
[INFO] sha for GitHub repo maxjacobson/my-fancy-zsh-git-prompt: ee7e71830b3f00421b05e1b4384226dd56e46a1d
[INFO] validating manifest of maxjacobson/my-fancy-zsh-git-prompt on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maxjacobson/my-fancy-zsh-git-prompt on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maxjacobson/my-fancy-zsh-git-prompt
[INFO] finished frobbing maxjacobson/my-fancy-zsh-git-prompt
[INFO] frobbed toml for maxjacobson/my-fancy-zsh-git-prompt written to work/ex/clippy-test-run/sources/stable/gh/maxjacobson/my-fancy-zsh-git-prompt/Cargo.toml
[INFO] started frobbing maxjacobson/my-fancy-zsh-git-prompt
[INFO] finished frobbing maxjacobson/my-fancy-zsh-git-prompt
[INFO] frobbed toml for maxjacobson/my-fancy-zsh-git-prompt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/my-fancy-zsh-git-prompt/Cargo.toml
[INFO] crate maxjacobson/my-fancy-zsh-git-prompt has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maxjacobson/my-fancy-zsh-git-prompt against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxjacobson/my-fancy-zsh-git-prompt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2819b197d8c3cca6b93d3cc063000230847d747e39ab53180a64b704fac23a0e
[INFO] running `"docker" "start" "-a" "2819b197d8c3cca6b93d3cc063000230847d747e39ab53180a64b704fac23a0e"`
[INFO] [stderr]     Checking my-fancy-zsh-git-prompt v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 | /         match self.color {
[INFO] [stderr] 37 | |             Some(ref c) => {
[INFO] [stderr] 38 | |                 result.push_str("%F{");
[INFO] [stderr] 39 | |                 result.push_str(&format!("{}", c));
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |             None => {}
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if let Some(ref c) = self.color {
[INFO] [stderr] 37 |     result.push_str("%F{");
[INFO] [stderr] 38 |     result.push_str(&format!("{}", c));
[INFO] [stderr] 39 |     result.push_str("%}");
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:39:34
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 result.push_str(&format!("{}", c));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         match self.color {
[INFO] [stderr] 48 | |             Some(ref _c) => result.push_str("%f"),
[INFO] [stderr] 49 | |             None => {}
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(ref _c) = self.color { result.push_str("%f") }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:97:25
[INFO] [stderr]     |
[INFO] [stderr] 97  | /                         match diff {
[INFO] [stderr] 98  | |                             Ok(diff_path) => match diff_path.to_str() {
[INFO] [stderr] 99  | |                                 Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 100 | |                                 None => {}
[INFO] [stderr] 101 | |                             },
[INFO] [stderr] 102 | |                             Err(_) => {}
[INFO] [stderr] 103 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 97  |                         if let Ok(diff_path) = diff { match diff_path.to_str() {
[INFO] [stderr] 98  |     Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 99  |     None => {}
[INFO] [stderr] 100 | } }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:98:46
[INFO] [stderr]     |
[INFO] [stderr] 98  |                               Ok(diff_path) => match diff_path.to_str() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 99  | |                                 Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 100 | |                                 None => {}
[INFO] [stderr] 101 | |                             },
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Some(diff_path_str) = diff_path.to_str() { result.push_str(diff_path_str) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 | /         match self.color {
[INFO] [stderr] 37 | |             Some(ref c) => {
[INFO] [stderr] 38 | |                 result.push_str("%F{");
[INFO] [stderr] 39 | |                 result.push_str(&format!("{}", c));
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |             None => {}
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if let Some(ref c) = self.color {
[INFO] [stderr] 37 |     result.push_str("%F{");
[INFO] [stderr] 38 |     result.push_str(&format!("{}", c));
[INFO] [stderr] 39 |     result.push_str("%}");
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:39:34
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 result.push_str(&format!("{}", c));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         match self.color {
[INFO] [stderr] 48 | |             Some(ref _c) => result.push_str("%f"),
[INFO] [stderr] 49 | |             None => {}
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(ref _c) = self.color { result.push_str("%f") }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:97:25
[INFO] [stderr]     |
[INFO] [stderr] 97  | /                         match diff {
[INFO] [stderr] 98  | |                             Ok(diff_path) => match diff_path.to_str() {
[INFO] [stderr] 99  | |                                 Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 100 | |                                 None => {}
[INFO] [stderr] 101 | |                             },
[INFO] [stderr] 102 | |                             Err(_) => {}
[INFO] [stderr] 103 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 97  |                         if let Ok(diff_path) = diff { match diff_path.to_str() {
[INFO] [stderr] 98  |     Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 99  |     None => {}
[INFO] [stderr] 100 | } }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:98:46
[INFO] [stderr]     |
[INFO] [stderr] 98  |                               Ok(diff_path) => match diff_path.to_str() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 99  | |                                 Some(diff_path_str) => result.push_str(diff_path_str),
[INFO] [stderr] 100 | |                                 None => {}
[INFO] [stderr] 101 | |                             },
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Some(diff_path_str) = diff_path.to_str() { result.push_str(diff_path_str) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.35s
[INFO] running `"docker" "inspect" "2819b197d8c3cca6b93d3cc063000230847d747e39ab53180a64b704fac23a0e"`
[INFO] running `"docker" "rm" "-f" "2819b197d8c3cca6b93d3cc063000230847d747e39ab53180a64b704fac23a0e"`
[INFO] [stdout] 2819b197d8c3cca6b93d3cc063000230847d747e39ab53180a64b704fac23a0e