[INFO] updating cached repository maxjacobson/fuzzy_file_helper
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/maxjacobson/fuzzy_file_helper
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/fuzzy_file_helper" "work/ex/clippy-test-run/sources/stable/gh/maxjacobson/fuzzy_file_helper"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxjacobson/fuzzy_file_helper'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/fuzzy_file_helper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/fuzzy_file_helper"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/fuzzy_file_helper'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0c8881b9c4f1002bba5fcbc9527ef13373d0e657
[INFO] sha for GitHub repo maxjacobson/fuzzy_file_helper: 0c8881b9c4f1002bba5fcbc9527ef13373d0e657
[INFO] validating manifest of maxjacobson/fuzzy_file_helper on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maxjacobson/fuzzy_file_helper on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maxjacobson/fuzzy_file_helper
[INFO] finished frobbing maxjacobson/fuzzy_file_helper
[INFO] frobbed toml for maxjacobson/fuzzy_file_helper written to work/ex/clippy-test-run/sources/stable/gh/maxjacobson/fuzzy_file_helper/Cargo.toml
[INFO] started frobbing maxjacobson/fuzzy_file_helper
[INFO] finished frobbing maxjacobson/fuzzy_file_helper
[INFO] frobbed toml for maxjacobson/fuzzy_file_helper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/fuzzy_file_helper/Cargo.toml
[INFO] crate maxjacobson/fuzzy_file_helper has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maxjacobson/fuzzy_file_helper against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxjacobson/fuzzy_file_helper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ee4a4be240855ea41ea49800e2b3f3367df41aa239dcd9befa2e3b587366b3e5
[INFO] running `"docker" "start" "-a" "ee4a4be240855ea41ea49800e2b3f3367df41aa239dcd9befa2e3b587366b3e5"`
[INFO] [stderr]     Checking regex-syntax v0.3.4
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking thread_local v0.2.6
[INFO] [stderr]     Checking aho-corasick v0.5.2
[INFO] [stderr]     Checking regex v0.1.73
[INFO] [stderr]     Checking fuzzy_file_helper v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:11:30
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let files = buffer.split("\n").filter(|file| file.to_string() != "");
[INFO] [stderr]    |                              ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:11:50
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let files = buffer.split("\n").filter(|file| file.to_string() != "");
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `file`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:18:54
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != "");
[INFO] [stderr]    |                                                      ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:18:73
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != "");
[INFO] [stderr]    |                                                                         ^^^^^^^^^^^^^^^ help: try: `pat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/main.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |               if !ignore_patterns.any(|pat| {
[INFO] [stderr]    |  ___________________________________________^
[INFO] [stderr] 20 | |                 Regex::new(pat).unwrap().is_match(file)
[INFO] [stderr] 21 | |             }) {
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:11:30
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let files = buffer.split("\n").filter(|file| file.to_string() != "");
[INFO] [stderr]    |                              ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:11:50
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let files = buffer.split("\n").filter(|file| file.to_string() != "");
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `file`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:18:54
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != "");
[INFO] [stderr]    |                                                      ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:18:73
[INFO] [stderr]    |
[INFO] [stderr] 18 |             let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != "");
[INFO] [stderr]    |                                                                         ^^^^^^^^^^^^^^^ help: try: `pat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/main.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |               if !ignore_patterns.any(|pat| {
[INFO] [stderr]    |  ___________________________________________^
[INFO] [stderr] 20 | |                 Regex::new(pat).unwrap().is_match(file)
[INFO] [stderr] 21 | |             }) {
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.48s
[INFO] running `"docker" "inspect" "ee4a4be240855ea41ea49800e2b3f3367df41aa239dcd9befa2e3b587366b3e5"`
[INFO] running `"docker" "rm" "-f" "ee4a4be240855ea41ea49800e2b3f3367df41aa239dcd9befa2e3b587366b3e5"`
[INFO] [stdout] ee4a4be240855ea41ea49800e2b3f3367df41aa239dcd9befa2e3b587366b3e5