[INFO] updating cached repository maxjacobson/cheapskate-ci [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxjacobson/cheapskate-ci [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/cheapskate-ci" "work/ex/clippy-test-run/sources/stable/gh/maxjacobson/cheapskate-ci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxjacobson/cheapskate-ci'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxjacobson/cheapskate-ci" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/cheapskate-ci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/cheapskate-ci'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 769bc66d50d13c01f977dce11c27c6c46817c4ec [INFO] sha for GitHub repo maxjacobson/cheapskate-ci: 769bc66d50d13c01f977dce11c27c6c46817c4ec [INFO] validating manifest of maxjacobson/cheapskate-ci on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxjacobson/cheapskate-ci on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxjacobson/cheapskate-ci [INFO] finished frobbing maxjacobson/cheapskate-ci [INFO] frobbed toml for maxjacobson/cheapskate-ci written to work/ex/clippy-test-run/sources/stable/gh/maxjacobson/cheapskate-ci/Cargo.toml [INFO] started frobbing maxjacobson/cheapskate-ci [INFO] finished frobbing maxjacobson/cheapskate-ci [INFO] frobbed toml for maxjacobson/cheapskate-ci written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxjacobson/cheapskate-ci/Cargo.toml [INFO] crate maxjacobson/cheapskate-ci has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxjacobson/cheapskate-ci against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxjacobson/cheapskate-ci:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e3410ee6eca341baa76834776d010d8ae19044bf991e4da6002e099ee5fa071 [INFO] running `"docker" "start" "-a" "4e3410ee6eca341baa76834776d010d8ae19044bf991e4da6002e099ee5fa071"` [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking psst v0.1.0 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.17 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking cheapskate-ci v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .expect(&format!("Could not convert `{}` to string", command)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not convert `{}` to string", command))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | .expect(&format!("Could not run {}", command)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not run {}", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .expect(&format!("Invalid command: {}", self.command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid command: {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("Failed to run {}", self.command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:37:57 [INFO] [stderr] | [INFO] [stderr] 37 | let stderr = str::from_utf8(&output.stderr).expect(&format!( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 38 | | "Failed to parse stderr of command: {}", [INFO] [stderr] 39 | | self.command [INFO] [stderr] 40 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse stderr of command: {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .expect(&format!("Could not convert `{}` to string", command)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not convert `{}` to string", command))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | .expect(&format!("Could not run {}", command)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not run {}", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .expect(&format!("Invalid command: {}", self.command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid command: {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("Failed to run {}", self.command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/step.rs:37:57 [INFO] [stderr] | [INFO] [stderr] 37 | let stderr = str::from_utf8(&output.stderr).expect(&format!( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 38 | | "Failed to parse stderr of command: {}", [INFO] [stderr] 39 | | self.command [INFO] [stderr] 40 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse stderr of command: {}", self.command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.93s [INFO] running `"docker" "inspect" "4e3410ee6eca341baa76834776d010d8ae19044bf991e4da6002e099ee5fa071"` [INFO] running `"docker" "rm" "-f" "4e3410ee6eca341baa76834776d010d8ae19044bf991e4da6002e099ee5fa071"` [INFO] [stdout] 4e3410ee6eca341baa76834776d010d8ae19044bf991e4da6002e099ee5fa071