[INFO] updating cached repository maxbeutel/rust-ascii-art [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxbeutel/rust-ascii-art [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxbeutel/rust-ascii-art" "work/ex/clippy-test-run/sources/stable/gh/maxbeutel/rust-ascii-art"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxbeutel/rust-ascii-art'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxbeutel/rust-ascii-art" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/rust-ascii-art"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/rust-ascii-art'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2021f741c9dea91ad36ccad393acb602c4a20efe [INFO] sha for GitHub repo maxbeutel/rust-ascii-art: 2021f741c9dea91ad36ccad393acb602c4a20efe [INFO] validating manifest of maxbeutel/rust-ascii-art on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxbeutel/rust-ascii-art on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxbeutel/rust-ascii-art [INFO] finished frobbing maxbeutel/rust-ascii-art [INFO] frobbed toml for maxbeutel/rust-ascii-art written to work/ex/clippy-test-run/sources/stable/gh/maxbeutel/rust-ascii-art/Cargo.toml [INFO] started frobbing maxbeutel/rust-ascii-art [INFO] finished frobbing maxbeutel/rust-ascii-art [INFO] frobbed toml for maxbeutel/rust-ascii-art written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/rust-ascii-art/Cargo.toml [INFO] crate maxbeutel/rust-ascii-art has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxbeutel/rust-ascii-art against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxbeutel/rust-ascii-art:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 023f595b65c589fb903409fd0fdb7fc64d560d13f38e01cddc9af15df979fe3b [INFO] running `"docker" "start" "-a" "023f595b65c589fb903409fd0fdb7fc64d560d13f38e01cddc9af15df979fe3b"` [INFO] [stderr] Checking ascii-art v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | let dx = ((x1 - x0)).abs(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:185:18 [INFO] [stderr] | [INFO] [stderr] 185 | let dy = ((y1 - y0)).abs(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | let dx = ((x1 - x0)).abs(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:185:18 [INFO] [stderr] | [INFO] [stderr] 185 | let dy = ((y1 - y0)).abs(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Canvas` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Canvas, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_dimensions` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn from_dimensions(dimensions: Dimensions) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `coords_from_index` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | fn coords_from_index(i: u32, dimensions: Dimensions) -> Coords { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_coords` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | fn from_coords(coords: &Vec) -> Dimensions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_max_coord_from_coords` [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_max_coord_from_coords<'a, I: Iterator>(coords: I, pluck_fn: &Fn(&Coords) -> u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CombinedObject` [INFO] [stderr] --> src/main.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | struct CombinedObject(Dimensions, Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate` [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | fn rotate(line: Line, rotation_center: Coords) -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | fn new(start: Coords, end: Coords) -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Circle` [INFO] [stderr] --> src/main.rs:244:1 [INFO] [stderr] | [INFO] [stderr] 244 | struct Circle(Dimensions, Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | fn new(point: Coords, radius: u32) -> Circle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Canvas` [INFO] [stderr] --> src/main.rs:296:1 [INFO] [stderr] | [INFO] [stderr] 296 | struct Canvas(Dimensions, Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `combine` [INFO] [stderr] --> src/main.rs:299:1 [INFO] [stderr] | [INFO] [stderr] 299 | fn combine(a: Box, b: Box) -> CombinedObject { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `plot` [INFO] [stderr] --> src/main.rs:312:1 [INFO] [stderr] | [INFO] [stderr] 312 | fn plot(a: Box) -> Canvas { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw` [INFO] [stderr] --> src/main.rs:327:1 [INFO] [stderr] | [INFO] [stderr] 327 | fn draw(canvas: Canvas) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixtures_diagonal_line_ltr` [INFO] [stderr] --> src/main.rs:345:1 [INFO] [stderr] | [INFO] [stderr] 345 | fn fixtures_diagonal_line_ltr() -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixtures_horizontal_line` [INFO] [stderr] --> src/main.rs:349:1 [INFO] [stderr] | [INFO] [stderr] 349 | fn fixtures_horizontal_line() -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixtures_vertical_line` [INFO] [stderr] --> src/main.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | fn fixtures_vertical_line() -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixtures_circle` [INFO] [stderr] --> src/main.rs:357:1 [INFO] [stderr] | [INFO] [stderr] 357 | fn fixtures_circle() -> Circle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | fn from_coords(coords: &Vec) -> Dimensions { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Coords]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / match result { [INFO] [stderr] 90 | | Some(matched_contained_coords) => { return contained_plottable.get_representation_at(*matched_contained_coords) }, [INFO] [stderr] 91 | | None => {}, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(matched_contained_coords) = result { return contained_plottable.get_representation_at(*matched_contained_coords) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw` [INFO] [stderr] --> src/main.rs:327:1 [INFO] [stderr] | [INFO] [stderr] 327 | fn draw(canvas: Canvas) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | fn from_coords(coords: &Vec) -> Dimensions { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Coords]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / match result { [INFO] [stderr] 90 | | Some(matched_contained_coords) => { return contained_plottable.get_representation_at(*matched_contained_coords) }, [INFO] [stderr] 91 | | None => {}, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Some(matched_contained_coords) = result { return contained_plottable.get_representation_at(*matched_contained_coords) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `"docker" "inspect" "023f595b65c589fb903409fd0fdb7fc64d560d13f38e01cddc9af15df979fe3b"` [INFO] running `"docker" "rm" "-f" "023f595b65c589fb903409fd0fdb7fc64d560d13f38e01cddc9af15df979fe3b"` [INFO] [stdout] 023f595b65c589fb903409fd0fdb7fc64d560d13f38e01cddc9af15df979fe3b