[INFO] updating cached repository maxbeutel/hough-transform-explained [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxbeutel/hough-transform-explained [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxbeutel/hough-transform-explained" "work/ex/clippy-test-run/sources/stable/gh/maxbeutel/hough-transform-explained"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxbeutel/hough-transform-explained'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxbeutel/hough-transform-explained" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/hough-transform-explained"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/hough-transform-explained'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f487faa92ef33f08c7531fe6a8cd0af9032ea227 [INFO] sha for GitHub repo maxbeutel/hough-transform-explained: f487faa92ef33f08c7531fe6a8cd0af9032ea227 [INFO] validating manifest of maxbeutel/hough-transform-explained on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxbeutel/hough-transform-explained on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxbeutel/hough-transform-explained [INFO] finished frobbing maxbeutel/hough-transform-explained [INFO] frobbed toml for maxbeutel/hough-transform-explained written to work/ex/clippy-test-run/sources/stable/gh/maxbeutel/hough-transform-explained/Cargo.toml [INFO] started frobbing maxbeutel/hough-transform-explained [INFO] finished frobbing maxbeutel/hough-transform-explained [INFO] frobbed toml for maxbeutel/hough-transform-explained written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxbeutel/hough-transform-explained/Cargo.toml [INFO] crate maxbeutel/hough-transform-explained has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxbeutel/hough-transform-explained against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxbeutel/hough-transform-explained:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 110a30c94daca7e47f47ce1a68ae77e7b6c2f2facae688805a45f900c5b63a03 [INFO] running `"docker" "start" "-a" "110a30c94daca7e47f47ce1a68ae77e7b6c2f2facae688805a45f900c5b63a03"` [INFO] [stderr] Compiling gcc v0.3.38 [INFO] [stderr] Checking num_cpus v1.1.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking nalgebra v0.10.1 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Checking hough-transform-explained v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if theta == 60.0 { println!("(rho) {} - round {}", rho, rho_rounded); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(theta - 60.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if theta == 60.0 { println!("(rho) {} - round {}", rho, rho_rounded); } [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let ref mut angle_visualization_fout = File::create(&Path::new("angle-visualization.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------- help: try: `let angle_visualization_fout = &mut File::create(&Path::new("angle-visualization.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let ref mut houghspace_fout = File::create(&Path::new("houghspace.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^------------------------------------------------------- help: try: `let houghspace_fout = &mut File::create(&Path::new("houghspace.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let ref mut detected_lines_fout = File::create(&Path::new("detected_lines.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let detected_lines_fout = &mut File::create(&Path::new("detected_lines.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | / fn liang_barsky ( [INFO] [stderr] 242 | | edge_left: f32, edge_right: f32, edge_bottom: f32, edge_top: f32, // Define the x/y clipping values for the border. [INFO] [stderr] 243 | | x0src: f32, y0src: f32, x1src: f32, y1src: f32, // Define the start and end points of the line. [INFO] [stderr] 244 | | x0clip: &mut f32, y0clip: &mut f32, x1clip: &mut f32, y1clip: &mut f32 // The output values, so declare these outside. [INFO] [stderr] ... | [INFO] [stderr] 291 | | return true; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hough-transform-explained`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if theta == 60.0 { println!("(rho) {} - round {}", rho, rho_rounded); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(theta - 60.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if theta == 60.0 { println!("(rho) {} - round {}", rho, rho_rounded); } [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let ref mut angle_visualization_fout = File::create(&Path::new("angle-visualization.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------- help: try: `let angle_visualization_fout = &mut File::create(&Path::new("angle-visualization.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let ref mut houghspace_fout = File::create(&Path::new("houghspace.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^------------------------------------------------------- help: try: `let houghspace_fout = &mut File::create(&Path::new("houghspace.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let ref mut detected_lines_fout = File::create(&Path::new("detected_lines.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let detected_lines_fout = &mut File::create(&Path::new("detected_lines.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | / fn liang_barsky ( [INFO] [stderr] 242 | | edge_left: f32, edge_right: f32, edge_bottom: f32, edge_top: f32, // Define the x/y clipping values for the border. [INFO] [stderr] 243 | | x0src: f32, y0src: f32, x1src: f32, y1src: f32, // Define the start and end points of the line. [INFO] [stderr] 244 | | x0clip: &mut f32, y0clip: &mut f32, x1clip: &mut f32, y1clip: &mut f32 // The output values, so declare these outside. [INFO] [stderr] ... | [INFO] [stderr] 291 | | return true; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hough-transform-explained`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "110a30c94daca7e47f47ce1a68ae77e7b6c2f2facae688805a45f900c5b63a03"` [INFO] running `"docker" "rm" "-f" "110a30c94daca7e47f47ce1a68ae77e7b6c2f2facae688805a45f900c5b63a03"` [INFO] [stdout] 110a30c94daca7e47f47ce1a68ae77e7b6c2f2facae688805a45f900c5b63a03