[INFO] updating cached repository maxastyler/Spirograph [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maxastyler/Spirograph [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maxastyler/Spirograph" "work/ex/clippy-test-run/sources/stable/gh/maxastyler/Spirograph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maxastyler/Spirograph'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maxastyler/Spirograph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxastyler/Spirograph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxastyler/Spirograph'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d639d179214179e4843bca5cbd646dc9a1959e5d [INFO] sha for GitHub repo maxastyler/Spirograph: d639d179214179e4843bca5cbd646dc9a1959e5d [INFO] validating manifest of maxastyler/Spirograph on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxastyler/Spirograph on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxastyler/Spirograph [INFO] finished frobbing maxastyler/Spirograph [INFO] frobbed toml for maxastyler/Spirograph written to work/ex/clippy-test-run/sources/stable/gh/maxastyler/Spirograph/Cargo.toml [INFO] started frobbing maxastyler/Spirograph [INFO] finished frobbing maxastyler/Spirograph [INFO] frobbed toml for maxastyler/Spirograph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maxastyler/Spirograph/Cargo.toml [INFO] crate maxastyler/Spirograph has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxastyler/Spirograph against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maxastyler/Spirograph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6353575ee3ea032261f632e017d7b712c73b657482be1c3e78f199743665033b [INFO] running `"docker" "start" "-a" "6353575ee3ea032261f632e017d7b712c73b657482be1c3e78f199743665033b"` [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking spirograph v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:88:76 [INFO] [stderr] | [INFO] [stderr] 88 | let img = spiro_image((2000, 2000), linspace(-1., 1., 20), path_points(100000), &spiral_path, &gen_envelope); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `path` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn path(t: f64) -> (f64, f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `envelope` [INFO] [stderr] --> src/main.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | fn envelope(t: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `double_envelope` [INFO] [stderr] --> src/main.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn double_envelope(h: f64) -> Box f64> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let xf = (x as f64)/(n as f64 -1.) ; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let xf = (x as f64)/(n as f64 -1.) ; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | xf+=img_res.0 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_res.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | yf+=img_res.1 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_res.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | (0..r).map(|i| (i as f64) / (r as f64 - 1.0)).collect() [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | (0..r).map(|i| (i as f64) / (r as f64 - 1.0)).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:88:76 [INFO] [stderr] | [INFO] [stderr] 88 | let img = spiro_image((2000, 2000), linspace(-1., 1., 20), path_points(100000), &spiral_path, &gen_envelope); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `path` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn path(t: f64) -> (f64, f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `envelope` [INFO] [stderr] --> src/main.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | fn envelope(t: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `double_envelope` [INFO] [stderr] --> src/main.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn double_envelope(h: f64) -> Box f64> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let xf = (x as f64)/(n as f64 -1.) ; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let xf = (x as f64)/(n as f64 -1.) ; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | xf+=img_res.0 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_res.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | yf+=img_res.1 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_res.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | (0..r).map(|i| (i as f64) / (r as f64 - 1.0)).collect() [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | (0..r).map(|i| (i as f64) / (r as f64 - 1.0)).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.07s [INFO] running `"docker" "inspect" "6353575ee3ea032261f632e017d7b712c73b657482be1c3e78f199743665033b"` [INFO] running `"docker" "rm" "-f" "6353575ee3ea032261f632e017d7b712c73b657482be1c3e78f199743665033b"` [INFO] [stdout] 6353575ee3ea032261f632e017d7b712c73b657482be1c3e78f199743665033b