[INFO] updating cached repository max-sixty/expect-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/max-sixty/expect-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/max-sixty/expect-test" "work/ex/clippy-test-run/sources/stable/gh/max-sixty/expect-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/max-sixty/expect-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/max-sixty/expect-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/max-sixty/expect-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/max-sixty/expect-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 859fa777d94c1cdceb8802f9a67960713633838e [INFO] sha for GitHub repo max-sixty/expect-test: 859fa777d94c1cdceb8802f9a67960713633838e [INFO] validating manifest of max-sixty/expect-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of max-sixty/expect-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing max-sixty/expect-test [INFO] finished frobbing max-sixty/expect-test [INFO] frobbed toml for max-sixty/expect-test written to work/ex/clippy-test-run/sources/stable/gh/max-sixty/expect-test/Cargo.toml [INFO] started frobbing max-sixty/expect-test [INFO] finished frobbing max-sixty/expect-test [INFO] frobbed toml for max-sixty/expect-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/max-sixty/expect-test/Cargo.toml [INFO] crate max-sixty/expect-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting max-sixty/expect-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/max-sixty/expect-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94f65ff31ff426a0035aa91bf9cb0204e47ef26474797f602567e74a95b3c153 [INFO] running `"docker" "start" "-a" "94f65ff31ff426a0035aa91bf9cb0204e47ef26474797f602567e74a95b3c153"` [INFO] [stderr] Checking difference v1.0.0 [INFO] [stderr] Checking pretty_assertions v0.2.1 [INFO] [stderr] Checking expect-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | fs::read_to_string(self.file_path()).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | fs::read_to_string(self.file_path()).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.75s [INFO] running `"docker" "inspect" "94f65ff31ff426a0035aa91bf9cb0204e47ef26474797f602567e74a95b3c153"` [INFO] running `"docker" "rm" "-f" "94f65ff31ff426a0035aa91bf9cb0204e47ef26474797f602567e74a95b3c153"` [INFO] [stdout] 94f65ff31ff426a0035aa91bf9cb0204e47ef26474797f602567e74a95b3c153