[INFO] updating cached repository maurizi/retag.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maurizi/retag.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maurizi/retag.rs" "work/ex/clippy-test-run/sources/stable/gh/maurizi/retag.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maurizi/retag.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maurizi/retag.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maurizi/retag.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maurizi/retag.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f64683f57f3b2cd131a6a732c195103d76f06836 [INFO] sha for GitHub repo maurizi/retag.rs: f64683f57f3b2cd131a6a732c195103d76f06836 [INFO] validating manifest of maurizi/retag.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maurizi/retag.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maurizi/retag.rs [INFO] finished frobbing maurizi/retag.rs [INFO] frobbed toml for maurizi/retag.rs written to work/ex/clippy-test-run/sources/stable/gh/maurizi/retag.rs/Cargo.toml [INFO] started frobbing maurizi/retag.rs [INFO] finished frobbing maurizi/retag.rs [INFO] frobbed toml for maurizi/retag.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maurizi/retag.rs/Cargo.toml [INFO] crate maurizi/retag.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maurizi/retag.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maurizi/retag.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f71f7620eb10232ace00227e3fa3106163b4a3f57715cae2c3c104c1e64b34a [INFO] running `"docker" "start" "-a" "8f71f7620eb10232ace00227e3fa3106163b4a3f57715cae2c3c104c1e64b34a"` [INFO] [stderr] Checking strsim v0.5.2 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking filetime v0.1.14 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking toml v0.1.30 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking retag v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | project_dir: project_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_dir` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | project_dir: project_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | tag_path: tag_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | tag_cmd: tag_cmd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tag_cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tmp_dir: tmp_dir [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tmp_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | tag_path: tag_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | tag_cmd: tag_cmd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tag_cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/watcher.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tmp_dir: tmp_dir [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tmp_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(home) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/watcher.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(home) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/watcher.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let tmp_dir = TempDir::new("retag").ok().expect("Could not create temp directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/watcher.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | Err(_) => panic!("Could not start file watcher") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | watcher.watch(&self.project_dir).ok().expect("Could not start file watcher"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | self.create_tagfile().ok().expect("Could not build tag file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let tmp_dir = TempDir::new("retag").ok().expect("Could not create temp directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/watcher.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | Err(_) => panic!("Could not start file watcher") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | watcher.watch(&self.project_dir).ok().expect("Could not start file watcher"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/watcher.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | self.create_tagfile().ok().expect("Could not build tag file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.32s [INFO] running `"docker" "inspect" "8f71f7620eb10232ace00227e3fa3106163b4a3f57715cae2c3c104c1e64b34a"` [INFO] running `"docker" "rm" "-f" "8f71f7620eb10232ace00227e3fa3106163b4a3f57715cae2c3c104c1e64b34a"` [INFO] [stdout] 8f71f7620eb10232ace00227e3fa3106163b4a3f57715cae2c3c104c1e64b34a