[INFO] updating cached repository mattrudder/pathtracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mattrudder/pathtracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mattrudder/pathtracer" "work/ex/clippy-test-run/sources/stable/gh/mattrudder/pathtracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattrudder/pathtracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mattrudder/pathtracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrudder/pathtracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrudder/pathtracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ca72bd755b0ed65691ecd92e58d725f124220915
[INFO] sha for GitHub repo mattrudder/pathtracer: ca72bd755b0ed65691ecd92e58d725f124220915
[INFO] validating manifest of mattrudder/pathtracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mattrudder/pathtracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mattrudder/pathtracer
[INFO] finished frobbing mattrudder/pathtracer
[INFO] frobbed toml for mattrudder/pathtracer written to work/ex/clippy-test-run/sources/stable/gh/mattrudder/pathtracer/Cargo.toml
[INFO] started frobbing mattrudder/pathtracer
[INFO] finished frobbing mattrudder/pathtracer
[INFO] frobbed toml for mattrudder/pathtracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrudder/pathtracer/Cargo.toml
[INFO] crate mattrudder/pathtracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mattrudder/pathtracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mattrudder/pathtracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ee13711e445de650124f1edee8b84b1fad04a76f0d4394ea5cc67aa5f545055f
[INFO] running `"docker" "start" "-a" "ee13711e445de650124f1edee8b84b1fad04a76f0d4394ea5cc67aa5f545055f"`
[INFO] [stderr]    Compiling x11-dl v2.14.0
[INFO] [stderr]    Compiling minifb v0.10.7
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]    Compiling structopt-derive v0.2.10
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking structopt v0.2.10
[INFO] [stderr]     Checking pathtracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/math/sphere.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let d = (b * b - (a * c)).sqrt();
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/math/sphere.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let t = (-b - d) / a;
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/math/sphere.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let d = (b * b - (a * c)).sqrt();
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/math/sphere.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let t = (-b - d) / a;
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 | /   return Some(Bounce {
[INFO] [stderr] 31 | |     attenuation,
[INFO] [stderr] 32 | |     bounced,
[INFO] [stderr] 33 | |   });
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 30 |   Some(Bounce {
[INFO] [stderr] 31 |     attenuation,
[INFO] [stderr] 32 |     bounced,
[INFO] [stderr] 33 |   })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return self.e[0];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return self.e[1];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return self.e[2];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return self.e[0];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return self.e[1];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/math/vector3.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return self.e[2];
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scene.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 |     return buffer;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 | /   return Some(Bounce {
[INFO] [stderr] 31 | |     attenuation,
[INFO] [stderr] 32 | |     bounced,
[INFO] [stderr] 33 | |   });
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 30 |   Some(Bounce {
[INFO] [stderr] 31 |     attenuation,
[INFO] [stderr] 32 |     bounced,
[INFO] [stderr] 33 |   })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return self.e[0];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return self.e[1];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return self.e[2];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return self.e[0];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/vector3.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return self.e[1];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/math/vector3.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return self.e[2];
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scene.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 |     return buffer;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `col` is used to index `line`
[INFO] [stderr]    --> src/scene.rs:121:20
[INFO] [stderr]     |
[INFO] [stderr] 121 |         for col in 0..width {
[INFO] [stderr]     |                    ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 121 |         for (col, <item>) in line.iter_mut().enumerate().take(width) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 | /     window.is_menu_pressed().map(|menu_id| {
[INFO] [stderr] 130 | |       match menu_id {
[INFO] [stderr] 131 | |         FILE_SAVE => {
[INFO] [stderr] 132 | |           if let Some(img) = buffer.take() {
[INFO] [stderr] ...   |
[INFO] [stderr] 148 | |       };
[INFO] [stderr] 149 | |     });
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 129 |     if let Some(menu_id) = window.is_menu_pressed() { match menu_id {
[INFO] [stderr] 130 |         FILE_SAVE => {
[INFO] [stderr] 131 |           if let Some(img) = buffer.take() {
[INFO] [stderr] 132 |             let result = nfd::open_save_dialog(Some("png"), None).unwrap_or_else(|e| {
[INFO] [stderr] 133 |               panic!(e);
[INFO] [stderr] 134 |             });
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:184:47
[INFO] [stderr]     |
[INFO] [stderr] 184 |       let seconds = delta.as_secs() as f64 + (delta.subsec_millis() as f64 / 1000.0);
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(delta.subsec_millis())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `col` is used to index `line`
[INFO] [stderr]    --> src/scene.rs:121:20
[INFO] [stderr]     |
[INFO] [stderr] 121 |         for col in 0..width {
[INFO] [stderr]     |                    ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 121 |         for (col, <item>) in line.iter_mut().enumerate().take(width) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 | /     window.is_menu_pressed().map(|menu_id| {
[INFO] [stderr] 130 | |       match menu_id {
[INFO] [stderr] 131 | |         FILE_SAVE => {
[INFO] [stderr] 132 | |           if let Some(img) = buffer.take() {
[INFO] [stderr] ...   |
[INFO] [stderr] 148 | |       };
[INFO] [stderr] 149 | |     });
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 129 |     if let Some(menu_id) = window.is_menu_pressed() { match menu_id {
[INFO] [stderr] 130 |         FILE_SAVE => {
[INFO] [stderr] 131 |           if let Some(img) = buffer.take() {
[INFO] [stderr] 132 |             let result = nfd::open_save_dialog(Some("png"), None).unwrap_or_else(|e| {
[INFO] [stderr] 133 |               panic!(e);
[INFO] [stderr] 134 |             });
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:184:47
[INFO] [stderr]     |
[INFO] [stderr] 184 |       let seconds = delta.as_secs() as f64 + (delta.subsec_millis() as f64 / 1000.0);
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(delta.subsec_millis())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.58s
[INFO] running `"docker" "inspect" "ee13711e445de650124f1edee8b84b1fad04a76f0d4394ea5cc67aa5f545055f"`
[INFO] running `"docker" "rm" "-f" "ee13711e445de650124f1edee8b84b1fad04a76f0d4394ea5cc67aa5f545055f"`
[INFO] [stdout] ee13711e445de650124f1edee8b84b1fad04a76f0d4394ea5cc67aa5f545055f