[INFO] updating cached repository mattico/route53-dyndns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattico/route53-dyndns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattico/route53-dyndns" "work/ex/clippy-test-run/sources/stable/gh/mattico/route53-dyndns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattico/route53-dyndns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattico/route53-dyndns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattico/route53-dyndns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattico/route53-dyndns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef2d6220b476c57e2aed9c90a420a3676d02f05a [INFO] sha for GitHub repo mattico/route53-dyndns: ef2d6220b476c57e2aed9c90a420a3676d02f05a [INFO] validating manifest of mattico/route53-dyndns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattico/route53-dyndns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattico/route53-dyndns [INFO] finished frobbing mattico/route53-dyndns [INFO] frobbed toml for mattico/route53-dyndns written to work/ex/clippy-test-run/sources/stable/gh/mattico/route53-dyndns/Cargo.toml [INFO] started frobbing mattico/route53-dyndns [INFO] finished frobbing mattico/route53-dyndns [INFO] frobbed toml for mattico/route53-dyndns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattico/route53-dyndns/Cargo.toml [INFO] crate mattico/route53-dyndns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattico/route53-dyndns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mattico/route53-dyndns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c26236967d87c3528bcadcf2a17ac5d91e18ce6db3eefc7f7176e3b1034eac04 [INFO] running `"docker" "start" "-a" "c26236967d87c3528bcadcf2a17ac5d91e18ce6db3eefc7f7176e3b1034eac04"` [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Compiling rusoto_core v0.35.0 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking rusoto_credential v0.14.0 [INFO] [stderr] Checking rusoto_route53 v0.35.0 [INFO] [stderr] Checking route53-dyndns v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | std::env::var(var).expect(&format!("{} not set", var)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} not set", var))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let record_set = &record_set [INFO] [stderr] | _______________________^ [INFO] [stderr] 80 | | .resource_record_sets [INFO] [stderr] 81 | | .iter() [INFO] [stderr] 82 | | .filter(|rs| rs.type_ == "A" && rs.name == dns_name) [INFO] [stderr] 83 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|rs| rs.type_ == "A" && rs.name == dns_name).next()` with `find(|rs| rs.type_ == "A" && rs.name == dns_name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:107:32 [INFO] [stderr] | [INFO] [stderr] 107 | value: my_ip.into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `my_ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | std::env::var(var).expect(&format!("{} not set", var)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} not set", var))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let record_set = &record_set [INFO] [stderr] | _______________________^ [INFO] [stderr] 80 | | .resource_record_sets [INFO] [stderr] 81 | | .iter() [INFO] [stderr] 82 | | .filter(|rs| rs.type_ == "A" && rs.name == dns_name) [INFO] [stderr] 83 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|rs| rs.type_ == "A" && rs.name == dns_name).next()` with `find(|rs| rs.type_ == "A" && rs.name == dns_name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:107:32 [INFO] [stderr] | [INFO] [stderr] 107 | value: my_ip.into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `my_ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.78s [INFO] running `"docker" "inspect" "c26236967d87c3528bcadcf2a17ac5d91e18ce6db3eefc7f7176e3b1034eac04"` [INFO] running `"docker" "rm" "-f" "c26236967d87c3528bcadcf2a17ac5d91e18ce6db3eefc7f7176e3b1034eac04"` [INFO] [stdout] c26236967d87c3528bcadcf2a17ac5d91e18ce6db3eefc7f7176e3b1034eac04