[INFO] updating cached repository matthin/bscoin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matthin/bscoin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matthin/bscoin" "work/ex/clippy-test-run/sources/stable/gh/matthin/bscoin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthin/bscoin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matthin/bscoin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthin/bscoin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthin/bscoin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 72be3eac202b3d2c82273b9d8d52956df88b4730 [INFO] sha for GitHub repo matthin/bscoin: 72be3eac202b3d2c82273b9d8d52956df88b4730 [INFO] validating manifest of matthin/bscoin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matthin/bscoin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matthin/bscoin [INFO] finished frobbing matthin/bscoin [INFO] frobbed toml for matthin/bscoin written to work/ex/clippy-test-run/sources/stable/gh/matthin/bscoin/Cargo.toml [INFO] started frobbing matthin/bscoin [INFO] finished frobbing matthin/bscoin [INFO] frobbed toml for matthin/bscoin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthin/bscoin/Cargo.toml [INFO] crate matthin/bscoin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matthin/bscoin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matthin/bscoin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6da027fb498e8136258a778a931289691634da9eabfe2a976fb71932ee26a250 [INFO] running `"docker" "start" "-a" "6da027fb498e8136258a778a931289691634da9eabfe2a976fb71932ee26a250"` [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Checking bscoin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `blockchain::Blockchain` [INFO] [stderr] --> src/blockchain.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Blockchain { [INFO] [stderr] 33 | | Blockchain { list: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/blockchain.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let prev = self.list.last().ok_or(io::Error::new( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 38 | | io::ErrorKind::Other, [INFO] [stderr] 39 | | "genesis block should exist", [INFO] [stderr] 40 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | let prev = self.list.last().ok_or_else(|| io::Error::new( [INFO] [stderr] 38 | io::ErrorKind::Other, [INFO] [stderr] 39 | "genesis block should exist", [INFO] [stderr] 40 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `blockchain::Blockchain` [INFO] [stderr] --> src/blockchain.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Blockchain { [INFO] [stderr] 33 | | Blockchain { list: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/blockchain.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let prev = self.list.last().ok_or(io::Error::new( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 38 | | io::ErrorKind::Other, [INFO] [stderr] 39 | | "genesis block should exist", [INFO] [stderr] 40 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | let prev = self.list.last().ok_or_else(|| io::Error::new( [INFO] [stderr] 38 | io::ErrorKind::Other, [INFO] [stderr] 39 | "genesis block should exist", [INFO] [stderr] 40 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.82s [INFO] running `"docker" "inspect" "6da027fb498e8136258a778a931289691634da9eabfe2a976fb71932ee26a250"` [INFO] running `"docker" "rm" "-f" "6da027fb498e8136258a778a931289691634da9eabfe2a976fb71932ee26a250"` [INFO] [stdout] 6da027fb498e8136258a778a931289691634da9eabfe2a976fb71932ee26a250