[INFO] updating cached repository matthiaskrgr/rust_pathfinding_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matthiaskrgr/rust_pathfinding_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matthiaskrgr/rust_pathfinding_test" "work/ex/clippy-test-run/sources/stable/gh/matthiaskrgr/rust_pathfinding_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthiaskrgr/rust_pathfinding_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matthiaskrgr/rust_pathfinding_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthiaskrgr/rust_pathfinding_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthiaskrgr/rust_pathfinding_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca4cab430c369570d512a00cb03beb015c784d0a [INFO] sha for GitHub repo matthiaskrgr/rust_pathfinding_test: ca4cab430c369570d512a00cb03beb015c784d0a [INFO] validating manifest of matthiaskrgr/rust_pathfinding_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matthiaskrgr/rust_pathfinding_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matthiaskrgr/rust_pathfinding_test [INFO] finished frobbing matthiaskrgr/rust_pathfinding_test [INFO] frobbed toml for matthiaskrgr/rust_pathfinding_test written to work/ex/clippy-test-run/sources/stable/gh/matthiaskrgr/rust_pathfinding_test/Cargo.toml [INFO] started frobbing matthiaskrgr/rust_pathfinding_test [INFO] finished frobbing matthiaskrgr/rust_pathfinding_test [INFO] frobbed toml for matthiaskrgr/rust_pathfinding_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthiaskrgr/rust_pathfinding_test/Cargo.toml [INFO] crate matthiaskrgr/rust_pathfinding_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matthiaskrgr/rust_pathfinding_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matthiaskrgr/rust_pathfinding_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc4d301118f958a0b8e0f35fbdeb13b51b3cc0b3ad256dd89b94735e89c47607 [INFO] running `"docker" "start" "-a" "fc4d301118f958a0b8e0f35fbdeb13b51b3cc0b3ad256dd89b94735e89c47607"` [INFO] [stderr] Checking pathfinding v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:27 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:35 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:49 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:27 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:35 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:478:49 [INFO] [stderr] | [INFO] [stderr] 478 | let edge = Edge { id: id, entry: entry, exit: exit, weight: 1.0}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | if edge.exit == (&poss_conn).entry { // collect possible new connections [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `poss_conn.entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | if edge.exit == (&poss_conn).entry { // collect possible new connections [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `poss_conn.entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &vector_of_paths_tmp_.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | for subvector in &vector_of_paths_tmp_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `it` is used as a loop counter. Consider using `for (it, item) in &vector_of_paths.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | for subpath in &vector_of_paths { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in vector_of_paths.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | for subpath in vector_of_paths { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | } else if subpath.weight == shortes_paths[0].weight && index != 0 { // found path of equal size, don't add first path twice if it is the shortest [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(subpath.weight - shortes_paths[0].weight).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | } else if subpath.weight == shortes_paths[0].weight && index != 0 { // found path of equal size, don't add first path twice if it is the shortest [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pathfinding`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &vector_of_paths_tmp_.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | for subvector in &vector_of_paths_tmp_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `it` is used as a loop counter. Consider using `for (it, item) in &vector_of_paths.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | for subpath in &vector_of_paths { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in vector_of_paths.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | for subpath in vector_of_paths { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | } else if subpath.weight == shortes_paths[0].weight && index != 0 { // found path of equal size, don't add first path twice if it is the shortest [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(subpath.weight - shortes_paths[0].weight).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | } else if subpath.weight == shortes_paths[0].weight && index != 0 { // found path of equal size, don't add first path twice if it is the shortest [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pathfinding`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fc4d301118f958a0b8e0f35fbdeb13b51b3cc0b3ad256dd89b94735e89c47607"` [INFO] running `"docker" "rm" "-f" "fc4d301118f958a0b8e0f35fbdeb13b51b3cc0b3ad256dd89b94735e89c47607"` [INFO] [stdout] fc4d301118f958a0b8e0f35fbdeb13b51b3cc0b3ad256dd89b94735e89c47607