[INFO] updating cached repository matthhan/rssidiot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/matthhan/rssidiot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/matthhan/rssidiot" "work/ex/clippy-test-run/sources/stable/gh/matthhan/rssidiot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthhan/rssidiot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/matthhan/rssidiot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthhan/rssidiot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthhan/rssidiot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 720360ab0664def967c2bac61163cafb2e3a0025
[INFO] sha for GitHub repo matthhan/rssidiot: 720360ab0664def967c2bac61163cafb2e3a0025
[INFO] validating manifest of matthhan/rssidiot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of matthhan/rssidiot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing matthhan/rssidiot
[INFO] finished frobbing matthhan/rssidiot
[INFO] frobbed toml for matthhan/rssidiot written to work/ex/clippy-test-run/sources/stable/gh/matthhan/rssidiot/Cargo.toml
[INFO] started frobbing matthhan/rssidiot
[INFO] finished frobbing matthhan/rssidiot
[INFO] frobbed toml for matthhan/rssidiot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthhan/rssidiot/Cargo.toml
[INFO] crate matthhan/rssidiot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting matthhan/rssidiot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matthhan/rssidiot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3bbcd5f7cc041b1d862d9f27597ba8389d850478f6c2ec29644c7ad50f5336ae
[INFO] running `"docker" "start" "-a" "3bbcd5f7cc041b1d862d9f27597ba8389d850478f6c2ec29644c7ad50f5336ae"`
[INFO] [stderr]    Compiling serde v1.0.68
[INFO] [stderr]    Compiling serde_derive v1.0.68
[INFO] [stderr]     Checking serde_json v1.0.22
[INFO] [stderr]     Checking rssidiot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             i:i,
[INFO] [stderr]    |             ^^^ help: replace it with: `i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             buf:buf,
[INFO] [stderr]    |             ^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             buf: buf,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             i:i,
[INFO] [stderr]    |             ^^^ help: replace it with: `i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             buf:buf,
[INFO] [stderr]    |             ^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/circular_buffer.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             buf: buf,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/circular_buffer.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         res
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/circular_buffer.rs:32:19
[INFO] [stderr]    |
[INFO] [stderr] 32 |           let res = if bs_len != 0 {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 33 | |             CircularBufferIterator::new(self,(self.last_inserted + 1) % bs_len)
[INFO] [stderr] 34 | |         } else {
[INFO] [stderr] 35 | |             CircularBufferIterator::empty(self)
[INFO] [stderr] 36 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/circular_buffer.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         res
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/circular_buffer.rs:32:19
[INFO] [stderr]    |
[INFO] [stderr] 32 |           let res = if bs_len != 0 {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 33 | |             CircularBufferIterator::new(self,(self.last_inserted + 1) % bs_len)
[INFO] [stderr] 34 | |         } else {
[INFO] [stderr] 35 | |             CircularBufferIterator::empty(self)
[INFO] [stderr] 36 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/circular_buffer.rs:136:13
[INFO] [stderr]     |
[INFO] [stderr] 136 |         for x in buf.iter() {
[INFO] [stderr]     |             ^ help: consider using `_x` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/circular_buffer.rs:139:13
[INFO] [stderr]     |
[INFO] [stderr] 139 |         for x in buf.iter() {
[INFO] [stderr]     |             ^ help: consider using `_x` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/article.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn new(title: String, url: String) -> Article {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/feed.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn new(name:String,url:String) -> Feed {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_article`
[INFO] [stderr]   --> src/feed.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn add_article(self,art:Article) -> Feed {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/circular_buffer.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub fn new(size:usize) -> CircularBuffer<T> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add`
[INFO] [stderr]   --> src/circular_buffer.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     pub fn add(self,thing: T) -> CircularBuffer<T> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/application.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn new() -> ApplicationState {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_feed`
[INFO] [stderr]   --> src/application.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn add_feed(self, feed:Feed)-> ApplicationState {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/circular_buffer.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn iter<'a>(&'a self) -> CircularBufferIterator<'a,T> {
[INFO] [stderr] 31 | |         let bs_len = self.backing_structure.len();
[INFO] [stderr] 32 | |         let res = if bs_len != 0 {
[INFO] [stderr] 33 | |             CircularBufferIterator::new(self,(self.last_inserted + 1) % bs_len)
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         res
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_article`
[INFO] [stderr]   --> src/feed.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn add_article(self,art:Article) -> Feed {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_feed`
[INFO] [stderr]   --> src/application.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn add_feed(self, feed:Feed)-> ApplicationState {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/circular_buffer.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn iter<'a>(&'a self) -> CircularBufferIterator<'a,T> {
[INFO] [stderr] 31 | |         let bs_len = self.backing_structure.len();
[INFO] [stderr] 32 | |         let res = if bs_len != 0 {
[INFO] [stderr] 33 | |             CircularBufferIterator::new(self,(self.last_inserted + 1) % bs_len)
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         res
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.84s
[INFO] running `"docker" "inspect" "3bbcd5f7cc041b1d862d9f27597ba8389d850478f6c2ec29644c7ad50f5336ae"`
[INFO] running `"docker" "rm" "-f" "3bbcd5f7cc041b1d862d9f27597ba8389d850478f6c2ec29644c7ad50f5336ae"`
[INFO] [stdout] 3bbcd5f7cc041b1d862d9f27597ba8389d850478f6c2ec29644c7ad50f5336ae