[INFO] updating cached repository matthew86707/openGLTesting [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matthew86707/openGLTesting [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matthew86707/openGLTesting" "work/ex/clippy-test-run/sources/stable/gh/matthew86707/openGLTesting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthew86707/openGLTesting'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matthew86707/openGLTesting" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthew86707/openGLTesting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthew86707/openGLTesting'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd0d544631a8a31c875546a216d0a8d3edbd815f [INFO] sha for GitHub repo matthew86707/openGLTesting: dd0d544631a8a31c875546a216d0a8d3edbd815f [INFO] validating manifest of matthew86707/openGLTesting on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matthew86707/openGLTesting on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matthew86707/openGLTesting [INFO] finished frobbing matthew86707/openGLTesting [INFO] frobbed toml for matthew86707/openGLTesting written to work/ex/clippy-test-run/sources/stable/gh/matthew86707/openGLTesting/Cargo.toml [INFO] started frobbing matthew86707/openGLTesting [INFO] finished frobbing matthew86707/openGLTesting [INFO] frobbed toml for matthew86707/openGLTesting written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthew86707/openGLTesting/Cargo.toml [INFO] crate matthew86707/openGLTesting has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matthew86707/openGLTesting against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matthew86707/openGLTesting:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fed1c5d704821aeb2c5a3c693c57d8c4347c5f2ce7172eda302904fcd83cf3b1 [INFO] running `"docker" "start" "-a" "fed1c5d704821aeb2c5a3c693c57d8c4347c5f2ce7172eda302904fcd83cf3b1"` [INFO] [stderr] Compiling libc v0.2.31 [INFO] [stderr] Compiling cc v1.0.0 [INFO] [stderr] Checking either v1.2.0 [INFO] [stderr] Checking smallvec v0.4.3 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking inflate v0.3.2 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Compiling glium v0.17.1 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking png v0.10.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking openGLTesting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut red_value : f32 = 0.0; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `openGLTesting` should have a snake case name such as `open_gltesting` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `texCoords` should have a snake case name such as `tex_coords` [INFO] [stderr] --> src/main.rs:8:6 [INFO] [stderr] | [INFO] [stderr] 8 | texCoords: [f32; 2] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type Vertex [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type Vertex [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match ev { [INFO] [stderr] 132 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 133 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 134 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] ... | [INFO] [stderr] 146 | | _ => (), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 132 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 133 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] 134 | Some(VirtualKeyCode::Escape) => {closed = true;}, [INFO] [stderr] 135 | Some(VirtualKeyCode::Q) => {blue_val = blue_val + 0.1}, [INFO] [stderr] 136 | Some(VirtualKeyCode::E) => {blue_val = blue_val - 0.1}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:136:53 [INFO] [stderr] | [INFO] [stderr] 136 | Some(VirtualKeyCode::Q) => {blue_val = blue_val + 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blue_val += 0.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:137:53 [INFO] [stderr] | [INFO] [stderr] 137 | Some(VirtualKeyCode::E) => {blue_val = blue_val - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blue_val -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:138:53 [INFO] [stderr] | [INFO] [stderr] 138 | Some(VirtualKeyCode::A) => {x_shift = x_shift - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x_shift -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:139:53 [INFO] [stderr] | [INFO] [stderr] 139 | Some(VirtualKeyCode::D) => {x_shift = x_shift + 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x_shift += 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:140:53 [INFO] [stderr] | [INFO] [stderr] 140 | Some(VirtualKeyCode::S) => {y_shift = y_shift - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y_shift -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:141:53 [INFO] [stderr] | [INFO] [stderr] 141 | Some(VirtualKeyCode::W) => {y_shift = y_shift + 0.1} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y_shift += 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `openGLTesting`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut red_value : f32 = 0.0; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `openGLTesting` should have a snake case name such as `open_gltesting` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `texCoords` should have a snake case name such as `tex_coords` [INFO] [stderr] --> src/main.rs:8:6 [INFO] [stderr] | [INFO] [stderr] 8 | texCoords: [f32; 2] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type Vertex [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type Vertex [INFO] [stderr] --> src/main.rs:99:2 [INFO] [stderr] | [INFO] [stderr] 99 | implement_vertex!(Vertex, position, color, texCoords); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match ev { [INFO] [stderr] 132 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 133 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 134 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] ... | [INFO] [stderr] 146 | | _ => (), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 132 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 133 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] 134 | Some(VirtualKeyCode::Escape) => {closed = true;}, [INFO] [stderr] 135 | Some(VirtualKeyCode::Q) => {blue_val = blue_val + 0.1}, [INFO] [stderr] 136 | Some(VirtualKeyCode::E) => {blue_val = blue_val - 0.1}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:136:53 [INFO] [stderr] | [INFO] [stderr] 136 | Some(VirtualKeyCode::Q) => {blue_val = blue_val + 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blue_val += 0.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:137:53 [INFO] [stderr] | [INFO] [stderr] 137 | Some(VirtualKeyCode::E) => {blue_val = blue_val - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blue_val -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:138:53 [INFO] [stderr] | [INFO] [stderr] 138 | Some(VirtualKeyCode::A) => {x_shift = x_shift - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x_shift -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:139:53 [INFO] [stderr] | [INFO] [stderr] 139 | Some(VirtualKeyCode::D) => {x_shift = x_shift + 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x_shift += 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:140:53 [INFO] [stderr] | [INFO] [stderr] 140 | Some(VirtualKeyCode::S) => {y_shift = y_shift - 0.1}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y_shift -= 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:141:53 [INFO] [stderr] | [INFO] [stderr] 141 | Some(VirtualKeyCode::W) => {y_shift = y_shift + 0.1} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y_shift += 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `openGLTesting`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fed1c5d704821aeb2c5a3c693c57d8c4347c5f2ce7172eda302904fcd83cf3b1"` [INFO] running `"docker" "rm" "-f" "fed1c5d704821aeb2c5a3c693c57d8c4347c5f2ce7172eda302904fcd83cf3b1"` [INFO] [stdout] fed1c5d704821aeb2c5a3c693c57d8c4347c5f2ce7172eda302904fcd83cf3b1