[INFO] updating cached repository mattfarina/github-label-adder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattfarina/github-label-adder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattfarina/github-label-adder" "work/ex/clippy-test-run/sources/stable/gh/mattfarina/github-label-adder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattfarina/github-label-adder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattfarina/github-label-adder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattfarina/github-label-adder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattfarina/github-label-adder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ff31dfd7fb1441b995453fefeb729aaef046d05 [INFO] sha for GitHub repo mattfarina/github-label-adder: 6ff31dfd7fb1441b995453fefeb729aaef046d05 [INFO] validating manifest of mattfarina/github-label-adder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattfarina/github-label-adder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattfarina/github-label-adder [INFO] finished frobbing mattfarina/github-label-adder [INFO] frobbed toml for mattfarina/github-label-adder written to work/ex/clippy-test-run/sources/stable/gh/mattfarina/github-label-adder/Cargo.toml [INFO] started frobbing mattfarina/github-label-adder [INFO] finished frobbing mattfarina/github-label-adder [INFO] frobbed toml for mattfarina/github-label-adder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattfarina/github-label-adder/Cargo.toml [INFO] crate mattfarina/github-label-adder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattfarina/github-label-adder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mattfarina/github-label-adder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 615e4eb41e52f1932a8eff38cb41b2a3a3cdd94fbd1309550c6138fd789f75b9 [INFO] running `"docker" "start" "-a" "615e4eb41e52f1932a8eff38cb41b2a3a3cdd94fbd1309550c6138fd789f75b9"` [INFO] [stderr] Compiling serde v1.0.72 [INFO] [stderr] Compiling ryu v0.2.4 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Compiling quote v0.6.6 [INFO] [stderr] Checking regex v1.0.2 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling serde_derive v1.0.72 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking hubcaps v0.4.10 [INFO] [stderr] Checking github-label-adder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(val) => return Ok(val), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return Err(e.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(val) => return Ok(val), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return Err(e.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | let parts: Vec<&str> = repo.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | let parts: Vec<&str> = repo.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "615e4eb41e52f1932a8eff38cb41b2a3a3cdd94fbd1309550c6138fd789f75b9"` [INFO] running `"docker" "rm" "-f" "615e4eb41e52f1932a8eff38cb41b2a3a3cdd94fbd1309550c6138fd789f75b9"` [INFO] [stdout] 615e4eb41e52f1932a8eff38cb41b2a3a3cdd94fbd1309550c6138fd789f75b9