[INFO] updating cached repository mattKipper/advent-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattKipper/advent-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattKipper/advent-2017" "work/ex/clippy-test-run/sources/stable/gh/mattKipper/advent-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattKipper/advent-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattKipper/advent-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/advent-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/advent-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cbbd646af1fac1e41f9117f53341fb585b1c7d0b [INFO] sha for GitHub repo mattKipper/advent-2017: cbbd646af1fac1e41f9117f53341fb585b1c7d0b [INFO] validating manifest of mattKipper/advent-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattKipper/advent-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattKipper/advent-2017 [INFO] finished frobbing mattKipper/advent-2017 [INFO] frobbed toml for mattKipper/advent-2017 written to work/ex/clippy-test-run/sources/stable/gh/mattKipper/advent-2017/Cargo.toml [INFO] started frobbing mattKipper/advent-2017 [INFO] finished frobbing mattKipper/advent-2017 [INFO] frobbed toml for mattKipper/advent-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/advent-2017/Cargo.toml [INFO] crate mattKipper/advent-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattKipper/advent-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mattKipper/advent-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a47a96cb0f6f1ea091b870fd7e7e91a9d19b2803903d87c2fa26deafc43691f [INFO] running `"docker" "start" "-a" "0a47a96cb0f6f1ea091b870fd7e7e91a9d19b2803903d87c2fa26deafc43691f"` [INFO] [stderr] Checking advent-2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/08.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/08.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | operand: operand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/08.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/08.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | operand: operand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/08.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &Operator::EQ => a.eq(b), [INFO] [stderr] 36 | | &Operator::NE => a.ne(b), [INFO] [stderr] 37 | | &Operator::LT => a.lt(b), [INFO] [stderr] ... | [INFO] [stderr] 40 | | &Operator::LE => a.le(b), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | Operator::EQ => a.eq(b), [INFO] [stderr] 36 | Operator::NE => a.ne(b), [INFO] [stderr] 37 | Operator::LT => a.lt(b), [INFO] [stderr] 38 | Operator::GT => a.gt(b), [INFO] [stderr] 39 | Operator::GE => a.ge(b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/08.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &Opcode::Increment => reg.add_assign(val), [INFO] [stderr] 65 | | &Opcode::Decrement => reg.sub_assign(val), [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | Opcode::Increment => reg.add_assign(val), [INFO] [stderr] 65 | Opcode::Decrement => reg.sub_assign(val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/09.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match &ch { [INFO] [stderr] 36 | | &'{' => { [INFO] [stderr] 37 | | total_score += next_group_score; [INFO] [stderr] 38 | | next_group_score += 1; [INFO] [stderr] ... | [INFO] [stderr] 42 | | &_ => {}, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match ch { [INFO] [stderr] 36 | '{' => { [INFO] [stderr] 37 | total_score += next_group_score; [INFO] [stderr] 38 | next_group_score += 1; [INFO] [stderr] 39 | }, [INFO] [stderr] 40 | '}' => next_group_score -= 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/09.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match &ch { [INFO] [stderr] 47 | | &'!' => {stream.next();}, [INFO] [stderr] 48 | | &'>' => in_garbage = false, [INFO] [stderr] 49 | | &_ => {}, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | match ch { [INFO] [stderr] 47 | '!' => {stream.next();}, [INFO] [stderr] 48 | '>' => in_garbage = false, [INFO] [stderr] 49 | _ => {}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/08.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &Operator::EQ => a.eq(b), [INFO] [stderr] 36 | | &Operator::NE => a.ne(b), [INFO] [stderr] 37 | | &Operator::LT => a.lt(b), [INFO] [stderr] ... | [INFO] [stderr] 40 | | &Operator::LE => a.le(b), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | Operator::EQ => a.eq(b), [INFO] [stderr] 36 | Operator::NE => a.ne(b), [INFO] [stderr] 37 | Operator::LT => a.lt(b), [INFO] [stderr] 38 | Operator::GT => a.gt(b), [INFO] [stderr] 39 | Operator::GE => a.ge(b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/08.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &Opcode::Increment => reg.add_assign(val), [INFO] [stderr] 65 | | &Opcode::Decrement => reg.sub_assign(val), [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | Opcode::Increment => reg.add_assign(val), [INFO] [stderr] 65 | Opcode::Decrement => reg.sub_assign(val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/03.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | let n = (((value as f64).sqrt() - 1.0) / 2.0).ceil() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/03.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let value = value as i64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/bin/01.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/09.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match &ch { [INFO] [stderr] 36 | | &'{' => { [INFO] [stderr] 37 | | total_score += next_group_score; [INFO] [stderr] 38 | | next_group_score += 1; [INFO] [stderr] ... | [INFO] [stderr] 42 | | &_ => {}, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] error: Could not compile `advent-2017`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match ch { [INFO] [stderr] 36 | '{' => { [INFO] [stderr] 37 | total_score += next_group_score; [INFO] [stderr] 38 | next_group_score += 1; [INFO] [stderr] 39 | }, [INFO] [stderr] 40 | '}' => next_group_score -= 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/09.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match &ch { [INFO] [stderr] 47 | | &'!' => {stream.next();}, [INFO] [stderr] 48 | | &'>' => in_garbage = false, [INFO] [stderr] 49 | | &_ => {}, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | match ch { [INFO] [stderr] 47 | '!' => {stream.next();}, [INFO] [stderr] 48 | '>' => in_garbage = false, [INFO] [stderr] 49 | _ => {}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/07.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | match line.split(|c| c == '>').skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/06.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | fn max_bank(banks: &Vec) -> (usize, u32) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/bin/01.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `advent-2017`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/03.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | let n = (((value as f64).sqrt() - 1.0) / 2.0).ceil() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/03.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let value = value as i64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0a47a96cb0f6f1ea091b870fd7e7e91a9d19b2803903d87c2fa26deafc43691f"` [INFO] running `"docker" "rm" "-f" "0a47a96cb0f6f1ea091b870fd7e7e91a9d19b2803903d87c2fa26deafc43691f"` [INFO] [stdout] 0a47a96cb0f6f1ea091b870fd7e7e91a9d19b2803903d87c2fa26deafc43691f