[INFO] updating cached repository matsumotory/middlecon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matsumotory/middlecon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matsumotory/middlecon" "work/ex/clippy-test-run/sources/stable/gh/matsumotory/middlecon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matsumotory/middlecon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matsumotory/middlecon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matsumotory/middlecon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matsumotory/middlecon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 01b7d8d5af8f0bdbba5c2b185a01a9ef341ac928 [INFO] sha for GitHub repo matsumotory/middlecon: 01b7d8d5af8f0bdbba5c2b185a01a9ef341ac928 [INFO] validating manifest of matsumotory/middlecon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matsumotory/middlecon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matsumotory/middlecon [INFO] finished frobbing matsumotory/middlecon [INFO] frobbed toml for matsumotory/middlecon written to work/ex/clippy-test-run/sources/stable/gh/matsumotory/middlecon/Cargo.toml [INFO] started frobbing matsumotory/middlecon [INFO] finished frobbing matsumotory/middlecon [INFO] frobbed toml for matsumotory/middlecon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matsumotory/middlecon/Cargo.toml [INFO] crate matsumotory/middlecon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matsumotory/middlecon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matsumotory/middlecon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55025655b9074116cad14a75d319f14af8354b3fd7e7076c38d15e8354cfcbc1 [INFO] running `"docker" "start" "-a" "55025655b9074116cad14a75d319f14af8354b3fd7e7076c38d15e8354cfcbc1"` [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking middlecon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or(num_cpus::get()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:57 [INFO] [stderr] | [INFO] [stderr] 82 | let line = line.and_then(|(reader, vec)| if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or(num_cpus::get()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:57 [INFO] [stderr] | [INFO] [stderr] 82 | let line = line.and_then(|(reader, vec)| if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.61s [INFO] running `"docker" "inspect" "55025655b9074116cad14a75d319f14af8354b3fd7e7076c38d15e8354cfcbc1"` [INFO] running `"docker" "rm" "-f" "55025655b9074116cad14a75d319f14af8354b3fd7e7076c38d15e8354cfcbc1"` [INFO] [stdout] 55025655b9074116cad14a75d319f14af8354b3fd7e7076c38d15e8354cfcbc1