[INFO] updating cached repository matonix/TetrisAttackClone [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matonix/TetrisAttackClone [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matonix/TetrisAttackClone" "work/ex/clippy-test-run/sources/stable/gh/matonix/TetrisAttackClone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matonix/TetrisAttackClone'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matonix/TetrisAttackClone" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matonix/TetrisAttackClone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matonix/TetrisAttackClone'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8125f7d03dcf71e78d1e8896283373e21f0e048 [INFO] sha for GitHub repo matonix/TetrisAttackClone: f8125f7d03dcf71e78d1e8896283373e21f0e048 [INFO] validating manifest of matonix/TetrisAttackClone on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matonix/TetrisAttackClone on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matonix/TetrisAttackClone [INFO] finished frobbing matonix/TetrisAttackClone [INFO] frobbed toml for matonix/TetrisAttackClone written to work/ex/clippy-test-run/sources/stable/gh/matonix/TetrisAttackClone/Cargo.toml [INFO] started frobbing matonix/TetrisAttackClone [INFO] finished frobbing matonix/TetrisAttackClone [INFO] frobbed toml for matonix/TetrisAttackClone written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matonix/TetrisAttackClone/Cargo.toml [INFO] crate matonix/TetrisAttackClone has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matonix/TetrisAttackClone against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matonix/TetrisAttackClone:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 340cb119470b594b6510fdab8ebebe9db4a3e5dcdaacceb4de77e2d8d814231e [INFO] running `"docker" "start" "-a" "340cb119470b594b6510fdab8ebebe9db4a3e5dcdaacceb4de77e2d8d814231e"` [INFO] [stderr] Compiling phf_shared v0.7.19 [INFO] [stderr] Compiling serde v0.8.17 [INFO] [stderr] Compiling bitflags v0.3.3 [INFO] [stderr] Checking bitflags v0.5.0 [INFO] [stderr] Checking odds v0.2.24 [INFO] [stderr] Checking piston-texture v0.4.0 [INFO] [stderr] Checking piston-shaders_graphics2d v0.1.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking draw_state v0.4.0 [INFO] [stderr] Checking gif v0.8.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Compiling xml-rs v0.2.2 [INFO] [stderr] Checking pistoncore-input v0.14.0 [INFO] [stderr] Compiling phf_generator v0.7.19 [INFO] [stderr] Compiling phf v0.7.19 [INFO] [stderr] Checking piston2d-graphics v0.16.0 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.5.2 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Checking miniz-sys v0.1.7 [INFO] [stderr] Checking pistoncore-input v0.10.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking nodrop v0.1.8 [INFO] [stderr] Checking gfx_core v0.2.1 [INFO] [stderr] Checking x11-dl v2.11.0 [INFO] [stderr] Compiling phf_codegen v0.7.19 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking pistoncore-window v0.23.0 [INFO] [stderr] Compiling gl_generator v0.4.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Checking pistoncore-event_loop v0.26.0 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking pistoncore-window v0.17.0 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Compiling gl v0.5.2 [INFO] [stderr] Checking piston v0.26.0 [INFO] [stderr] Checking pistoncore-event_loop v0.20.1 [INFO] [stderr] Checking image v0.9.1 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Checking piston v0.20.1 [INFO] [stderr] Checking gfx v0.10.2 [INFO] [stderr] Checking gfx_device_gl v0.9.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.36.1 [INFO] [stderr] Checking piston-gfx_texture v0.14.0 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.27.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.24.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.31.0 [INFO] [stderr] Checking piston_window v0.44.0 [INFO] [stderr] Checking tetris_attack_clone v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/app.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | use opengl_graphics::{ OpenGL, GlGraphics }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NPANELS_X` [INFO] [stderr] --> src/app.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | const NPANELS_X: u32 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NPANELS_Y` [INFO] [stderr] --> src/app.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | const NPANELS_Y: u32 = 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | let cx = args.width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | let cy = args.height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | let hw = args.width as f64 *0.9 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | let hh = args.height as f64 *0.9 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ----^^^^^----------------------------------------------------------- help: try: `let c = &Context::new_abs(args.width as f64, args.height as f64);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:29:57 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/app.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | use opengl_graphics::{ OpenGL, GlGraphics }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NPANELS_X` [INFO] [stderr] --> src/app.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | const NPANELS_X: u32 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NPANELS_Y` [INFO] [stderr] --> src/app.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | const NPANELS_Y: u32 = 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | let cx = args.width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | let cy = args.height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | let hw = args.width as f64 *0.9 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | let hh = args.height as f64 *0.9 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ----^^^^^----------------------------------------------------------- help: try: `let c = &Context::new_abs(args.width as f64, args.height as f64);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:29:57 [INFO] [stderr] | [INFO] [stderr] 29 | let ref c = Context::new_abs(args.width as f64, args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.40s [INFO] running `"docker" "inspect" "340cb119470b594b6510fdab8ebebe9db4a3e5dcdaacceb4de77e2d8d814231e"` [INFO] running `"docker" "rm" "-f" "340cb119470b594b6510fdab8ebebe9db4a3e5dcdaacceb4de77e2d8d814231e"` [INFO] [stdout] 340cb119470b594b6510fdab8ebebe9db4a3e5dcdaacceb4de77e2d8d814231e