[INFO] updating cached repository matklad/vec-vs-list [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matklad/vec-vs-list [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/vec-vs-list" "work/ex/clippy-test-run/sources/stable/gh/matklad/vec-vs-list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matklad/vec-vs-list'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/vec-vs-list" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/vec-vs-list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/vec-vs-list'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75ef0e76b584b74df5c33a36f6fa3e670448c4bf [INFO] sha for GitHub repo matklad/vec-vs-list: 75ef0e76b584b74df5c33a36f6fa3e670448c4bf [INFO] validating manifest of matklad/vec-vs-list on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matklad/vec-vs-list on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matklad/vec-vs-list [INFO] finished frobbing matklad/vec-vs-list [INFO] frobbed toml for matklad/vec-vs-list written to work/ex/clippy-test-run/sources/stable/gh/matklad/vec-vs-list/Cargo.toml [INFO] started frobbing matklad/vec-vs-list [INFO] finished frobbing matklad/vec-vs-list [INFO] frobbed toml for matklad/vec-vs-list written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/vec-vs-list/Cargo.toml [INFO] crate matklad/vec-vs-list has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matklad/vec-vs-list against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/matklad/vec-vs-list:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b1496676aadcfda9c1eb2b79ef914c110d1573c8b8602252f41fccdd92d78e5 [INFO] running `"docker" "start" "-a" "4b1496676aadcfda9c1eb2b79ef914c110d1573c8b8602252f41fccdd92d78e5"` [INFO] [stderr] Checking linked-list v0.0.3 [INFO] [stderr] Checking bench v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | let xs = time_it("Generate random elements ", || elements()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:20:53 [INFO] [stderr] | [INFO] [stderr] 20 | let i = result.iter().position(|&y| x <= y).unwrap_or(result.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| result.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | println!("{} {} μs", tag, duration.subsec_nanos() / 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | let xs = time_it("Generate random elements ", || elements()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:20:53 [INFO] [stderr] | [INFO] [stderr] 20 | let i = result.iter().position(|&y| x <= y).unwrap_or(result.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| result.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | println!("{} {} μs", tag, duration.subsec_nanos() / 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `"docker" "inspect" "4b1496676aadcfda9c1eb2b79ef914c110d1573c8b8602252f41fccdd92d78e5"` [INFO] running `"docker" "rm" "-f" "4b1496676aadcfda9c1eb2b79ef914c110d1573c8b8602252f41fccdd92d78e5"` [INFO] [stdout] 4b1496676aadcfda9c1eb2b79ef914c110d1573c8b8602252f41fccdd92d78e5