[INFO] updating cached repository mathcrosp/scanner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mathcrosp/scanner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mathcrosp/scanner" "work/ex/clippy-test-run/sources/stable/gh/mathcrosp/scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mathcrosp/scanner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mathcrosp/scanner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mathcrosp/scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mathcrosp/scanner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa8567c4df765fcb75eae8b8d1f045419413f6e6 [INFO] sha for GitHub repo mathcrosp/scanner: fa8567c4df765fcb75eae8b8d1f045419413f6e6 [INFO] validating manifest of mathcrosp/scanner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mathcrosp/scanner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mathcrosp/scanner [INFO] finished frobbing mathcrosp/scanner [INFO] frobbed toml for mathcrosp/scanner written to work/ex/clippy-test-run/sources/stable/gh/mathcrosp/scanner/Cargo.toml [INFO] started frobbing mathcrosp/scanner [INFO] finished frobbing mathcrosp/scanner [INFO] frobbed toml for mathcrosp/scanner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mathcrosp/scanner/Cargo.toml [INFO] crate mathcrosp/scanner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mathcrosp/scanner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mathcrosp/scanner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32c827781dfdb12c6b8b155b3c870561dfde466bba691dc7050d3c964407c0c9 [INFO] running `"docker" "start" "-a" "32c827781dfdb12c6b8b155b3c870561dfde466bba691dc7050d3c964407c0c9"` [INFO] [stderr] Checking scanner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/portscan.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/portscan.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/portscan.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / match net::TcpStream::connect((addr, port)) { [INFO] [stderr] 11 | | Ok(_) => { [INFO] [stderr] 12 | | tx.send(port).unwrap(); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | Err(_) => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Ok(_) = net::TcpStream::connect((addr, port)) { [INFO] [stderr] 11 | tx.send(port).unwrap(); [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let ref program = args[0]; [INFO] [stderr] | ----^^^^^^^^^^^----------- help: try: `let program = &args[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let ref host = args[1]; [INFO] [stderr] | ----^^^^^^^^----------- help: try: `let host = &args[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/portscan.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / match net::TcpStream::connect((addr, port)) { [INFO] [stderr] 11 | | Ok(_) => { [INFO] [stderr] 12 | | tx.send(port).unwrap(); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | Err(_) => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Ok(_) = net::TcpStream::connect((addr, port)) { [INFO] [stderr] 11 | tx.send(port).unwrap(); [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let ref program = args[0]; [INFO] [stderr] | ----^^^^^^^^^^^----------- help: try: `let program = &args[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let ref host = args[1]; [INFO] [stderr] | ----^^^^^^^^----------- help: try: `let host = &args[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "32c827781dfdb12c6b8b155b3c870561dfde466bba691dc7050d3c964407c0c9"` [INFO] running `"docker" "rm" "-f" "32c827781dfdb12c6b8b155b3c870561dfde466bba691dc7050d3c964407c0c9"` [INFO] [stdout] 32c827781dfdb12c6b8b155b3c870561dfde466bba691dc7050d3c964407c0c9