[INFO] updating cached repository mateuszgiza/rust-sdl2-extras
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mateuszgiza/rust-sdl2-extras
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mateuszgiza/rust-sdl2-extras" "work/ex/clippy-test-run/sources/stable/gh/mateuszgiza/rust-sdl2-extras"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mateuszgiza/rust-sdl2-extras'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mateuszgiza/rust-sdl2-extras" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mateuszgiza/rust-sdl2-extras"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mateuszgiza/rust-sdl2-extras'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7fdc103c0169b3ac57c26c71d16551497ccb2337
[INFO] sha for GitHub repo mateuszgiza/rust-sdl2-extras: 7fdc103c0169b3ac57c26c71d16551497ccb2337
[INFO] validating manifest of mateuszgiza/rust-sdl2-extras on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mateuszgiza/rust-sdl2-extras on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mateuszgiza/rust-sdl2-extras
[INFO] finished frobbing mateuszgiza/rust-sdl2-extras
[INFO] frobbed toml for mateuszgiza/rust-sdl2-extras written to work/ex/clippy-test-run/sources/stable/gh/mateuszgiza/rust-sdl2-extras/Cargo.toml
[INFO] started frobbing mateuszgiza/rust-sdl2-extras
[INFO] finished frobbing mateuszgiza/rust-sdl2-extras
[INFO] frobbed toml for mateuszgiza/rust-sdl2-extras written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mateuszgiza/rust-sdl2-extras/Cargo.toml
[INFO] crate mateuszgiza/rust-sdl2-extras has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mateuszgiza/rust-sdl2-extras against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mateuszgiza/rust-sdl2-extras:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] df1854fb9a470608165f99a6a5fb0789f21d1117978d1156536ee82c563ef912
[INFO] running `"docker" "start" "-a" "df1854fb9a470608165f99a6a5fb0789f21d1117978d1156536ee82c563ef912"`
[INFO] [stderr]     Checking floating-duration v0.1.2
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr]     Checking sdl2-extras v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/adapters/canvas_adapter.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             canvas: canvas
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `canvas`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common/text_texture.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             texture: texture,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `texture`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common/text_texture.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |             query: query
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `query`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/managers/resource_manager.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             loader: loader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `loader`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/adapters/canvas_adapter.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             canvas: canvas
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `canvas`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common/text_texture.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             texture: texture,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `texture`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/common/text_texture.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |             query: query
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `query`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/managers/resource_manager.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             loader: loader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `loader`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/adapters/canvas_adapter.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.canvas.as_mut();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.canvas.as_mut()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/adapters/resource_facade.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return TextTexture::new(text_texture, text_query);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TextTexture::new(text_texture, text_query)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/adapters/canvas_adapter.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.canvas.as_mut();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.canvas.as_mut()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/adapters/resource_facade.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return TextTexture::new(text_texture, text_query);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TextTexture::new(text_texture, text_query)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/adapters/resource_facade.rs:50:49
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn get_texture(&mut self, texture_name: &String) -> Result<Rc<Texture>, String> {
[INFO] [stderr]    |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/common/text_texture.rs:10:16
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new<'b>(texture: Texture<'a>, query: TextureQuery) -> Self {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/adapters/resource_facade.rs:50:49
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn get_texture(&mut self, texture_name: &String) -> Result<Rc<Texture>, String> {
[INFO] [stderr]    |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/common/text_texture.rs:10:16
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new<'b>(texture: Texture<'a>, query: TextureQuery) -> Self {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.27s
[INFO] running `"docker" "inspect" "df1854fb9a470608165f99a6a5fb0789f21d1117978d1156536ee82c563ef912"`
[INFO] running `"docker" "rm" "-f" "df1854fb9a470608165f99a6a5fb0789f21d1117978d1156536ee82c563ef912"`
[INFO] [stdout] df1854fb9a470608165f99a6a5fb0789f21d1117978d1156536ee82c563ef912