[INFO] updating cached repository masterfuzz/hello-rust-http [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/masterfuzz/hello-rust-http [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/masterfuzz/hello-rust-http" "work/ex/clippy-test-run/sources/stable/gh/masterfuzz/hello-rust-http"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/masterfuzz/hello-rust-http'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/masterfuzz/hello-rust-http" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/masterfuzz/hello-rust-http"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/masterfuzz/hello-rust-http'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa4e394abbb57b82638c9cc094009c8e41f29734 [INFO] sha for GitHub repo masterfuzz/hello-rust-http: fa4e394abbb57b82638c9cc094009c8e41f29734 [INFO] validating manifest of masterfuzz/hello-rust-http on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of masterfuzz/hello-rust-http on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing masterfuzz/hello-rust-http [INFO] finished frobbing masterfuzz/hello-rust-http [INFO] frobbed toml for masterfuzz/hello-rust-http written to work/ex/clippy-test-run/sources/stable/gh/masterfuzz/hello-rust-http/Cargo.toml [INFO] started frobbing masterfuzz/hello-rust-http [INFO] finished frobbing masterfuzz/hello-rust-http [INFO] frobbed toml for masterfuzz/hello-rust-http written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/masterfuzz/hello-rust-http/Cargo.toml [INFO] crate masterfuzz/hello-rust-http has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting masterfuzz/hello-rust-http against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/masterfuzz/hello-rust-http:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5fbd5637ab86a84ac61ef9576f6a4e73ddc64ede3e2378dab723697636282b5 [INFO] running `"docker" "start" "-a" "c5fbd5637ab86a84ac61ef9576f6a4e73ddc64ede3e2378dab723697636282b5"` [INFO] [stderr] Checking helloweb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(Server{binding: binding, listener: res.ok().unwrap()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | Response{status_code: status, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(Server{binding: binding, listener: res.ok().unwrap()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | Response{status_code: status, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `body` [INFO] [stderr] --> src/http.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | body: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Post` [INFO] [stderr] --> src/http.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Put` [INFO] [stderr] --> src/http.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Head` [INFO] [stderr] --> src/http.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Delete` [INFO] [stderr] --> src/http.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Patch` [INFO] [stderr] --> src/http.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Options` [INFO] [stderr] --> src/http.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `binding` [INFO] [stderr] --> src/http.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | binding: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn new(status: Status, body: Option>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `log` [INFO] [stderr] --> src/http.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | fn log(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/http.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | match request.split(" ").nth(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | stream.write(response.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | resp.write(&mut stream); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `helloweb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `body` [INFO] [stderr] --> src/http.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | body: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Post` [INFO] [stderr] --> src/http.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Put` [INFO] [stderr] --> src/http.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Head` [INFO] [stderr] --> src/http.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Delete` [INFO] [stderr] --> src/http.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Patch` [INFO] [stderr] --> src/http.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Options` [INFO] [stderr] --> src/http.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | Get, Post, Put, Head, Delete, Patch, Options [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `binding` [INFO] [stderr] --> src/http.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | binding: &'static str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn new(status: Status, body: Option>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `log` [INFO] [stderr] --> src/http.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | fn log(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/http.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | match request.split(" ").nth(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | stream.write(response.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | resp.write(&mut stream); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `helloweb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c5fbd5637ab86a84ac61ef9576f6a4e73ddc64ede3e2378dab723697636282b5"` [INFO] running `"docker" "rm" "-f" "c5fbd5637ab86a84ac61ef9576f6a4e73ddc64ede3e2378dab723697636282b5"` [INFO] [stdout] c5fbd5637ab86a84ac61ef9576f6a4e73ddc64ede3e2378dab723697636282b5