[INFO] updating cached repository maruks/shuffle-cards-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/maruks/shuffle-cards-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/maruks/shuffle-cards-rust" "work/ex/clippy-test-run/sources/stable/gh/maruks/shuffle-cards-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maruks/shuffle-cards-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/maruks/shuffle-cards-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maruks/shuffle-cards-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maruks/shuffle-cards-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1ca81618cc85bc8060aa58f1220ea3bfb9ea4bfb
[INFO] sha for GitHub repo maruks/shuffle-cards-rust: 1ca81618cc85bc8060aa58f1220ea3bfb9ea4bfb
[INFO] validating manifest of maruks/shuffle-cards-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maruks/shuffle-cards-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maruks/shuffle-cards-rust
[INFO] finished frobbing maruks/shuffle-cards-rust
[INFO] frobbed toml for maruks/shuffle-cards-rust written to work/ex/clippy-test-run/sources/stable/gh/maruks/shuffle-cards-rust/Cargo.toml
[INFO] started frobbing maruks/shuffle-cards-rust
[INFO] finished frobbing maruks/shuffle-cards-rust
[INFO] frobbed toml for maruks/shuffle-cards-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maruks/shuffle-cards-rust/Cargo.toml
[INFO] crate maruks/shuffle-cards-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maruks/shuffle-cards-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maruks/shuffle-cards-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e74d48927543a7c77ceafc6df9fac391a2c2010799d345e693528820c10e8952
[INFO] running `"docker" "start" "-a" "e74d48927543a7c77ceafc6df9fac391a2c2010799d345e693528820c10e8952"`
[INFO] [stderr]     Checking shuffle_cards v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this looks like you are swapping elements of `array` manually
[INFO] [stderr]   --> src/main.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         let t = array[i];
[INFO] [stderr] 46 | |         array[i] = array[rand_idx];
[INFO] [stderr] 47 | |         array[rand_idx] = t;
[INFO] [stderr]    | |___________________________^ help: try: `array.swap(i, rand_idx)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cards`
[INFO] [stderr]   --> src/main.rs:53:14
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for i in 0..NUMBER_OF_CARDS {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for (i, <item>) in cards.iter_mut().enumerate().take(NUMBER_OF_CARDS) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cards`
[INFO] [stderr]   --> src/main.rs:78:14
[INFO] [stderr]    |
[INFO] [stderr] 78 |     for i in 0..NUMBER_OF_CARDS {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 78 |     for (i, <item>) in cards.iter().enumerate().take(NUMBER_OF_CARDS) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `array` manually
[INFO] [stderr]   --> src/main.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         let t = array[i];
[INFO] [stderr] 46 | |         array[i] = array[rand_idx];
[INFO] [stderr] 47 | |         array[rand_idx] = t;
[INFO] [stderr]    | |___________________________^ help: try: `array.swap(i, rand_idx)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cards`
[INFO] [stderr]   --> src/main.rs:53:14
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for i in 0..NUMBER_OF_CARDS {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for (i, <item>) in cards.iter_mut().enumerate().take(NUMBER_OF_CARDS) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cards`
[INFO] [stderr]   --> src/main.rs:78:14
[INFO] [stderr]    |
[INFO] [stderr] 78 |     for i in 0..NUMBER_OF_CARDS {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 78 |     for (i, <item>) in cards.iter().enumerate().take(NUMBER_OF_CARDS) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.88s
[INFO] running `"docker" "inspect" "e74d48927543a7c77ceafc6df9fac391a2c2010799d345e693528820c10e8952"`
[INFO] running `"docker" "rm" "-f" "e74d48927543a7c77ceafc6df9fac391a2c2010799d345e693528820c10e8952"`
[INFO] [stdout] e74d48927543a7c77ceafc6df9fac391a2c2010799d345e693528820c10e8952