[INFO] updating cached repository martinus/bitcoin-utxo-visualizer-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/martinus/bitcoin-utxo-visualizer-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/martinus/bitcoin-utxo-visualizer-rs" "work/ex/clippy-test-run/sources/stable/gh/martinus/bitcoin-utxo-visualizer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martinus/bitcoin-utxo-visualizer-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/martinus/bitcoin-utxo-visualizer-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinus/bitcoin-utxo-visualizer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinus/bitcoin-utxo-visualizer-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db82ffc194a6d28f61db54dd761607ea7aadcdf6 [INFO] sha for GitHub repo martinus/bitcoin-utxo-visualizer-rs: db82ffc194a6d28f61db54dd761607ea7aadcdf6 [INFO] validating manifest of martinus/bitcoin-utxo-visualizer-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of martinus/bitcoin-utxo-visualizer-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing martinus/bitcoin-utxo-visualizer-rs [INFO] finished frobbing martinus/bitcoin-utxo-visualizer-rs [INFO] frobbed toml for martinus/bitcoin-utxo-visualizer-rs written to work/ex/clippy-test-run/sources/stable/gh/martinus/bitcoin-utxo-visualizer-rs/Cargo.toml [INFO] started frobbing martinus/bitcoin-utxo-visualizer-rs [INFO] finished frobbing martinus/bitcoin-utxo-visualizer-rs [INFO] frobbed toml for martinus/bitcoin-utxo-visualizer-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinus/bitcoin-utxo-visualizer-rs/Cargo.toml [INFO] crate martinus/bitcoin-utxo-visualizer-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting martinus/bitcoin-utxo-visualizer-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/martinus/bitcoin-utxo-visualizer-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1a9038e9fad7538b21e7d59f17a80d7b78480b1c0e9a802fd562b1d7e8806c7 [INFO] running `"docker" "start" "-a" "f1a9038e9fad7538b21e7d59f17a80d7b78480b1c0e9a802fd562b1d7e8806c7"` [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking bitcoin-utxo-visualizer-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/fast_file_source.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let ffs = FastFileSource { mmap: mmap }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | LinearFunction { k: k, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | LinearFunction { k: k, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | pixel_height: pixel_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | min_satoshi: min_satoshi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_satoshi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | max_satoshi: max_satoshi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_satoshi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/fast_file_source.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | let ffs = FastFileSource { mmap: mmap }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | LinearFunction { k: k, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | LinearFunction { k: k, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | pixel_height: pixel_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | min_satoshi: min_satoshi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_satoshi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blk/change_to_pixel.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | max_satoshi: max_satoshi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_satoshi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return Some((*it.next()?).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((*it.next()?).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blk/parser.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | if byte <= 0b01111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Some((bytes, val as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((bytes, val as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(parse_u64(it)? as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(parse_u64(it)? as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blk/parser.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if 0x004b4c42 != magick_blk0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x004b_4c42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return CheckSequential { [INFO] [stderr] 22 | | last_block: 0_u32.wrapping_sub(1), [INFO] [stderr] 23 | | num_changes: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | CheckSequential { [INFO] [stderr] 22 | last_block: 0_u32.wrapping_sub(1), [INFO] [stderr] 23 | num_changes: 0, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ChangeToPixel` [INFO] [stderr] --> src/blk/change_to_pixel.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct ChangeToPixel { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `LinearFunction` [INFO] [stderr] --> src/blk/change_to_pixel.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub struct LinearFunction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/blk/change_to_pixel.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn new(x1: f64, y1: f64, x2: f64, y2: f64) -> LinearFunction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `calc` [INFO] [stderr] --> src/blk/change_to_pixel.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn calc(&self, x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/blk/change_to_pixel.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn new(pixel_height: u32, min_satoshi: i64, max_satoshi: i64) -> ChangeToPixel { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `next::(it)?` [INFO] [stderr] --> src/blk/parser.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/blk/parser.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/blk/parser.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | x |= next::(it)? << (8 * 1); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `next::(it)?` [INFO] [stderr] --> src/blk/parser.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/blk/parser.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/blk/parser.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | x |= next::(it)? << (8 * 1); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blk/parser.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | val |= (byte as u64) << (7 * num_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return Some((*it.next()?).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((*it.next()?).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return Some(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blk/parser.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | if byte <= 0b01111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Some((bytes, val as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((bytes, val as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blk/parser.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(parse_u64(it)? as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(parse_u64(it)? as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blk/parser.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if 0x004b4c42 != magick_blk0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x004b_4c42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return CheckSequential { [INFO] [stderr] 22 | | last_block: 0_u32.wrapping_sub(1), [INFO] [stderr] 23 | | num_changes: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | CheckSequential { [INFO] [stderr] 22 | last_block: 0_u32.wrapping_sub(1), [INFO] [stderr] 23 | num_changes: 0, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bitcoin-utxo-visualizer-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `pixel_height` [INFO] [stderr] --> src/blk/change_to_pixel.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pixel_height: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `min_satoshi` [INFO] [stderr] --> src/blk/change_to_pixel.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | min_satoshi: i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `max_satoshi` [INFO] [stderr] --> src/blk/change_to_pixel.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | max_satoshi: i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `next::(it)?` [INFO] [stderr] --> src/blk/parser.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/blk/parser.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/blk/parser.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | x |= next::(it)? << (8 * 1); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `next::(it)?` [INFO] [stderr] --> src/blk/parser.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/blk/parser.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | x |= next::(it)? << (8 * 0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/blk/parser.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | x |= next::(it)? << (8 * 1); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blk/parser.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | val |= (byte as u64) << (7 * num_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/blk/change_to_pixel.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if a == b { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/blk/change_to_pixel.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if a == b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bitcoin-utxo-visualizer-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f1a9038e9fad7538b21e7d59f17a80d7b78480b1c0e9a802fd562b1d7e8806c7"` [INFO] running `"docker" "rm" "-f" "f1a9038e9fad7538b21e7d59f17a80d7b78480b1c0e9a802fd562b1d7e8806c7"` [INFO] [stdout] f1a9038e9fad7538b21e7d59f17a80d7b78480b1c0e9a802fd562b1d7e8806c7