[INFO] updating cached repository martinszy/rustelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/martinszy/rustelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/martinszy/rustelbrot" "work/ex/clippy-test-run/sources/stable/gh/martinszy/rustelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martinszy/rustelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/martinszy/rustelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinszy/rustelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinszy/rustelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3fa238f137e532b02aefaa2a2c3acf6ae49cff17 [INFO] sha for GitHub repo martinszy/rustelbrot: 3fa238f137e532b02aefaa2a2c3acf6ae49cff17 [INFO] validating manifest of martinszy/rustelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of martinszy/rustelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing martinszy/rustelbrot [INFO] finished frobbing martinszy/rustelbrot [INFO] frobbed toml for martinszy/rustelbrot written to work/ex/clippy-test-run/sources/stable/gh/martinszy/rustelbrot/Cargo.toml [INFO] started frobbing martinszy/rustelbrot [INFO] finished frobbing martinszy/rustelbrot [INFO] frobbed toml for martinszy/rustelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinszy/rustelbrot/Cargo.toml [INFO] crate martinszy/rustelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting martinszy/rustelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/martinszy/rustelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46b6baa7d98029cfa32a8fdc33b02cbceb65dc6a54548598a85a0411dbbc21b9 [INFO] running `"docker" "start" "-a" "46b6baa7d98029cfa32a8fdc33b02cbceb65dc6a54548598a85a0411dbbc21b9"` [INFO] [stderr] Compiling cairo-rs v0.2.0 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling glib-sys v0.4.0 [INFO] [stderr] Compiling gobject-sys v0.4.0 [INFO] [stderr] Compiling freetype-sys v0.4.0 [INFO] [stderr] Compiling cairo-sys-rs v0.4.0 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking freetype-rs v0.13.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking glib v0.3.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking glfw v0.15.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking ncollide_math v0.8.0 [INFO] [stderr] Checking ncollide_utils v0.8.0 [INFO] [stderr] Checking ncollide_geometry v0.5.1 [INFO] [stderr] Checking ncollide_procedural v0.8.0 [INFO] [stderr] Checking kiss3d v0.11.0 [INFO] [stderr] Checking ncollide_pipeline v0.12.1 [INFO] [stderr] Checking ncollide_transformation v0.8.0 [INFO] [stderr] Checking ncollide v0.13.0 [INFO] [stderr] Checking rustelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_2d.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | let mut a = window.add_sphere(spheresize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_2d.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | let mut a = window.add_sphere(spheresize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2d.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_2d.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3-current_frame).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2d.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Point3`, `Vector3` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | use self::na::{Vector3, Point3}; [INFO] [stderr] | ^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::kiss3d::window::Window` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use self::kiss3d::window::Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::kiss3d::light::Light` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use self::kiss3d::light::Light; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return (s2,s3) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(s2,s3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | let p2 = E**&((&z2).abs()*-1.0); //derivada ? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | let p3 = E**&((&z3).abs()*-1.0); //derivada ? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2dvid.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2dvid.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.457_367_171_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:27 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.457_367_171_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.406_849_481_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:55 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.406_849_481_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2d.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_2d.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3-current_frame).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2d.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Point3`, `Vector3` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | use self::na::{Vector3, Point3}; [INFO] [stderr] | ^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::kiss3d::window::Window` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use self::kiss3d::window::Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::kiss3d::light::Light` [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use self::kiss3d::light::Light; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return (s2,s3) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(s2,s3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | let p2 = E**&((&z2).abs()*-1.0); //derivada ? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | let p3 = E**&((&z3).abs()*-1.0); //derivada ? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2dvid.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return s [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `((&z2+&z3).abs()*-1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustelbrot_2dvid.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return (z2cr,z2ci) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(z2cr,z2ci)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.457_367_171_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:27 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.457_367_171_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.406_849_481_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustelbrot.rs:58:55 [INFO] [stderr] | [INFO] [stderr] 58 | boxend: [0.4573671713,0.4573671717,-0.4068494815,-0.4068494811], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.406_849_481_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rot` [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | let rot = UnitQuaternion::from_axis_angle(&Vector3::y_axis(), 0.014); [INFO] [stderr] | ^^^ help: consider using `_rot` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_2d.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_2d.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((z2+z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2d.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2d.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:38 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:55 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:55 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_2d.rs:121:99 [INFO] [stderr] | [INFO] [stderr] 121 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:229:55 [INFO] [stderr] | [INFO] [stderr] 229 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:93:99 [INFO] [stderr] | [INFO] [stderr] 93 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:68 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:83 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:100 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | let duration = frame_start.elapsed().as_secs() as f64 + frame_start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:286:55 [INFO] [stderr] | [INFO] [stderr] 286 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / ( [INFO] [stderr] 95 | | &2.0 - [INFO] [stderr] | | ---- help: use the left value directly: `2.0` [INFO] [stderr] 96 | | (s - from_range.0) / [INFO] [stderr] 97 | | (from_range.1 - from_range.0) [INFO] [stderr] 98 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rot` [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | let rot = UnitQuaternion::from_axis_angle(&Vector3::y_axis(), 0.014); [INFO] [stderr] | ^^^ help: consider using `_rot` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | let quad = quad_with_vertices(&vec![],(config.dimentions[0]/(config.pixelsize)) as usize,(config.dimentions[1]/config.pixelsize) as usize); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | s2 = s2 + p2; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s2 += p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | s3 = s3 + p3; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s3 += p3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / ( [INFO] [stderr] 100 | | &2.0 - [INFO] [stderr] | | ---- help: use the left value directly: `2.0` [INFO] [stderr] 101 | | (s - from_range.0) / [INFO] [stderr] 102 | | (from_range.1 - from_range.0) [INFO] [stderr] 103 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:280:55 [INFO] [stderr] | [INFO] [stderr] 280 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_2dvid.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_2dvid.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2dvid.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2dvid.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:55 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:55 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:120:99 [INFO] [stderr] | [INFO] [stderr] 120 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:130:77 [INFO] [stderr] | [INFO] [stderr] 130 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:149:77 [INFO] [stderr] | [INFO] [stderr] 149 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:159:77 [INFO] [stderr] | [INFO] [stderr] 159 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_2d.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_2d.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((z2+z3-current_frame).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2d.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2d.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:38 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:88:55 [INFO] [stderr] | [INFO] [stderr] 88 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:108:55 [INFO] [stderr] | [INFO] [stderr] 108 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_2d.rs:121:99 [INFO] [stderr] | [INFO] [stderr] 121 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustelbrot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 153 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2d.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 154 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2d.rs:229:55 [INFO] [stderr] | [INFO] [stderr] 229 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:93:99 [INFO] [stderr] | [INFO] [stderr] 93 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 126 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 127 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:68 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:83 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:188:100 [INFO] [stderr] | [INFO] [stderr] 188 | layers[corresponding_layer as usize].cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | let duration = frame_start.elapsed().as_secs() as f64 + frame_start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dlayers.rs:286:55 [INFO] [stderr] | [INFO] [stderr] 286 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 54 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / ( [INFO] [stderr] 95 | | &2.0 - [INFO] [stderr] | | ---- help: use the left value directly: `2.0` [INFO] [stderr] 96 | | (s - from_range.0) / [INFO] [stderr] 97 | | (from_range.1 - from_range.0) [INFO] [stderr] 98 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 117 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 118 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | let quad = quad_with_vertices(&vec![],(config.dimentions[0]/(config.pixelsize)) as usize,(config.dimentions[1]/config.pixelsize) as usize); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dsphere.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | s2 = s2 + p2; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s2 += p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | s3 = s3 + p3; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s3 += p3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / ( [INFO] [stderr] 100 | | &2.0 - [INFO] [stderr] | | ---- help: use the left value directly: `2.0` [INFO] [stderr] 101 | | (s - from_range.0) / [INFO] [stderr] 102 | | (from_range.1 - from_range.0) [INFO] [stderr] 103 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 125 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 126 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_3dmesh.rs:280:55 [INFO] [stderr] | [INFO] [stderr] 280 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rustelbrot_2dvid.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(z2 - z0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rustelbrot_2dvid.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if z2 == z0 || z2.is_nan() || z2 > 4.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((&z2+&z3).abs()*-1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 38 | let p = E**&((z2+z3).abs()*-1.0); [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2dvid.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | s = s + p; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustelbrot_2dvid.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:87:55 [INFO] [stderr] | [INFO] [stderr] 87 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rgb.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:107:55 [INFO] [stderr] | [INFO] [stderr] 107 | cr.set_source_rgb(rgb.red as f64,rgb.green as f64,rgb.blue as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rgb.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:120:99 [INFO] [stderr] | [INFO] [stderr] 120 | to_range.0 + (s - from_range.0) * (to_range.1 - to_range.0) / (from_range.1 - from_range.0) * (&2.0 - (s - from_range.0) / (from_range.1 - from_range.0)) [INFO] [stderr] | ^----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (&boxi[1]-&boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 148 | let precissionx:f64 = (boxi[1]-boxi[0])/&(config.dimentions[0]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `config.pixelsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(config.dimentions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/rustelbrot_2dvid.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (&boxi[3]-&boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 149 | let precissiony:f64 = (boxi[3]-boxi[2])/&(config.dimentions[1]) * &config.pixelsize; [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rustelbrot_2dvid.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | let duration = start.elapsed().as_secs() as f64 + start.elapsed().subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start.elapsed().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:130:77 [INFO] [stderr] | [INFO] [stderr] 130 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:149:77 [INFO] [stderr] | [INFO] [stderr] 149 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustelbrot.rs:159:77 [INFO] [stderr] | [INFO] [stderr] 159 | let vec = v.parse::().unwrap().split("x").filter_map(|x| x.parse::().ok()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustelbrot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "46b6baa7d98029cfa32a8fdc33b02cbceb65dc6a54548598a85a0411dbbc21b9"` [INFO] running `"docker" "rm" "-f" "46b6baa7d98029cfa32a8fdc33b02cbceb65dc6a54548598a85a0411dbbc21b9"` [INFO] [stdout] 46b6baa7d98029cfa32a8fdc33b02cbceb65dc6a54548598a85a0411dbbc21b9