[INFO] updating cached repository martinhath/dyne [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/martinhath/dyne [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/martinhath/dyne" "work/ex/clippy-test-run/sources/stable/gh/martinhath/dyne"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martinhath/dyne'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/martinhath/dyne" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinhath/dyne"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinhath/dyne'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 254edfc22f86fedbb3e638eef5a2d19ce6841b34 [INFO] sha for GitHub repo martinhath/dyne: 254edfc22f86fedbb3e638eef5a2d19ce6841b34 [INFO] validating manifest of martinhath/dyne on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of martinhath/dyne on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing martinhath/dyne [INFO] finished frobbing martinhath/dyne [INFO] frobbed toml for martinhath/dyne written to work/ex/clippy-test-run/sources/stable/gh/martinhath/dyne/Cargo.toml [INFO] started frobbing martinhath/dyne [INFO] finished frobbing martinhath/dyne [INFO] frobbed toml for martinhath/dyne written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinhath/dyne/Cargo.toml [INFO] crate martinhath/dyne has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting martinhath/dyne against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/martinhath/dyne:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b1c2608801b288d7366e96dceb27baf44f9d721354358f0667f232264901433 [INFO] running `"docker" "start" "-a" "1b1c2608801b288d7366e96dceb27baf44f9d721354358f0667f232264901433"` [INFO] [stderr] Compiling cc v1.0.0 [INFO] [stderr] Compiling openssl v0.9.19 [INFO] [stderr] Checking unicode-xid v0.0.4 [INFO] [stderr] Checking quote v0.3.15 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.6 [INFO] [stderr] Checking synom v0.11.3 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking mime v0.3.4 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Compiling openssl-sys v0.9.19 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Compiling backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking askama_shared v0.5.0 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Compiling askama_derive v0.5.0 [INFO] [stderr] Checking askama v0.5.0 [INFO] [stderr] Checking dyne v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/server.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/server.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/server.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | .or(request.remote_addr().map(|h| h.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| request.remote_addr().map(|h| h.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match req.method() { [INFO] [stderr] 100 | | &hyper::Method::Post => handle_ping(req), [INFO] [stderr] 101 | | &hyper::Method::Get => serve_index(req), [INFO] [stderr] 102 | | _ => Box::new(futures::future::ok(Response::new().with_status( [INFO] [stderr] 103 | | hyper::StatusCode::MethodNotAllowed, [INFO] [stderr] 104 | | ))), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *req.method() { [INFO] [stderr] 100 | hyper::Method::Post => handle_ping(req), [INFO] [stderr] 101 | hyper::Method::Get => serve_index(req), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/server.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | .or(request.remote_addr().map(|h| h.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| request.remote_addr().map(|h| h.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match req.method() { [INFO] [stderr] 100 | | &hyper::Method::Post => handle_ping(req), [INFO] [stderr] 101 | | &hyper::Method::Get => serve_index(req), [INFO] [stderr] 102 | | _ => Box::new(futures::future::ok(Response::new().with_status( [INFO] [stderr] 103 | | hyper::StatusCode::MethodNotAllowed, [INFO] [stderr] 104 | | ))), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *req.method() { [INFO] [stderr] 100 | hyper::Method::Post => handle_ping(req), [INFO] [stderr] 101 | hyper::Method::Get => serve_index(req), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/client.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / addrs [INFO] [stderr] 24 | | .iter() [INFO] [stderr] 25 | | .map(|addr| addr.ip()) [INFO] [stderr] 26 | | .filter(IpAddr::is_ipv4) [INFO] [stderr] 27 | | .filter(|a| !a.is_loopback()) [INFO] [stderr] 28 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|a| !a.is_loopback()).next()` with `find(|a| !a.is_loopback())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/client.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | let uri: hyper::Uri = uri_str.parse().expect( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 55 | | &format!("Failed to parse uri: {}", uri_str), [INFO] [stderr] 56 | | ); [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse uri: {}", uri_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/client.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / addrs [INFO] [stderr] 24 | | .iter() [INFO] [stderr] 25 | | .map(|addr| addr.ip()) [INFO] [stderr] 26 | | .filter(IpAddr::is_ipv4) [INFO] [stderr] 27 | | .filter(|a| !a.is_loopback()) [INFO] [stderr] 28 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|a| !a.is_loopback()).next()` with `find(|a| !a.is_loopback())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/client.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | let uri: hyper::Uri = uri_str.parse().expect( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 55 | | &format!("Failed to parse uri: {}", uri_str), [INFO] [stderr] 56 | | ); [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse uri: {}", uri_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.27s [INFO] running `"docker" "inspect" "1b1c2608801b288d7366e96dceb27baf44f9d721354358f0667f232264901433"` [INFO] running `"docker" "rm" "-f" "1b1c2608801b288d7366e96dceb27baf44f9d721354358f0667f232264901433"` [INFO] [stdout] 1b1c2608801b288d7366e96dceb27baf44f9d721354358f0667f232264901433