[INFO] updating cached repository martinak1/uranusbound [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/martinak1/uranusbound [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/martinak1/uranusbound" "work/ex/clippy-test-run/sources/stable/gh/martinak1/uranusbound"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martinak1/uranusbound'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/martinak1/uranusbound" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinak1/uranusbound"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinak1/uranusbound'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa304a135ed666c428b39bb82271f4398a9fa01e [INFO] sha for GitHub repo martinak1/uranusbound: aa304a135ed666c428b39bb82271f4398a9fa01e [INFO] validating manifest of martinak1/uranusbound on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of martinak1/uranusbound on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing martinak1/uranusbound [INFO] finished frobbing martinak1/uranusbound [INFO] frobbed toml for martinak1/uranusbound written to work/ex/clippy-test-run/sources/stable/gh/martinak1/uranusbound/Cargo.toml [INFO] started frobbing martinak1/uranusbound [INFO] finished frobbing martinak1/uranusbound [INFO] frobbed toml for martinak1/uranusbound written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martinak1/uranusbound/Cargo.toml [INFO] crate martinak1/uranusbound has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting martinak1/uranusbound against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/martinak1/uranusbound:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 628c2de576cf0976516e446eab5c3631515692d2155297b10f726206fab5d01f [INFO] running `"docker" "start" "-a" "628c2de576cf0976516e446eab5c3631515692d2155297b10f726206fab5d01f"` [INFO] [stderr] Checking base64 v0.1.1 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking xml-rs v0.3.6 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling glium v0.21.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking tiled v0.7.4 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston2d-glium_graphics v0.50.0 [INFO] [stderr] Checking uranusbound v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Flip`, `TextureSettings`, `Texture` [INFO] [stderr] --> src/main.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | use glium_graphics::{Flip, Glium2d, GliumWindow, OpenGL, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::event_loop::EventLoop` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use piston::event_loop::EventLoop; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Tile` [INFO] [stderr] --> src/main.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | use camera::{Camera, Tile}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Flip`, `TextureSettings`, `Texture` [INFO] [stderr] --> src/main.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | use glium_graphics::{Flip, Glium2d, GliumWindow, OpenGL, Texture, TextureSettings}; [INFO] [stderr] | ^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::event_loop::EventLoop` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use piston::event_loop::EventLoop; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Tile` [INFO] [stderr] --> src/main.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | use camera::{Camera, Tile}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: field is never used: `map_buffer` [INFO] [stderr] --> src/camera.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | map_buffer: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_width` [INFO] [stderr] --> src/camera.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_width(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_height` [INFO] [stderr] --> src/camera.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn get_height(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_buffer` [INFO] [stderr] --> src/camera.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_tile_buffer(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut_tile_buffer` [INFO] [stderr] --> src/camera.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_mut_tile_buffer(&mut self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_map_buffer` [INFO] [stderr] --> src/camera.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn get_map_buffer(&self) -> &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut_map_buffer` [INFO] [stderr] --> src/camera.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn get_mut_map_buffer(&mut self) -> &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/camera.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn new() -> Camera { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_tile_buffer` [INFO] [stderr] --> src/camera.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn clear_tile_buffer(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tile_buffer_reserve` [INFO] [stderr] --> src/camera.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn tile_buffer_reserve(&mut self, size: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_to_tile_buffer` [INFO] [stderr] --> src/camera.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn push_to_tile_buffer(&mut self, tile: Tile) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_to_map_buffer` [INFO] [stderr] --> src/camera.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn push_to_map_buffer(&mut self, name: String, map: Map) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tex_rect` [INFO] [stderr] --> src/camera.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn tex_rect(&mut self, t_width: i32, t_height: i32, x_camera: i32, y_camera: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tile_set` [INFO] [stderr] --> src/map.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | tile_set: tiled::Tileset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/map.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | height: i32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_height` [INFO] [stderr] --> src/map.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn get_height(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_set` [INFO] [stderr] --> src/map.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_tile_set(&self) -> &tiled::Tileset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/camera.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | &self.tile_buffer.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tile_buffer.clear();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | self.tile_rect[0] * t_width as f64 - x_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(t_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:193:50 [INFO] [stderr] | [INFO] [stderr] 193 | self.tile_rect[0] * t_width as f64 - x_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(x_camera)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:194:33 [INFO] [stderr] | [INFO] [stderr] 194 | self.tile_rect[1] * t_height as f64 - y_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(t_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:194:51 [INFO] [stderr] | [INFO] [stderr] 194 | self.tile_rect[1] * t_height as f64 - y_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(y_camera)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref mut window: GliumWindow = WindowSettings::new("Uranusbound", [w, h]) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | let window: &mut GliumWindow = &mut WindowSettings::new("Uranusbound", [w, h]) [INFO] [stderr] 45 | .exit_on_esc(true) [INFO] [stderr] 46 | .opengl(opengl) [INFO] [stderr] 47 | .resizable(false) [INFO] [stderr] 48 | .build() [INFO] [stderr] 49 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let ref mut camera = Camera::load(80, 80, win_width as i32, win_height as i32); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------- help: try: `let camera = &mut Camera::load(80, 80, win_width as i32, win_height as i32);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | / (tile as i32 % (map.get_width() / map.get_tile_width()) [INFO] [stderr] 102 | | * map.get_tile_width()) as f64, // x coordinate [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | f64::from(tile as i32 % (map.get_width() / map.get_tile_width()) [INFO] [stderr] 102 | * map.get_tile_width()), // x coordinate [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | / (tile as i32 / (map.get_width() / map.get_tile_height()) [INFO] [stderr] 104 | | * map.get_tile_height()) as f64, // y coordinate [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | f64::from(tile as i32 / (map.get_width() / map.get_tile_height()) [INFO] [stderr] 104 | * map.get_tile_height()), // y coordinate [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | map.get_tile_width() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:29 [INFO] [stderr] | [INFO] [stderr] 106 | map.get_tile_height() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:111:40 [INFO] [stderr] | [INFO] [stderr] 111 | x as f64 * map.get_tile_width() as f64 - camera.get_x() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:111:70 [INFO] [stderr] | [INFO] [stderr] 111 | x as f64 * map.get_tile_width() as f64 - camera.get_x() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(camera.get_x())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | y as f64 * map.get_tile_height() as f64 - camera.get_y() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:71 [INFO] [stderr] | [INFO] [stderr] 112 | y as f64 * map.get_tile_height() as f64 - camera.get_y() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(camera.get_y())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | if let Some(_) = event.close_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 177 | | // This is where save_game should probably be called [INFO] [stderr] 178 | | println!("Game window was closed. Exiting!"); [INFO] [stderr] 179 | | break 'game_loop; [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________- help: try this: `if event.close_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: field is never used: `map_buffer` [INFO] [stderr] --> src/camera.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | map_buffer: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_width` [INFO] [stderr] --> src/camera.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_width(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_height` [INFO] [stderr] --> src/camera.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn get_height(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_buffer` [INFO] [stderr] --> src/camera.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_tile_buffer(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut_tile_buffer` [INFO] [stderr] --> src/camera.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_mut_tile_buffer(&mut self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_map_buffer` [INFO] [stderr] --> src/camera.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn get_map_buffer(&self) -> &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut_map_buffer` [INFO] [stderr] --> src/camera.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn get_mut_map_buffer(&mut self) -> &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/camera.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn new() -> Camera { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_tile_buffer` [INFO] [stderr] --> src/camera.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn clear_tile_buffer(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tile_buffer_reserve` [INFO] [stderr] --> src/camera.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn tile_buffer_reserve(&mut self, size: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_to_tile_buffer` [INFO] [stderr] --> src/camera.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn push_to_tile_buffer(&mut self, tile: Tile) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_to_map_buffer` [INFO] [stderr] --> src/camera.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn push_to_map_buffer(&mut self, name: String, map: Map) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tex_rect` [INFO] [stderr] --> src/camera.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn tex_rect(&mut self, t_width: i32, t_height: i32, x_camera: i32, y_camera: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tile_set` [INFO] [stderr] --> src/map.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | tile_set: tiled::Tileset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/map.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | height: i32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_height` [INFO] [stderr] --> src/map.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn get_height(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_set` [INFO] [stderr] --> src/map.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_tile_set(&self) -> &tiled::Tileset { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/camera.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | &self.tile_buffer.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tile_buffer.clear();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | self.tile_rect[0] * t_width as f64 - x_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(t_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:193:50 [INFO] [stderr] | [INFO] [stderr] 193 | self.tile_rect[0] * t_width as f64 - x_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(x_camera)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:194:33 [INFO] [stderr] | [INFO] [stderr] 194 | self.tile_rect[1] * t_height as f64 - y_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(t_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:194:51 [INFO] [stderr] | [INFO] [stderr] 194 | self.tile_rect[1] * t_height as f64 - y_camera as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(y_camera)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref mut window: GliumWindow = WindowSettings::new("Uranusbound", [w, h]) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | let window: &mut GliumWindow = &mut WindowSettings::new("Uranusbound", [w, h]) [INFO] [stderr] 45 | .exit_on_esc(true) [INFO] [stderr] 46 | .opengl(opengl) [INFO] [stderr] 47 | .resizable(false) [INFO] [stderr] 48 | .build() [INFO] [stderr] 49 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let ref mut camera = Camera::load(80, 80, win_width as i32, win_height as i32); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------- help: try: `let camera = &mut Camera::load(80, 80, win_width as i32, win_height as i32);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | / (tile as i32 % (map.get_width() / map.get_tile_width()) [INFO] [stderr] 102 | | * map.get_tile_width()) as f64, // x coordinate [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | f64::from(tile as i32 % (map.get_width() / map.get_tile_width()) [INFO] [stderr] 102 | * map.get_tile_width()), // x coordinate [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | / (tile as i32 / (map.get_width() / map.get_tile_height()) [INFO] [stderr] 104 | | * map.get_tile_height()) as f64, // y coordinate [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | f64::from(tile as i32 / (map.get_width() / map.get_tile_height()) [INFO] [stderr] 104 | * map.get_tile_height()), // y coordinate [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | map.get_tile_width() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:29 [INFO] [stderr] | [INFO] [stderr] 106 | map.get_tile_height() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:111:40 [INFO] [stderr] | [INFO] [stderr] 111 | x as f64 * map.get_tile_width() as f64 - camera.get_x() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:111:70 [INFO] [stderr] | [INFO] [stderr] 111 | x as f64 * map.get_tile_width() as f64 - camera.get_x() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(camera.get_x())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | y as f64 * map.get_tile_height() as f64 - camera.get_y() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(map.get_tile_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:71 [INFO] [stderr] | [INFO] [stderr] 112 | y as f64 * map.get_tile_height() as f64 - camera.get_y() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(camera.get_y())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | if let Some(_) = event.close_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 177 | | // This is where save_game should probably be called [INFO] [stderr] 178 | | println!("Game window was closed. Exiting!"); [INFO] [stderr] 179 | | break 'game_loop; [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________- help: try this: `if event.close_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.53s [INFO] running `"docker" "inspect" "628c2de576cf0976516e446eab5c3631515692d2155297b10f726206fab5d01f"` [INFO] running `"docker" "rm" "-f" "628c2de576cf0976516e446eab5c3631515692d2155297b10f726206fab5d01f"` [INFO] [stdout] 628c2de576cf0976516e446eab5c3631515692d2155297b10f726206fab5d01f