[INFO] updating cached repository martin-jw/rusteng
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/martin-jw/rusteng
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/martin-jw/rusteng" "work/ex/clippy-test-run/sources/stable/gh/martin-jw/rusteng"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martin-jw/rusteng'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/martin-jw/rusteng" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martin-jw/rusteng"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martin-jw/rusteng'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 90d8464d4bd58cb74fef7c8cf52727eee0d81d35
[INFO] sha for GitHub repo martin-jw/rusteng: 90d8464d4bd58cb74fef7c8cf52727eee0d81d35
[INFO] validating manifest of martin-jw/rusteng on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of martin-jw/rusteng on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing martin-jw/rusteng
[INFO] finished frobbing martin-jw/rusteng
[INFO] frobbed toml for martin-jw/rusteng written to work/ex/clippy-test-run/sources/stable/gh/martin-jw/rusteng/Cargo.toml
[INFO] started frobbing martin-jw/rusteng
[INFO] finished frobbing martin-jw/rusteng
[INFO] frobbed toml for martin-jw/rusteng written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martin-jw/rusteng/Cargo.toml
[INFO] crate martin-jw/rusteng has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting martin-jw/rusteng against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/martin-jw/rusteng:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 80e4b171f6e6089bbf7ede0b7a36078fe64e2ab2f30f9afcd42b852c7086a29e
[INFO] running `"docker" "start" "-a" "80e4b171f6e6089bbf7ede0b7a36078fe64e2ab2f30f9afcd42b852c7086a29e"`
[INFO] [stderr]     Checking num-complex v0.1.43
[INFO] [stderr]     Checking tempfile v2.2.0
[INFO] [stderr]    Compiling gl_generator v0.7.0
[INFO] [stderr]    Compiling gl_generator v0.8.0
[INFO] [stderr]     Checking wayland-window v0.13.2
[INFO] [stderr]     Checking alga v0.5.3
[INFO] [stderr]     Checking winit v0.10.0
[INFO] [stderr]    Compiling gl v0.9.0
[INFO] [stderr]    Compiling glutin v0.12.0
[INFO] [stderr]     Checking nalgebra v0.14.1
[INFO] [stderr]     Checking rustfun v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/component/mod.rs:49:4
[INFO] [stderr]    |
[INFO] [stderr] 49 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/component/mod.rs:49:4
[INFO] [stderr]    |
[INFO] [stderr] 49 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::any::Any`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | use std::any::Any;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::any::Any`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | use std::any::Any;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Component`
[INFO] [stderr]   --> src/main.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 | use component::{ Component, Storage };
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `manager`
[INFO] [stderr]   --> src/main.rs:31:10
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut manager = entity_manager!{ 50, transform : component::TransformComponent };
[INFO] [stderr]    |             ^^^^^^^ help: consider using `_manager` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:31:6
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut manager = entity_manager!{ 50, transform : component::TransformComponent };
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/component/mod.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let index = *self.mapping.get(&id).unwrap();
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mapping[&id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/component/mod.rs:86:11
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 match self.store.get(*index).unwrap().entry {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.store[*index]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]   --> src/resource/text.rs:12:3
[INFO] [stderr]    |
[INFO] [stderr] 12 |           if let Some(mut file) = File::open(path).ok() {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 13 | |             let mut string = String::new();
[INFO] [stderr] 14 | |             match file.read_to_string(&mut string) {
[INFO] [stderr] 15 | |                 Ok(_) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |             Err("Unable to open file!")
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]    = help: Consider matching on `Ok(mut file)` and removing the call to `ok` instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |     while let Some(state) = gameloop.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^ help: try: `for state in gameloop { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:37:6
[INFO] [stderr]    |
[INFO] [stderr] 37 |                       match event {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 38 | |                         Event::WindowEvent { event: WindowEvent::Closed, .. } => {
[INFO] [stderr] 39 | |                             gameloop.stop();
[INFO] [stderr] 40 | |                         }
[INFO] [stderr] 41 | |                         _ => {}
[INFO] [stderr] 42 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 37 |                     if let Event::WindowEvent { event: WindowEvent::Closed, .. } = event {
[INFO] [stderr] 38 |     gameloop.stop();
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Component`
[INFO] [stderr]   --> src/main.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 | use component::{ Component, Storage };
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `manager`
[INFO] [stderr]   --> src/main.rs:31:10
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut manager = entity_manager!{ 50, transform : component::TransformComponent };
[INFO] [stderr]    |             ^^^^^^^ help: consider using `_manager` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:31:6
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut manager = entity_manager!{ 50, transform : component::TransformComponent };
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/component/mod.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let index = *self.mapping.get(&id).unwrap();
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mapping[&id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/component/mod.rs:86:11
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 match self.store.get(*index).unwrap().entry {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.store[*index]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]   --> src/resource/text.rs:12:3
[INFO] [stderr]    |
[INFO] [stderr] 12 |           if let Some(mut file) = File::open(path).ok() {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 13 | |             let mut string = String::new();
[INFO] [stderr] 14 | |             match file.read_to_string(&mut string) {
[INFO] [stderr] 15 | |                 Ok(_) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |             Err("Unable to open file!")
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]    = help: Consider matching on `Ok(mut file)` and removing the call to `ok` instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |     while let Some(state) = gameloop.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^ help: try: `for state in gameloop { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:37:6
[INFO] [stderr]    |
[INFO] [stderr] 37 |                       match event {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 38 | |                         Event::WindowEvent { event: WindowEvent::Closed, .. } => {
[INFO] [stderr] 39 | |                             gameloop.stop();
[INFO] [stderr] 40 | |                         }
[INFO] [stderr] 41 | |                         _ => {}
[INFO] [stderr] 42 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 37 |                     if let Event::WindowEvent { event: WindowEvent::Closed, .. } = event {
[INFO] [stderr] 38 |     gameloop.stop();
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 57.54s
[INFO] running `"docker" "inspect" "80e4b171f6e6089bbf7ede0b7a36078fe64e2ab2f30f9afcd42b852c7086a29e"`
[INFO] running `"docker" "rm" "-f" "80e4b171f6e6089bbf7ede0b7a36078fe64e2ab2f30f9afcd42b852c7086a29e"`
[INFO] [stdout] 80e4b171f6e6089bbf7ede0b7a36078fe64e2ab2f30f9afcd42b852c7086a29e