[INFO] updating cached repository mars/persistent-state-machine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mars/persistent-state-machine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mars/persistent-state-machine" "work/ex/clippy-test-run/sources/stable/gh/mars/persistent-state-machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mars/persistent-state-machine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mars/persistent-state-machine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mars/persistent-state-machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mars/persistent-state-machine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d74eaf7d8a09a4aa688309dae9e62674866df92b [INFO] sha for GitHub repo mars/persistent-state-machine: d74eaf7d8a09a4aa688309dae9e62674866df92b [INFO] validating manifest of mars/persistent-state-machine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mars/persistent-state-machine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mars/persistent-state-machine [INFO] finished frobbing mars/persistent-state-machine [INFO] frobbed toml for mars/persistent-state-machine written to work/ex/clippy-test-run/sources/stable/gh/mars/persistent-state-machine/Cargo.toml [INFO] started frobbing mars/persistent-state-machine [INFO] finished frobbing mars/persistent-state-machine [INFO] frobbed toml for mars/persistent-state-machine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mars/persistent-state-machine/Cargo.toml [INFO] crate mars/persistent-state-machine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mars/persistent-state-machine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mars/persistent-state-machine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7640c4e8aaa4b6622e22e7aaef4278d7f864ba465674969cf76bc3aea030f5da [INFO] running `"docker" "start" "-a" "7640c4e8aaa4b6622e22e7aaef4278d7f864ba465674969cf76bc3aea030f5da"` [INFO] [stderr] Compiling cc v1.0.6 [INFO] [stderr] Compiling pq-sys v0.4.4 [INFO] [stderr] Checking serde v1.0.29 [INFO] [stderr] Checking regex-syntax v0.5.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Compiling serde_derive_internals v0.20.0 [INFO] [stderr] Compiling serde_derive v1.0.29 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking regex v0.2.7 [INFO] [stderr] Compiling diesel_derives v1.1.0 [INFO] [stderr] Compiling derive-error-chain v0.11.0 [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking diesel v1.1.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking r2d2-diesel v1.0.0 [INFO] [stderr] Checking persistent-state-machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub const STATE_NAME_GESTATING: &'static str = "Gestating"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | pub const STATE_NAME_ALIVE: &'static str = "Alive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const STATE_NAME_DEAD: &'static str = "Dead"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `r2d2::Pool` [INFO] [stderr] --> src/models.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use r2d2::Pool; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `r2d2_diesel::ConnectionManager` [INFO] [stderr] --> src/models.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use r2d2_diesel::ConnectionManager; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | database_record [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | let database_record = diesel::insert_into(lives::table) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 47 | | .values(&new_life) [INFO] [stderr] 48 | | .get_result::(&*db_connection) [INFO] [stderr] 49 | | .expect("Error creating new Life"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | phase [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | let phase = match self.state_type.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 81 | | STATE_NAME_GESTATING => Phase::Gestating(Gestating { state: life }), [INFO] [stderr] 82 | | STATE_NAME_ALIVE => Phase::Alive(Alive { state: life }), [INFO] [stderr] 83 | | STATE_NAME_DEAD => Phase::Dead(Dead { state: life }), [INFO] [stderr] ... | [INFO] [stderr] 86 | | invalid_name, self.id), [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub const STATE_NAME_GESTATING: &'static str = "Gestating"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | pub const STATE_NAME_ALIVE: &'static str = "Alive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lifecycle.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const STATE_NAME_DEAD: &'static str = "Dead"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `r2d2::Pool` [INFO] [stderr] --> src/models.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use r2d2::Pool; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `r2d2_diesel::ConnectionManager` [INFO] [stderr] --> src/models.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use r2d2_diesel::ConnectionManager; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | database_record [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | let database_record = diesel::insert_into(lives::table) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 47 | | .values(&new_life) [INFO] [stderr] 48 | | .get_result::(&*db_connection) [INFO] [stderr] 49 | | .expect("Error creating new Life"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | phase [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | let phase = match self.state_type.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 81 | | STATE_NAME_GESTATING => Phase::Gestating(Gestating { state: life }), [INFO] [stderr] 82 | | STATE_NAME_ALIVE => Phase::Alive(Alive { state: life }), [INFO] [stderr] 83 | | STATE_NAME_DEAD => Phase::Dead(Dead { state: life }), [INFO] [stderr] ... | [INFO] [stderr] 86 | | invalid_name, self.id), [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Event` [INFO] [stderr] --> src/lifecycle.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | enum Event { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lifecycle.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | let life = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | &Phase::Gestating(ref v) => &v.state, [INFO] [stderr] 39 | | &Phase::Alive(ref v) => &v.state, [INFO] [stderr] 40 | | &Phase::Dead(ref v) => &v.state, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | let life = match *self { [INFO] [stderr] 38 | Phase::Gestating(ref v) => &v.state, [INFO] [stderr] 39 | Phase::Alive(ref v) => &v.state, [INFO] [stderr] 40 | Phase::Dead(ref v) => &v.state, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `now` [INFO] [stderr] --> src/lifecycle.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | let now = Utc::now().naive_utc(); [INFO] [stderr] | ^^^ help: consider using `_now` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Event` [INFO] [stderr] --> src/lifecycle.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | enum Event { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lifecycle.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | let life = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | &Phase::Gestating(ref v) => &v.state, [INFO] [stderr] 39 | | &Phase::Alive(ref v) => &v.state, [INFO] [stderr] 40 | | &Phase::Dead(ref v) => &v.state, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | let life = match *self { [INFO] [stderr] 38 | Phase::Gestating(ref v) => &v.state, [INFO] [stderr] 39 | Phase::Alive(ref v) => &v.state, [INFO] [stderr] 40 | Phase::Dead(ref v) => &v.state, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.52s [INFO] running `"docker" "inspect" "7640c4e8aaa4b6622e22e7aaef4278d7f864ba465674969cf76bc3aea030f5da"` [INFO] running `"docker" "rm" "-f" "7640c4e8aaa4b6622e22e7aaef4278d7f864ba465674969cf76bc3aea030f5da"` [INFO] [stdout] 7640c4e8aaa4b6622e22e7aaef4278d7f864ba465674969cf76bc3aea030f5da