[INFO] updating cached repository markcol/scheme-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/markcol/scheme-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/markcol/scheme-rs" "work/ex/clippy-test-run/sources/stable/gh/markcol/scheme-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/markcol/scheme-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/markcol/scheme-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/markcol/scheme-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/markcol/scheme-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4260fcce0f322bace042c7b50e55c3a2412658eb [INFO] sha for GitHub repo markcol/scheme-rs: 4260fcce0f322bace042c7b50e55c3a2412658eb [INFO] validating manifest of markcol/scheme-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of markcol/scheme-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing markcol/scheme-rs [INFO] finished frobbing markcol/scheme-rs [INFO] frobbed toml for markcol/scheme-rs written to work/ex/clippy-test-run/sources/stable/gh/markcol/scheme-rs/Cargo.toml [INFO] started frobbing markcol/scheme-rs [INFO] finished frobbing markcol/scheme-rs [INFO] frobbed toml for markcol/scheme-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/markcol/scheme-rs/Cargo.toml [INFO] crate markcol/scheme-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting markcol/scheme-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/markcol/scheme-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 041f1932817fe9a4ed5f75e505b4356dd63d5048f01193441127ab127ef9a991 [INFO] running `"docker" "start" "-a" "041f1932817fe9a4ed5f75e505b4356dd63d5048f01193441127ab127ef9a991"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Compiling syn v0.12.13 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Compiling structopt-derive v0.2.4 [INFO] [stderr] Checking structopt v0.2.4 [INFO] [stderr] Checking scheme-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/repl.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | return Some(line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(line)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/repl.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/interpreter.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if self.values.contains_key(&key) { [INFO] [stderr] 37 | | Err(format_err!("Duplicate key: {}", key)) [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | self.values.insert(key, value); [INFO] [stderr] 40 | | Ok(()) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: consider using: `self.values.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpreter.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | fn get(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/interpreter.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / if self.values.contains_key(&key) { [INFO] [stderr] 37 | | Err(format_err!("Duplicate key: {}", key)) [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | self.values.insert(key, value); [INFO] [stderr] 40 | | Ok(()) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: consider using: `self.values.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpreter.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | fn get(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.33s [INFO] running `"docker" "inspect" "041f1932817fe9a4ed5f75e505b4356dd63d5048f01193441127ab127ef9a991"` [INFO] running `"docker" "rm" "-f" "041f1932817fe9a4ed5f75e505b4356dd63d5048f01193441127ab127ef9a991"` [INFO] [stdout] 041f1932817fe9a4ed5f75e505b4356dd63d5048f01193441127ab127ef9a991