[INFO] updating cached repository mariomilha/rust-euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mariomilha/rust-euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mariomilha/rust-euler" "work/ex/clippy-test-run/sources/stable/gh/mariomilha/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mariomilha/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mariomilha/rust-euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariomilha/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariomilha/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bb25c23ef959cb973a690560bff7dbcb16d6f117 [INFO] sha for GitHub repo mariomilha/rust-euler: bb25c23ef959cb973a690560bff7dbcb16d6f117 [INFO] validating manifest of mariomilha/rust-euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mariomilha/rust-euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mariomilha/rust-euler [INFO] finished frobbing mariomilha/rust-euler [INFO] frobbed toml for mariomilha/rust-euler written to work/ex/clippy-test-run/sources/stable/gh/mariomilha/rust-euler/Cargo.toml [INFO] started frobbing mariomilha/rust-euler [INFO] finished frobbing mariomilha/rust-euler [INFO] frobbed toml for mariomilha/rust-euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariomilha/rust-euler/Cargo.toml [INFO] crate mariomilha/rust-euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mariomilha/rust-euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mariomilha/rust-euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15240b21c5c7264aa656ca09639b62355209c960c71f20e740fc2bd30449040f [INFO] running `"docker" "start" "-a" "15240b21c5c7264aa656ca09639b62355209c960c71f20e740fc2bd30449040f"` [INFO] [stderr] Checking first_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/euler10.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return last_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/euler10.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | number = number + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/euler10.rs:25:52 [INFO] [stderr] | [INFO] [stderr] 25 | fn check_already_found_primes(to_test:u64, primes: &Vec) -> u64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/euler10.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | last_number = last_number + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_number += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/euler10.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return last_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/euler10.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | number = number + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/euler10.rs:25:52 [INFO] [stderr] | [INFO] [stderr] 25 | fn check_already_found_primes(to_test:u64, primes: &Vec) -> u64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/euler10.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | last_number = last_number + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_number += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "15240b21c5c7264aa656ca09639b62355209c960c71f20e740fc2bd30449040f"` [INFO] running `"docker" "rm" "-f" "15240b21c5c7264aa656ca09639b62355209c960c71f20e740fc2bd30449040f"` [INFO] [stdout] 15240b21c5c7264aa656ca09639b62355209c960c71f20e740fc2bd30449040f