[INFO] updating cached repository mariogeiger/obj2voxel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mariogeiger/obj2voxel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mariogeiger/obj2voxel" "work/ex/clippy-test-run/sources/stable/gh/mariogeiger/obj2voxel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mariogeiger/obj2voxel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mariogeiger/obj2voxel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariogeiger/obj2voxel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariogeiger/obj2voxel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ef9dfefee971408b5136e1e78abf499459f53f2 [INFO] sha for GitHub repo mariogeiger/obj2voxel: 4ef9dfefee971408b5136e1e78abf499459f53f2 [INFO] validating manifest of mariogeiger/obj2voxel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mariogeiger/obj2voxel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mariogeiger/obj2voxel [INFO] finished frobbing mariogeiger/obj2voxel [INFO] frobbed toml for mariogeiger/obj2voxel written to work/ex/clippy-test-run/sources/stable/gh/mariogeiger/obj2voxel/Cargo.toml [INFO] started frobbing mariogeiger/obj2voxel [INFO] finished frobbing mariogeiger/obj2voxel [INFO] frobbed toml for mariogeiger/obj2voxel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariogeiger/obj2voxel/Cargo.toml [INFO] crate mariogeiger/obj2voxel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mariogeiger/obj2voxel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mariogeiger/obj2voxel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea597d4d0d34f0cbc6b4ded0df18c8538e09503666d4c2e02976fa575f837dd5 [INFO] running `"docker" "start" "-a" "ea597d4d0d34f0cbc6b4ded0df18c8538e09503666d4c2e02976fa575f837dd5"` [INFO] [stderr] Checking obj v0.8.2 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking alga v0.5.3 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Compiling npy-derive v0.4.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking npy v0.4.0 [INFO] [stderr] Checking nalgebra v0.14.1 [INFO] [stderr] Checking obj2voxel v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:389:33 [INFO] [stderr] | [INFO] [stderr] 389 | 1 << (i % 2) * 4 + (j % 2) * 2 + (k % 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << ((i % 2) * 4 + (j % 2) * 2 + (k % 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(*value as u64 * 0x200040008001) & 0x111111111111111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:402:40 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x2000_4000_8001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:402:57 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0x0111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:389:33 [INFO] [stderr] | [INFO] [stderr] 389 | 1 << (i % 2) * 4 + (j % 2) * 2 + (k % 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << ((i % 2) * 4 + (j % 2) * 2 + (k % 2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(*value as u64 * 0x200040008001) & 0x111111111111111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:402:40 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x2000_4000_8001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:402:57 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0x0111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:303:52 [INFO] [stderr] | [INFO] [stderr] 303 | let mut obj = Obj::::load(file).expect(&format!("Cannot open {:?}", file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {:?}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:303:52 [INFO] [stderr] | [INFO] [stderr] 303 | let mut obj = Obj::::load(file).expect(&format!("Cannot open {:?}", file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {:?}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | *value = ((*value as u64 * 0x200040008001 & 0x111111111111111) % 0xf) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.23s [INFO] running `"docker" "inspect" "ea597d4d0d34f0cbc6b4ded0df18c8538e09503666d4c2e02976fa575f837dd5"` [INFO] running `"docker" "rm" "-f" "ea597d4d0d34f0cbc6b4ded0df18c8538e09503666d4c2e02976fa575f837dd5"` [INFO] [stdout] ea597d4d0d34f0cbc6b4ded0df18c8538e09503666d4c2e02976fa575f837dd5