[INFO] updating cached repository mariasiuvlad/ppong-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mariasiuvlad/ppong-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mariasiuvlad/ppong-rust" "work/ex/clippy-test-run/sources/stable/gh/mariasiuvlad/ppong-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mariasiuvlad/ppong-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mariasiuvlad/ppong-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariasiuvlad/ppong-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariasiuvlad/ppong-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 58e805b0edf65cfdc4b610bf3c24e5a7d6ed6e4d [INFO] sha for GitHub repo mariasiuvlad/ppong-rust: 58e805b0edf65cfdc4b610bf3c24e5a7d6ed6e4d [INFO] validating manifest of mariasiuvlad/ppong-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mariasiuvlad/ppong-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mariasiuvlad/ppong-rust [INFO] finished frobbing mariasiuvlad/ppong-rust [INFO] frobbed toml for mariasiuvlad/ppong-rust written to work/ex/clippy-test-run/sources/stable/gh/mariasiuvlad/ppong-rust/Cargo.toml [INFO] started frobbing mariasiuvlad/ppong-rust [INFO] finished frobbing mariasiuvlad/ppong-rust [INFO] frobbed toml for mariasiuvlad/ppong-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mariasiuvlad/ppong-rust/Cargo.toml [INFO] crate mariasiuvlad/ppong-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mariasiuvlad/ppong-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mariasiuvlad/ppong-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 982edb91dd3a132fe84b101b94eb8a7417b34af46519e4efbe717df54ead9c19 [INFO] running `"docker" "start" "-a" "982edb91dd3a132fe84b101b94eb8a7417b34af46519e4efbe717df54ead9c19"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking alga v0.5.3 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking nalgebra v0.14.1 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking ncollide_math v0.9.0 [INFO] [stderr] Checking ncollide_utils v0.9.0 [INFO] [stderr] Checking ncollide_procedural v0.9.0 [INFO] [stderr] Checking ncollide_geometry v0.6.2 [INFO] [stderr] Checking ncollide_pipeline v0.13.1 [INFO] [stderr] Checking ncollide_transformation v0.9.0 [INFO] [stderr] Checking ncollide v0.14.1 [INFO] [stderr] Checking ppong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/paddle.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ball.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Game { [INFO] [stderr] 14 | | Game { [INFO] [stderr] 15 | | paddle_left: Paddle::new((10.0, 125.0)), [INFO] [stderr] 16 | | paddle_right: Paddle::new((1270.0, 125.0)), [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for game::Game { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `view::ViewSettings` [INFO] [stderr] --> src/view.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> ViewSettings { [INFO] [stderr] 16 | | ViewSettings { [INFO] [stderr] 17 | | paddle_color: [0.4, 0.7, 0.4, 1.0], [INFO] [stderr] 18 | | ball_color: [0.7, 0.4, 0.4, 1.0], [INFO] [stderr] 19 | | background_color: [0.4, 0.6, 0.9, 1.0], [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/paddle.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ball.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Game { [INFO] [stderr] 14 | | Game { [INFO] [stderr] 15 | | paddle_left: Paddle::new((10.0, 125.0)), [INFO] [stderr] 16 | | paddle_right: Paddle::new((1270.0, 125.0)), [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for game::Game { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `view::ViewSettings` [INFO] [stderr] --> src/view.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> ViewSettings { [INFO] [stderr] 16 | | ViewSettings { [INFO] [stderr] 17 | | paddle_color: [0.4, 0.7, 0.4, 1.0], [INFO] [stderr] 18 | | ball_color: [0.7, 0.4, 0.4, 1.0], [INFO] [stderr] 19 | | background_color: [0.4, 0.6, 0.9, 1.0], [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 19s [INFO] running `"docker" "inspect" "982edb91dd3a132fe84b101b94eb8a7417b34af46519e4efbe717df54ead9c19"` [INFO] running `"docker" "rm" "-f" "982edb91dd3a132fe84b101b94eb8a7417b34af46519e4efbe717df54ead9c19"` [INFO] [stdout] 982edb91dd3a132fe84b101b94eb8a7417b34af46519e4efbe717df54ead9c19