[INFO] updating cached repository marcianx/data-structures-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/marcianx/data-structures-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/marcianx/data-structures-rs" "work/ex/clippy-test-run/sources/stable/gh/marcianx/data-structures-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/marcianx/data-structures-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/marcianx/data-structures-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marcianx/data-structures-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marcianx/data-structures-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 767cdc5827bbb91b6e225e292d8ac17dbc9c1f56
[INFO] sha for GitHub repo marcianx/data-structures-rs: 767cdc5827bbb91b6e225e292d8ac17dbc9c1f56
[INFO] validating manifest of marcianx/data-structures-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of marcianx/data-structures-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing marcianx/data-structures-rs
[INFO] finished frobbing marcianx/data-structures-rs
[INFO] frobbed toml for marcianx/data-structures-rs written to work/ex/clippy-test-run/sources/stable/gh/marcianx/data-structures-rs/Cargo.toml
[INFO] started frobbing marcianx/data-structures-rs
[INFO] finished frobbing marcianx/data-structures-rs
[INFO] frobbed toml for marcianx/data-structures-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marcianx/data-structures-rs/Cargo.toml
[INFO] crate marcianx/data-structures-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting marcianx/data-structures-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/marcianx/data-structures-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ba408f2a1185f5ec9c634ad620df242393a826e948cee6baeb49f47f7665f8d4
[INFO] running `"docker" "start" "-a" "ba408f2a1185f5ec9c634ad620df242393a826e948cee6baeb49f47f7665f8d4"`
[INFO] [stderr]     Checking lists v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mutable_linked_list.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 |         self.head = Some(Box::new(Node { elem: elem, next: self.head.take() }));
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/immutable_linked_list.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 |         List { head: Some(Rc::new(Node { elem: elem, next: self.head.clone() })) }
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             elem: elem,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             elem: elem,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mutable_linked_list.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 |         self.head = Some(Box::new(Node { elem: elem, next: self.head.take() }));
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/immutable_linked_list.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 |         List { head: Some(Rc::new(Node { elem: elem, next: self.head.clone() })) }
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             elem: elem,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             elem: elem,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `elem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mutable_linked_list::List<T>`
[INFO] [stderr]   --> src/mutable_linked_list.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         List { head: None }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `immutable_linked_list::List<T>`
[INFO] [stderr]   --> src/immutable_linked_list.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Self {
[INFO] [stderr] 20 | |         List { head: None }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:32:38
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn eq_ref_opt<T>(ref1: &T, opt_ref2: &Option<&T>) -> bool {
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: consider passing by value instead: `Option<&T>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match opt_ref2 {
[INFO] [stderr] 34 | |         // Need to convert to *const for referential equality.
[INFO] [stderr] 35 | |         &Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 36 | |         &None => false
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |     match *opt_ref2 {
[INFO] [stderr] 34 |         // Need to convert to *const for referential equality.
[INFO] [stderr] 35 |         Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 36 |         None => false
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 | /     match opt_ref2 {
[INFO] [stderr] 42 | |         // Need to convert to *const for referential equality.
[INFO] [stderr] 43 | |         &Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 44 | |         &None => false
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |     match *opt_ref2 {
[INFO] [stderr] 42 |         // Need to convert to *const for referential equality.
[INFO] [stderr] 43 |         Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 44 |         None => false
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mutable_doubly_linked_list::List<T>`
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 | /     pub fn new() -> Self {
[INFO] [stderr] 106 | |         List { head: None, tail: ptr::null() }
[INFO] [stderr] 107 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 | impl Default for mutable_doubly_linked_list::List<T> {
[INFO] [stderr] 105 |     fn default() -> Self {
[INFO] [stderr] 106 |         Self::new()
[INFO] [stderr] 107 |     }
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mutable_linked_list::List<T>`
[INFO] [stderr]   --> src/mutable_linked_list.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         List { head: None }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &mut list.enumerate()` or similar iterators
[INFO] [stderr]    --> src/mutable_linked_list.rs:233:20
[INFO] [stderr]     |
[INFO] [stderr] 233 |         for val in &mut list {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `immutable_linked_list::List<T>`
[INFO] [stderr]   --> src/immutable_linked_list.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Self {
[INFO] [stderr] 20 | |         List { head: None }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:32:38
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn eq_ref_opt<T>(ref1: &T, opt_ref2: &Option<&T>) -> bool {
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: consider passing by value instead: `Option<&T>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match opt_ref2 {
[INFO] [stderr] 34 | |         // Need to convert to *const for referential equality.
[INFO] [stderr] 35 | |         &Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 36 | |         &None => false
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |     match *opt_ref2 {
[INFO] [stderr] 34 |         // Need to convert to *const for referential equality.
[INFO] [stderr] 35 |         Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 36 |         None => false
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/mutable_doubly_linked_list.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 | /     match opt_ref2 {
[INFO] [stderr] 42 | |         // Need to convert to *const for referential equality.
[INFO] [stderr] 43 | |         &Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 44 | |         &None => false
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |     match *opt_ref2 {
[INFO] [stderr] 42 |         // Need to convert to *const for referential equality.
[INFO] [stderr] 43 |         Some(ref ref2) => ref1 as *const T == *ref2 as *const T,
[INFO] [stderr] 44 |         None => false
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mutable_doubly_linked_list::List<T>`
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 | /     pub fn new() -> Self {
[INFO] [stderr] 106 | |         List { head: None, tail: ptr::null() }
[INFO] [stderr] 107 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 | impl Default for mutable_doubly_linked_list::List<T> {
[INFO] [stderr] 105 |     fn default() -> Self {
[INFO] [stderr] 106 |         Self::new()
[INFO] [stderr] 107 |     }
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &mut list.enumerate()` or similar iterators
[INFO] [stderr]    --> src/mutable_doubly_linked_list.rs:463:20
[INFO] [stderr]     |
[INFO] [stderr] 463 |         for val in &mut list {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.56s
[INFO] running `"docker" "inspect" "ba408f2a1185f5ec9c634ad620df242393a826e948cee6baeb49f47f7665f8d4"`
[INFO] running `"docker" "rm" "-f" "ba408f2a1185f5ec9c634ad620df242393a826e948cee6baeb49f47f7665f8d4"`
[INFO] [stdout] ba408f2a1185f5ec9c634ad620df242393a826e948cee6baeb49f47f7665f8d4