[INFO] updating cached repository maralorn/tasktree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maralorn/tasktree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maralorn/tasktree" "work/ex/clippy-test-run/sources/stable/gh/maralorn/tasktree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maralorn/tasktree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maralorn/tasktree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralorn/tasktree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralorn/tasktree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e4409ac50936ffe9563770a9c2227ef86cbb4d0 [INFO] sha for GitHub repo maralorn/tasktree: 7e4409ac50936ffe9563770a9c2227ef86cbb4d0 [INFO] validating manifest of maralorn/tasktree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maralorn/tasktree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maralorn/tasktree [INFO] finished frobbing maralorn/tasktree [INFO] frobbed toml for maralorn/tasktree written to work/ex/clippy-test-run/sources/stable/gh/maralorn/tasktree/Cargo.toml [INFO] started frobbing maralorn/tasktree [INFO] finished frobbing maralorn/tasktree [INFO] frobbed toml for maralorn/tasktree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralorn/tasktree/Cargo.toml [INFO] crate maralorn/tasktree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maralorn/tasktree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maralorn/tasktree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec4b7f1af01aa790cacf1fabadc74d2edd7eb93e10e8cc8ff682bbd580413758 [INFO] running `"docker" "start" "-a" "ec4b7f1af01aa790cacf1fabadc74d2edd7eb93e10e8cc8ff682bbd580413758"` [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling cairo-rs v0.1.3 [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling glib-sys v0.3.4 [INFO] [stderr] Compiling gobject-sys v0.3.4 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling cairo-sys-rs v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling atk-sys v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking task-hookrs v0.3.0 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking tasktree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/task.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / if self.children.contains_key(&parent) { [INFO] [stderr] 107 | | self.children.get_mut(&parent).unwrap().push(task.uuid); [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | self.children.insert(parent, vec![task.uuid]); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.children.entry(parent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/task.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(self.tasks.get(uuid).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tasks[uuid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/task.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if descriptions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!descriptions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / &Command::new("task") [INFO] [stderr] 199 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 200 | | .arg("mod") [INFO] [stderr] 201 | | .arg(format!("project:{}", project.unwrap_or(""))) [INFO] [stderr] 202 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 198 | Command::new("task") [INFO] [stderr] 199 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 200 | .arg("mod") [INFO] [stderr] 201 | .arg(format!("project:{}", project.unwrap_or(""))) [INFO] [stderr] 202 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / &Command::new("task") [INFO] [stderr] 208 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 209 | | .arg("done") [INFO] [stderr] 210 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 207 | Command::new("task") [INFO] [stderr] 208 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 209 | .arg("done") [INFO] [stderr] 210 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / &Command::new("task") [INFO] [stderr] 216 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 217 | | .arg("delete") [INFO] [stderr] 218 | | .arg("rc.confirmation:0") [INFO] [stderr] 219 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 215 | Command::new("task") [INFO] [stderr] 216 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 217 | .arg("delete") [INFO] [stderr] 218 | .arg("rc.confirmation:0") [INFO] [stderr] 219 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / &Command::new("task") [INFO] [stderr] 225 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 226 | | .arg("mod") [INFO] [stderr] 227 | | .arg("status:pending") [INFO] [stderr] 228 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 224 | Command::new("task") [INFO] [stderr] 225 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 226 | .arg("mod") [INFO] [stderr] 227 | .arg("status:pending") [INFO] [stderr] 228 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / &Command::new("task") [INFO] [stderr] 238 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 239 | | .arg("mod") [INFO] [stderr] 240 | | .arg(format!( [INFO] [stderr] ... | [INFO] [stderr] 243 | | )) [INFO] [stderr] 244 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 237 | Command::new("task") [INFO] [stderr] 238 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 239 | .arg("mod") [INFO] [stderr] 240 | .arg(format!( [INFO] [stderr] 241 | "partof:{}", [INFO] [stderr] 242 | partof.map_or("".to_string(), ToString::to_string) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / &Command::new("task") [INFO] [stderr] 250 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 251 | | .arg("mod") [INFO] [stderr] 252 | | .arg(format!("description:\"{}\"", description)) [INFO] [stderr] 253 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 249 | Command::new("task") [INFO] [stderr] 250 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 251 | .arg("mod") [INFO] [stderr] 252 | .arg(format!("description:\"{}\"", description)) [INFO] [stderr] 253 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | / &Command::new("task") [INFO] [stderr] 259 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 260 | | .arg("mod") [INFO] [stderr] 261 | | .arg(format!("+{}", tag)) [INFO] [stderr] 262 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 258 | Command::new("task") [INFO] [stderr] 259 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 260 | .arg("mod") [INFO] [stderr] 261 | .arg(format!("+{}", tag)) [INFO] [stderr] 262 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / &Command::new("task") [INFO] [stderr] 268 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 269 | | .arg("mod") [INFO] [stderr] 270 | | .arg(format!("-{}", tag)) [INFO] [stderr] 271 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 267 | Command::new("task") [INFO] [stderr] 268 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 269 | .arg("mod") [INFO] [stderr] 270 | .arg(format!("-{}", tag)) [INFO] [stderr] 271 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:70 [INFO] [stderr] | [INFO] [stderr] 195 | new_child_cell.connect_edited(move |_, treepath, description| if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:212:72 [INFO] [stderr] | [INFO] [stderr] 212 | description_cell.connect_edited(move |_, treepath, description| if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(borrowed_app.refresh()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 265 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/task.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / if self.children.contains_key(&parent) { [INFO] [stderr] 107 | | self.children.get_mut(&parent).unwrap().push(task.uuid); [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | self.children.insert(parent, vec![task.uuid]); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.children.entry(parent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/task.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(self.tasks.get(uuid).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tasks[uuid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/task.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if descriptions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!descriptions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / &Command::new("task") [INFO] [stderr] 199 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 200 | | .arg("mod") [INFO] [stderr] 201 | | .arg(format!("project:{}", project.unwrap_or(""))) [INFO] [stderr] 202 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 198 | Command::new("task") [INFO] [stderr] 199 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 200 | .arg("mod") [INFO] [stderr] 201 | .arg(format!("project:{}", project.unwrap_or(""))) [INFO] [stderr] 202 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / &Command::new("task") [INFO] [stderr] 208 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 209 | | .arg("done") [INFO] [stderr] 210 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 207 | Command::new("task") [INFO] [stderr] 208 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 209 | .arg("done") [INFO] [stderr] 210 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / &Command::new("task") [INFO] [stderr] 216 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 217 | | .arg("delete") [INFO] [stderr] 218 | | .arg("rc.confirmation:0") [INFO] [stderr] 219 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 215 | Command::new("task") [INFO] [stderr] 216 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 217 | .arg("delete") [INFO] [stderr] 218 | .arg("rc.confirmation:0") [INFO] [stderr] 219 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / &Command::new("task") [INFO] [stderr] 225 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 226 | | .arg("mod") [INFO] [stderr] 227 | | .arg("status:pending") [INFO] [stderr] 228 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 224 | Command::new("task") [INFO] [stderr] 225 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 226 | .arg("mod") [INFO] [stderr] 227 | .arg("status:pending") [INFO] [stderr] 228 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / &Command::new("task") [INFO] [stderr] 238 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 239 | | .arg("mod") [INFO] [stderr] 240 | | .arg(format!( [INFO] [stderr] ... | [INFO] [stderr] 243 | | )) [INFO] [stderr] 244 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 237 | Command::new("task") [INFO] [stderr] 238 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 239 | .arg("mod") [INFO] [stderr] 240 | .arg(format!( [INFO] [stderr] 241 | "partof:{}", [INFO] [stderr] 242 | partof.map_or("".to_string(), ToString::to_string) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / &Command::new("task") [INFO] [stderr] 250 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 251 | | .arg("mod") [INFO] [stderr] 252 | | .arg(format!("description:\"{}\"", description)) [INFO] [stderr] 253 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 249 | Command::new("task") [INFO] [stderr] 250 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 251 | .arg("mod") [INFO] [stderr] 252 | .arg(format!("description:\"{}\"", description)) [INFO] [stderr] 253 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | / &Command::new("task") [INFO] [stderr] 259 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 260 | | .arg("mod") [INFO] [stderr] 261 | | .arg(format!("+{}", tag)) [INFO] [stderr] 262 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 258 | Command::new("task") [INFO] [stderr] 259 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 260 | .arg("mod") [INFO] [stderr] 261 | .arg(format!("+{}", tag)) [INFO] [stderr] 262 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/task.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / &Command::new("task") [INFO] [stderr] 268 | | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 269 | | .arg("mod") [INFO] [stderr] 270 | | .arg(format!("-{}", tag)) [INFO] [stderr] 271 | | .output()?; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 267 | Command::new("task") [INFO] [stderr] 268 | .arg(format!("uuid:{}", uuid)) [INFO] [stderr] 269 | .arg("mod") [INFO] [stderr] 270 | .arg(format!("-{}", tag)) [INFO] [stderr] 271 | .output()?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:70 [INFO] [stderr] | [INFO] [stderr] 195 | new_child_cell.connect_edited(move |_, treepath, description| if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:212:72 [INFO] [stderr] | [INFO] [stderr] 212 | description_cell.connect_edited(move |_, treepath, description| if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(borrowed_app.refresh()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 265 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.06s [INFO] running `"docker" "inspect" "ec4b7f1af01aa790cacf1fabadc74d2edd7eb93e10e8cc8ff682bbd580413758"` [INFO] running `"docker" "rm" "-f" "ec4b7f1af01aa790cacf1fabadc74d2edd7eb93e10e8cc8ff682bbd580413758"` [INFO] [stdout] ec4b7f1af01aa790cacf1fabadc74d2edd7eb93e10e8cc8ff682bbd580413758