[INFO] updating cached repository maralla/pack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maralla/pack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maralla/pack" "work/ex/clippy-test-run/sources/stable/gh/maralla/pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maralla/pack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maralla/pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralla/pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralla/pack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b0aeb1f56295a0a0773297c278c7ef9e7b58ae6 [INFO] sha for GitHub repo maralla/pack: 5b0aeb1f56295a0a0773297c278c7ef9e7b58ae6 [INFO] validating manifest of maralla/pack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maralla/pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maralla/pack [INFO] finished frobbing maralla/pack [INFO] frobbed toml for maralla/pack written to work/ex/clippy-test-run/sources/stable/gh/maralla/pack/Cargo.toml [INFO] started frobbing maralla/pack [INFO] finished frobbing maralla/pack [INFO] frobbed toml for maralla/pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maralla/pack/Cargo.toml [INFO] crate maralla/pack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maralla/pack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maralla/pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f46bf10db166d2f6b9e4af7ffe71ae244f652c26ed827ee0d0e77b32f6a5d2cf [INFO] running `"docker" "start" "-a" "f46bf10db166d2f6b9e4af7ffe71ae244f652c26ed827ee0d0e77b32f6a5d2cf"` [INFO] [stderr] Compiling libz-sys v1.0.24 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking chan v0.1.20 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking pack v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/package.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | let home = env::home_dir().expect("No home directory found"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/package.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | let home = env::home_dir().expect("No home directory found"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/package.rs:353:50 [INFO] [stderr] | [INFO] [stderr] 353 | if sub.is_dir() && !item.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/task.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | for (j, pack) in chunk.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/package.rs:353:50 [INFO] [stderr] | [INFO] [stderr] 353 | if sub.is_dir() && !item.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/task.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | for (j, pack) in chunk.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.59s [INFO] running `"docker" "inspect" "f46bf10db166d2f6b9e4af7ffe71ae244f652c26ed827ee0d0e77b32f6a5d2cf"` [INFO] running `"docker" "rm" "-f" "f46bf10db166d2f6b9e4af7ffe71ae244f652c26ed827ee0d0e77b32f6a5d2cf"` [INFO] [stdout] f46bf10db166d2f6b9e4af7ffe71ae244f652c26ed827ee0d0e77b32f6a5d2cf