[INFO] updating cached repository manjuraj/rip
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/manjuraj/rip
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/manjuraj/rip" "work/ex/clippy-test-run/sources/stable/gh/manjuraj/rip"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/manjuraj/rip'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/manjuraj/rip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manjuraj/rip"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manjuraj/rip'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d51d441c79672b17d0fc8077815fb6576c8d971c
[INFO] sha for GitHub repo manjuraj/rip: d51d441c79672b17d0fc8077815fb6576c8d971c
[INFO] validating manifest of manjuraj/rip on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of manjuraj/rip on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing manjuraj/rip
[INFO] finished frobbing manjuraj/rip
[INFO] frobbed toml for manjuraj/rip written to work/ex/clippy-test-run/sources/stable/gh/manjuraj/rip/Cargo.toml
[INFO] started frobbing manjuraj/rip
[INFO] finished frobbing manjuraj/rip
[INFO] frobbed toml for manjuraj/rip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manjuraj/rip/Cargo.toml
[INFO] crate manjuraj/rip has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting manjuraj/rip against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/manjuraj/rip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 02bbdf04a9c0a52c126a9112055e721a9c5d0e2955573b7154588ea48376e7ca
[INFO] running `"docker" "start" "-a" "02bbdf04a9c0a52c126a9112055e721a9c5d0e2955573b7154588ea48376e7ca"`
[INFO] [stderr] warning: path `/opt/crater/workdir/src/rip.rs` was erroneously implicitly accepted for binary `rip`,
[INFO] [stderr] please set bin.path in Cargo.toml
[INFO] [stderr]     Checking rip v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/networking.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return Server {
[INFO] [stderr] 12 | |             ip: ip.to_string(),
[INFO] [stderr] 13 | |             port: *port,
[INFO] [stderr] 14 | |             clients: Vec::new()
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Server {
[INFO] [stderr] 12 |             ip: ip.to_string(),
[INFO] [stderr] 13 |             port: *port,
[INFO] [stderr] 14 |             clients: Vec::new()
[INFO] [stderr] 15 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/networking.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return Server::new(ip, port);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Server::new(ip, port)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/networking.rs:10:32
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new(ip: &str, port: &i16) -> Server {
[INFO] [stderr]    |                                ^^^^ help: consider passing by value instead: `i16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/networking.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 | /             match stream {
[INFO] [stderr] 28 | |                 Ok(stream) => {
[INFO] [stderr] 29 | |                     // connection succeeded
[INFO] [stderr] 30 | |                     self.handle_client(stream)
[INFO] [stderr] 31 | |                 }
[INFO] [stderr] 32 | |                 Err(_) => { /* connection failed */ }
[INFO] [stderr] 33 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 |             if let Ok(stream) = stream {
[INFO] [stderr] 28 |     // connection succeeded
[INFO] [stderr] 29 |     self.handle_client(stream)
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/networking.rs:41:35
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn new_server(ip: &str, port: &i16) -> Server {
[INFO] [stderr]    |                                   ^^^^ help: consider passing by value instead: `i16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/networking.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return Server {
[INFO] [stderr] 12 | |             ip: ip.to_string(),
[INFO] [stderr] 13 | |             port: *port,
[INFO] [stderr] 14 | |             clients: Vec::new()
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Server {
[INFO] [stderr] 12 |             ip: ip.to_string(),
[INFO] [stderr] 13 |             port: *port,
[INFO] [stderr] 14 |             clients: Vec::new()
[INFO] [stderr] 15 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/networking.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return Server::new(ip, port);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Server::new(ip, port)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/networking.rs:10:32
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new(ip: &str, port: &i16) -> Server {
[INFO] [stderr]    |                                ^^^^ help: consider passing by value instead: `i16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/networking.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 | /             match stream {
[INFO] [stderr] 28 | |                 Ok(stream) => {
[INFO] [stderr] 29 | |                     // connection succeeded
[INFO] [stderr] 30 | |                     self.handle_client(stream)
[INFO] [stderr] 31 | |                 }
[INFO] [stderr] 32 | |                 Err(_) => { /* connection failed */ }
[INFO] [stderr] 33 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 |             if let Ok(stream) = stream {
[INFO] [stderr] 28 |     // connection succeeded
[INFO] [stderr] 29 |     self.handle_client(stream)
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/networking.rs:41:35
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn new_server(ip: &str, port: &i16) -> Server {
[INFO] [stderr]    |                                   ^^^^ help: consider passing by value instead: `i16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "02bbdf04a9c0a52c126a9112055e721a9c5d0e2955573b7154588ea48376e7ca"`
[INFO] running `"docker" "rm" "-f" "02bbdf04a9c0a52c126a9112055e721a9c5d0e2955573b7154588ea48376e7ca"`
[INFO] [stdout] 02bbdf04a9c0a52c126a9112055e721a9c5d0e2955573b7154588ea48376e7ca