[INFO] updating cached repository manguluka/geocode-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/manguluka/geocode-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/manguluka/geocode-rs" "work/ex/clippy-test-run/sources/stable/gh/manguluka/geocode-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/manguluka/geocode-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/manguluka/geocode-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manguluka/geocode-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manguluka/geocode-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc56ec46426926e195855c4fb417295612b00e6d [INFO] sha for GitHub repo manguluka/geocode-rs: bc56ec46426926e195855c4fb417295612b00e6d [INFO] validating manifest of manguluka/geocode-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of manguluka/geocode-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing manguluka/geocode-rs [INFO] finished frobbing manguluka/geocode-rs [INFO] frobbed toml for manguluka/geocode-rs written to work/ex/clippy-test-run/sources/stable/gh/manguluka/geocode-rs/Cargo.toml [INFO] started frobbing manguluka/geocode-rs [INFO] finished frobbing manguluka/geocode-rs [INFO] frobbed toml for manguluka/geocode-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manguluka/geocode-rs/Cargo.toml [INFO] crate manguluka/geocode-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting manguluka/geocode-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/manguluka/geocode-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2546394d53c10700df3053db669866f4e7aaa4da0b8f5397e0c231718a16be56 [INFO] running `"docker" "start" "-a" "2546394d53c10700df3053db669866f4e7aaa4da0b8f5397e0c231718a16be56"` [INFO] [stderr] Compiling either v1.3.0 [INFO] [stderr] Compiling futures v0.1.16 [INFO] [stderr] Compiling num_cpus v1.7.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.16 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking pretty_env_logger v0.1.1 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Compiling ring v0.9.7 [INFO] [stderr] Checking webpki v0.12.1 [INFO] [stderr] Checking webpki-roots v0.10.0 [INFO] [stderr] Checking rustls v0.8.0 [INFO] [stderr] Checking cabot v0.1.3 [INFO] [stderr] Checking geocode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/google.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return match response.status.as_str() { [INFO] [stderr] 46 | | STATUS_OK => Ok(GeocodeResponse { [INFO] [stderr] 47 | | location: response.results[0].clone().geometry.location, [INFO] [stderr] 48 | | location_type: response.results[0].clone().geometry.location_type, [INFO] [stderr] ... | [INFO] [stderr] 53 | | _ => Err(response.status), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | match response.status.as_str() { [INFO] [stderr] 46 | STATUS_OK => Ok(GeocodeResponse { [INFO] [stderr] 47 | location: response.results[0].clone().geometry.location, [INFO] [stderr] 48 | location_type: response.results[0].clone().geometry.location_type, [INFO] [stderr] 49 | formatted_address: response.results[0].clone().formatted_address, [INFO] [stderr] 50 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/google.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return match response.status.as_str() { [INFO] [stderr] 46 | | STATUS_OK => Ok(GeocodeResponse { [INFO] [stderr] 47 | | location: response.results[0].clone().geometry.location, [INFO] [stderr] 48 | | location_type: response.results[0].clone().geometry.location_type, [INFO] [stderr] ... | [INFO] [stderr] 53 | | _ => Err(response.status), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | match response.status.as_str() { [INFO] [stderr] 46 | STATUS_OK => Ok(GeocodeResponse { [INFO] [stderr] 47 | location: response.results[0].clone().geometry.location, [INFO] [stderr] 48 | location_type: response.results[0].clone().geometry.location_type, [INFO] [stderr] 49 | formatted_address: response.results[0].clone().formatted_address, [INFO] [stderr] 50 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(result.location.lat, 38.440429); [INFO] [stderr] | ^^^^^^^^^ help: consider: `38.440_429` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(result.location.lng, -122.7140548); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `122.714_054_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(result.location.lat, 38.440429); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(result.location.lat, 38.440429); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(result.location.lng, -122.7140548); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(result.location.lng, -122.7140548); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `geocode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2546394d53c10700df3053db669866f4e7aaa4da0b8f5397e0c231718a16be56"` [INFO] running `"docker" "rm" "-f" "2546394d53c10700df3053db669866f4e7aaa4da0b8f5397e0c231718a16be56"` [INFO] [stdout] 2546394d53c10700df3053db669866f4e7aaa4da0b8f5397e0c231718a16be56