[INFO] updating cached repository manfredlotz/checkutf8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/manfredlotz/checkutf8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/manfredlotz/checkutf8" "work/ex/clippy-test-run/sources/stable/gh/manfredlotz/checkutf8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/manfredlotz/checkutf8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/manfredlotz/checkutf8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manfredlotz/checkutf8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manfredlotz/checkutf8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7a11d83be28e1ddcc3c740206bfbf5294ec0aa42
[INFO] sha for GitHub repo manfredlotz/checkutf8: 7a11d83be28e1ddcc3c740206bfbf5294ec0aa42
[INFO] validating manifest of manfredlotz/checkutf8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of manfredlotz/checkutf8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing manfredlotz/checkutf8
[INFO] finished frobbing manfredlotz/checkutf8
[INFO] frobbed toml for manfredlotz/checkutf8 written to work/ex/clippy-test-run/sources/stable/gh/manfredlotz/checkutf8/Cargo.toml
[INFO] started frobbing manfredlotz/checkutf8
[INFO] finished frobbing manfredlotz/checkutf8
[INFO] frobbed toml for manfredlotz/checkutf8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manfredlotz/checkutf8/Cargo.toml
[INFO] crate manfredlotz/checkutf8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting manfredlotz/checkutf8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/manfredlotz/checkutf8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a17829758876e82d517f889a646232073773c84176dfa14274e0bbac0490853b
[INFO] running `"docker" "start" "-a" "a17829758876e82d517f889a646232073773c84176dfa14274e0bbac0490853b"`
[INFO] [stderr]     Checking structopt v0.2.8
[INFO] [stderr]     Checking checkutf8 v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `lineno` is used as a loop counter. Consider using `for (lineno, item) in lines.enumerate()` or similar iterators
[INFO] [stderr] warning: the variable `lineno` is used as a loop counter. Consider using `for (lineno, item) in lines.enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |     for line in lines {
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]   --> src/main.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |     for line in lines {
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match String::from_utf8(line.clone()) {
[INFO] [stderr] 24 | |             Err(e) => {
[INFO] [stderr] 25 | |                 
[INFO] [stderr] 26 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |             Ok(_) => ()
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if let Err(e) = String::from_utf8(line.clone()) {
[INFO] [stderr] 24 |     
[INFO] [stderr] 25 | 
[INFO] [stderr] 26 |     if !header_printed {
[INFO] [stderr] 27 |         println!("{}: not valid UTF-8", fname);
[INFO] [stderr] 28 |         header_printed = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match String::from_utf8(line.clone()) {
[INFO] [stderr] 24 | |             Err(e) => {
[INFO] [stderr] 25 | |                 
[INFO] [stderr] 26 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |             Ok(_) => ()
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if let Err(e) = String::from_utf8(line.clone()) {
[INFO] [stderr] 24 |     
[INFO] [stderr] 25 | 
[INFO] [stderr] 26 |     if !header_printed {
[INFO] [stderr] 27 |         println!("{}: not valid UTF-8", fname);
[INFO] [stderr] 28 |         header_printed = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.95s
[INFO] running `"docker" "inspect" "a17829758876e82d517f889a646232073773c84176dfa14274e0bbac0490853b"`
[INFO] running `"docker" "rm" "-f" "a17829758876e82d517f889a646232073773c84176dfa14274e0bbac0490853b"`
[INFO] [stdout] a17829758876e82d517f889a646232073773c84176dfa14274e0bbac0490853b