[INFO] updating cached repository mandeep/renderama [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mandeep/renderama [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mandeep/renderama" "work/ex/clippy-test-run/sources/stable/gh/mandeep/renderama"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mandeep/renderama'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mandeep/renderama" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandeep/renderama"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandeep/renderama'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b04be3ff4dbd80fe3e5c935372396ff09775d78e [INFO] sha for GitHub repo mandeep/renderama: b04be3ff4dbd80fe3e5c935372396ff09775d78e [INFO] validating manifest of mandeep/renderama on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mandeep/renderama on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mandeep/renderama [INFO] finished frobbing mandeep/renderama [INFO] frobbed toml for mandeep/renderama written to work/ex/clippy-test-run/sources/stable/gh/mandeep/renderama/Cargo.toml [INFO] started frobbing mandeep/renderama [INFO] finished frobbing mandeep/renderama [INFO] frobbed toml for mandeep/renderama written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandeep/renderama/Cargo.toml [INFO] crate mandeep/renderama has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mandeep/renderama against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mandeep/renderama:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47b01cb06f8be3fdf82e78b30122efd1a3cafe2485b94d8d2a5edb59089fb979 [INFO] running `"docker" "start" "-a" "47b01cb06f8be3fdf82e78b30122efd1a3cafe2485b94d8d2a5edb59089fb979"` [INFO] [stderr] Checking cfg-if v0.1.3 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling num-complex v0.2.0 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking generic-array v0.11.1 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking approx v0.2.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking alga v0.6.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking nalgebra v0.15.3 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking renderama v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:57 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:73 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Diffuse { albedo: albedo } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | Reflective { albedo: albedo, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:38 [INFO] [stderr] | [INFO] [stderr] 81 | Reflective { albedo: albedo, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | Refractive { albedo: albedo, refractive_index: index, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:118:63 [INFO] [stderr] | [INFO] [stderr] 118 | Refractive { albedo: albedo, refractive_index: index, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:34 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:57 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hitable.rs:20:73 [INFO] [stderr] | [INFO] [stderr] 20 | HitRecord { parameter: parameter, point: point, normal: normal, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Diffuse { albedo: albedo } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | Reflective { albedo: albedo, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:38 [INFO] [stderr] | [INFO] [stderr] 81 | Reflective { albedo: albedo, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | Refractive { albedo: albedo, refractive_index: index, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:118:63 [INFO] [stderr] | [INFO] [stderr] 118 | Refractive { albedo: albedo, refractive_index: index, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:34 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | Sphere { center: center, radius: radius, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/materials.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | / return Some((self.albedo, [INFO] [stderr] 155 | | Ray::new(record.point, reflected + self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 156 | | )); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 154 | Some((self.albedo, [INFO] [stderr] 155 | Ray::new(record.point, reflected + self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 156 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/materials.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / return Some((self.albedo, Ray::new(record.point, [INFO] [stderr] 159 | | refracted.unwrap() + [INFO] [stderr] 160 | | self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 161 | | )); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 158 | Some((self.albedo, Ray::new(record.point, [INFO] [stderr] 159 | refracted.unwrap() + [INFO] [stderr] 160 | self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 161 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | / return attenuation.component_mul( [INFO] [stderr] 57 | | &compute_color(&scattered, world, depth + 1, rng)); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | attenuation.component_mul( [INFO] [stderr] 57 | &compute_color(&scattered, world, depth + 1, rng)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | None => { return Vector3::zeros(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector3::zeros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | return Vector3::zeros(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector3::zeros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | return (1.0 - point) * Vector3::new(1.0, 1.0, 1.0) + point * Vector3::new(0.5, 0.7, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - point) * Vector3::new(1.0, 1.0, 1.0) + point * Vector3::new(0.5, 0.7, 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | if hit_anything { return Some(record); } else { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(record)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:45:57 [INFO] [stderr] | [INFO] [stderr] 45 | if hit_anything { return Some(record); } else { return None; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/materials.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | / return Some((self.albedo, [INFO] [stderr] 155 | | Ray::new(record.point, reflected + self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 156 | | )); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 154 | Some((self.albedo, [INFO] [stderr] 155 | Ray::new(record.point, reflected + self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 156 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/materials.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / return Some((self.albedo, Ray::new(record.point, [INFO] [stderr] 159 | | refracted.unwrap() + [INFO] [stderr] 160 | | self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 161 | | )); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 158 | Some((self.albedo, Ray::new(record.point, [INFO] [stderr] 159 | refracted.unwrap() + [INFO] [stderr] 160 | self.fuzz * pick_sphere_point(rng)) [INFO] [stderr] 161 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | / return attenuation.component_mul( [INFO] [stderr] 57 | | &compute_color(&scattered, world, depth + 1, rng)); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | attenuation.component_mul( [INFO] [stderr] 57 | &compute_color(&scattered, world, depth + 1, rng)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | None => { return Vector3::zeros(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector3::zeros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | return Vector3::zeros(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector3::zeros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | return (1.0 - point) * Vector3::new(1.0, 1.0, 1.0) + point * Vector3::new(0.5, 0.7, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - point) * Vector3::new(1.0, 1.0, 1.0) + point * Vector3::new(0.5, 0.7, 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | if hit_anything { return Some(record); } else { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(record)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:45:57 [INFO] [stderr] | [INFO] [stderr] 45 | if hit_anything { return Some(record); } else { return None; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | w: Vector3, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | (width / height) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width / height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:58 [INFO] [stderr] | [INFO] [stderr] 82 | let u = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | let v = (y as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | coordinate /= samples as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | w: Vector3, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | (width / height) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width / height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:58 [INFO] [stderr] | [INFO] [stderr] 82 | let u = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | let v = (y as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | coordinate /= samples as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 1m 10s [INFO] running `"docker" "inspect" "47b01cb06f8be3fdf82e78b30122efd1a3cafe2485b94d8d2a5edb59089fb979"` [INFO] running `"docker" "rm" "-f" "47b01cb06f8be3fdf82e78b30122efd1a3cafe2485b94d8d2a5edb59089fb979"` [INFO] [stdout] 47b01cb06f8be3fdf82e78b30122efd1a3cafe2485b94d8d2a5edb59089fb979