[INFO] updating cached repository manaskarekar/convrs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/manaskarekar/convrs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/manaskarekar/convrs" "work/ex/clippy-test-run/sources/stable/gh/manaskarekar/convrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/manaskarekar/convrs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/manaskarekar/convrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manaskarekar/convrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manaskarekar/convrs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f108c124f3e54035c7920e9af52a01083658f682
[INFO] sha for GitHub repo manaskarekar/convrs: f108c124f3e54035c7920e9af52a01083658f682
[INFO] validating manifest of manaskarekar/convrs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of manaskarekar/convrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing manaskarekar/convrs
[INFO] finished frobbing manaskarekar/convrs
[INFO] frobbed toml for manaskarekar/convrs written to work/ex/clippy-test-run/sources/stable/gh/manaskarekar/convrs/Cargo.toml
[INFO] started frobbing manaskarekar/convrs
[INFO] finished frobbing manaskarekar/convrs
[INFO] frobbed toml for manaskarekar/convrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/manaskarekar/convrs/Cargo.toml
[INFO] crate manaskarekar/convrs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting manaskarekar/convrs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/manaskarekar/convrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] abe4570429cd824937f074578c868d06285cdeb720dab3630c45061297bf471f
[INFO] running `"docker" "start" "-a" "abe4570429cd824937f074578c868d06285cdeb720dab3630c45061297bf471f"`
[INFO] [stderr]    Compiling plist v0.2.3
[INFO] [stderr]     Checking handlebars v0.28.3
[INFO] [stderr]     Checking convrs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/profiles/tm.rs:53:2
[INFO] [stderr]    |
[INFO] [stderr] 53 |     ir
[INFO] [stderr]    |     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/profiles/tm.rs:24:11
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let ir = IntermediateRepr { name: "default".to_string(), ..Default::default() };
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/profiles/tm.rs:53:2
[INFO] [stderr]    |
[INFO] [stderr] 53 |     ir
[INFO] [stderr]    |     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/profiles/tm.rs:24:11
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let ir = IntermediateRepr { name: "default".to_string(), ..Default::default() };
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/vim.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/jedit.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/profiles/paletton_txt.rs:15:28
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/profiles/st3.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/tm.rs:8:28
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn read_file(filename: &String) -> String {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:61:29
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn write_file(filename: &String, data: &String) {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:61:44
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn write_file(filename: &String, data: &String) {
[INFO] [stderr]    |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:29
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:53
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:75
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                                                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/vim.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/jedit.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/profiles/paletton_txt.rs:15:28
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/profiles/st3.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/profiles/tm.rs:8:28
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn read_scheme(infile: &String) -> IntermediateRepr {
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn read_file(filename: &String) -> String {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:61:29
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn write_file(filename: &String, data: &String) {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ir.rs:61:44
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn write_file(filename: &String, data: &String) {
[INFO] [stderr]    |                                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:29
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:53
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/convert.rs:4:75
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn convert(source_file: &String, source_format: &String, dest_format: &String) {
[INFO] [stderr]   |                                                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.46s
[INFO] running `"docker" "inspect" "abe4570429cd824937f074578c868d06285cdeb720dab3630c45061297bf471f"`
[INFO] running `"docker" "rm" "-f" "abe4570429cd824937f074578c868d06285cdeb720dab3630c45061297bf471f"`
[INFO] [stdout] abe4570429cd824937f074578c868d06285cdeb720dab3630c45061297bf471f