[INFO] updating cached repository malbarbo/mstcc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/malbarbo/mstcc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/malbarbo/mstcc" "work/ex/clippy-test-run/sources/stable/gh/malbarbo/mstcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/malbarbo/mstcc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/malbarbo/mstcc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/malbarbo/mstcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/malbarbo/mstcc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b48336773edbf87006d19a226845ad21156b86fe [INFO] sha for GitHub repo malbarbo/mstcc: b48336773edbf87006d19a226845ad21156b86fe [INFO] validating manifest of malbarbo/mstcc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of malbarbo/mstcc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing malbarbo/mstcc [INFO] finished frobbing malbarbo/mstcc [INFO] frobbed toml for malbarbo/mstcc written to work/ex/clippy-test-run/sources/stable/gh/malbarbo/mstcc/Cargo.toml [INFO] started frobbing malbarbo/mstcc [INFO] finished frobbing malbarbo/mstcc [INFO] frobbed toml for malbarbo/mstcc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/malbarbo/mstcc/Cargo.toml [INFO] crate malbarbo/mstcc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting malbarbo/mstcc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/malbarbo/mstcc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c09d0693aab898366d7f84a60388a378ba463c19e05d1d97f336183b2adca0a4 [INFO] running `"docker" "start" "-a" "c09d0693aab898366d7f84a60388a378ba463c19e05d1d97f336183b2adca0a4"` [INFO] [stderr] Checking fera-fun v0.1.0 [INFO] [stderr] Checking fera-unionfind v0.1.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking fera-optional v0.1.1 [INFO] [stderr] Checking env_logger v0.5.9 [INFO] [stderr] Checking fera-ext v0.1.0 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking fera-graph v0.1.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking fera v0.1.0 [INFO] [stderr] Checking mstcc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/input.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut w = Vec::::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/input.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let s = &mut line.split_whitespace(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/input.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let g = b.finalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/input.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let s = &mut line.split_whitespace(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/input.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | let (a, b) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/input.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | let (x, y) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/input.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let (x, y) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/input.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let mut i = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/input.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let x = w[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/two.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | let (ej, c, d) = self.p.g.ends(tree[j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/two.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | (x, y) if x == y => continue, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/input.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut w = Vec::::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/input.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let s = &mut line.split_whitespace(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/input.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let g = b.finalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/input.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let s = &mut line.split_whitespace(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/input.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | let (a, b) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/input.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | let (x, y) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/input.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let (x, y) = (parse_next(s)?, parse_next(s)?); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/input.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let mut i = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/input.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let x = w[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/two.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | let (ej, c, d) = self.p.g.ends(tree[j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/two.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | (x, y) if x == y => continue, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn new_xor_shift_rng(&self) -> XorShiftRng { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn new_xor_shift_rng(&self) -> XorShiftRng { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> tests/conflicts.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let mut p = MstCcProblem { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/conflicts.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | g: g, [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/conflicts.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/conflicts.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | cc: cc, [INFO] [stderr] | ^^^^^^ help: replace it with: `cc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> tests/conflicts.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / fn add_edge() { [INFO] [stderr] 9 | | let (p, e) = new(); [INFO] [stderr] 10 | | let mut conflicts = TrackConflicts::new(&p); [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 46 | | assert_eq!(1, conflicts[e[5]]); [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.11s [INFO] running `"docker" "inspect" "c09d0693aab898366d7f84a60388a378ba463c19e05d1d97f336183b2adca0a4"` [INFO] running `"docker" "rm" "-f" "c09d0693aab898366d7f84a60388a378ba463c19e05d1d97f336183b2adca0a4"` [INFO] [stdout] c09d0693aab898366d7f84a60388a378ba463c19e05d1d97f336183b2adca0a4