[INFO] updating cached repository makr17/load-pwp-tail [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/makr17/load-pwp-tail [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/makr17/load-pwp-tail" "work/ex/clippy-test-run/sources/stable/gh/makr17/load-pwp-tail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/makr17/load-pwp-tail'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/makr17/load-pwp-tail" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makr17/load-pwp-tail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makr17/load-pwp-tail'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ed0e8a0fe59672e02ad845fa5adae3fbaa11c49 [INFO] sha for GitHub repo makr17/load-pwp-tail: 7ed0e8a0fe59672e02ad845fa5adae3fbaa11c49 [INFO] validating manifest of makr17/load-pwp-tail on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of makr17/load-pwp-tail on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing makr17/load-pwp-tail [INFO] finished frobbing makr17/load-pwp-tail [INFO] frobbed toml for makr17/load-pwp-tail written to work/ex/clippy-test-run/sources/stable/gh/makr17/load-pwp-tail/Cargo.toml [INFO] started frobbing makr17/load-pwp-tail [INFO] finished frobbing makr17/load-pwp-tail [INFO] frobbed toml for makr17/load-pwp-tail written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makr17/load-pwp-tail/Cargo.toml [INFO] crate makr17/load-pwp-tail has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting makr17/load-pwp-tail against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/makr17/load-pwp-tail:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eaf09a6f1468320f903a26d8e5a305d70ebd9e569c676637ebb2052e577a8099 [INFO] running `"docker" "start" "-a" "eaf09a6f1468320f903a26d8e5a305d70ebd9e569c676637ebb2052e577a8099"` [INFO] [stderr] Checking fallible-iterator v0.1.3 [INFO] [stderr] Checking md5 v0.3.4 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Checking postgres-protocol v0.2.2 [INFO] [stderr] Checking postgres-shared v0.2.1 [INFO] [stderr] Checking postgres v0.14.1 [INFO] [stderr] Checking load-pwp-tail v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | const WATER: &'static str = "water"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | const POWER: &'static str = "power"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / if args.len() > 1 { [INFO] [stderr] 45 | | if args[1] == WATER { [INFO] [stderr] 46 | | table = WATER; [INFO] [stderr] 47 | | meter_idx = 6; [INFO] [stderr] 48 | | value_idx = 7; [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if args.len() > 1 && args[1] == WATER { [INFO] [stderr] 45 | table = WATER; [INFO] [stderr] 46 | meter_idx = 6; [INFO] [stderr] 47 | value_idx = 7; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return config.database; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config.database` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return conn; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return sample; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | const WATER: &'static str = "water"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | const POWER: &'static str = "power"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / if args.len() > 1 { [INFO] [stderr] 45 | | if args[1] == WATER { [INFO] [stderr] 46 | | table = WATER; [INFO] [stderr] 47 | | meter_idx = 6; [INFO] [stderr] 48 | | value_idx = 7; [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if args.len() > 1 && args[1] == WATER { [INFO] [stderr] 45 | table = WATER; [INFO] [stderr] 46 | meter_idx = 6; [INFO] [stderr] 47 | value_idx = 7; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return config.database; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config.database` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return conn; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return sample; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.74s [INFO] running `"docker" "inspect" "eaf09a6f1468320f903a26d8e5a305d70ebd9e569c676637ebb2052e577a8099"` [INFO] running `"docker" "rm" "-f" "eaf09a6f1468320f903a26d8e5a305d70ebd9e569c676637ebb2052e577a8099"` [INFO] [stdout] eaf09a6f1468320f903a26d8e5a305d70ebd9e569c676637ebb2052e577a8099