[INFO] updating cached repository makos/rlog
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/makos/rlog
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/makos/rlog" "work/ex/clippy-test-run/sources/stable/gh/makos/rlog"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/makos/rlog'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/makos/rlog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/rlog"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/rlog'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bb5691fac58878cc2cc68e328733e56390b09e98
[INFO] sha for GitHub repo makos/rlog: bb5691fac58878cc2cc68e328733e56390b09e98
[INFO] validating manifest of makos/rlog on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of makos/rlog on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing makos/rlog
[INFO] finished frobbing makos/rlog
[INFO] frobbed toml for makos/rlog written to work/ex/clippy-test-run/sources/stable/gh/makos/rlog/Cargo.toml
[INFO] started frobbing makos/rlog
[INFO] finished frobbing makos/rlog
[INFO] frobbed toml for makos/rlog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/rlog/Cargo.toml
[INFO] crate makos/rlog has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting makos/rlog against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/makos/rlog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c8c1cf7c1f188558b9457f88a042518c39f5435fb2d311c69822184c6a019083
[INFO] running `"docker" "start" "-a" "c8c1cf7c1f188558b9457f88a042518c39f5435fb2d311c69822184c6a019083"`
[INFO] [stderr]     Checking rlog v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         let mut _format = "%d-%m-%Y %a %H:%M.%S";
[INFO] [stderr] 107 | |
[INFO] [stderr] 108 | |         if format != "" {
[INFO] [stderr] 109 | |             _format = format;
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> _format = if format != "" { format } else { "%d-%m-%Y %a %H:%M.%S" };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         let mut _format = "%d-%m-%Y %a %H:%M.%S";
[INFO] [stderr] 107 | |
[INFO] [stderr] 108 | |         if format != "" {
[INFO] [stderr] 109 | |             _format = format;
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> _format = if format != "" { format } else { "%d-%m-%Y %a %H:%M.%S" };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/testenv/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/testenv/mod.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             return false;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.08s
[INFO] running `"docker" "inspect" "c8c1cf7c1f188558b9457f88a042518c39f5435fb2d311c69822184c6a019083"`
[INFO] running `"docker" "rm" "-f" "c8c1cf7c1f188558b9457f88a042518c39f5435fb2d311c69822184c6a019083"`
[INFO] [stdout] c8c1cf7c1f188558b9457f88a042518c39f5435fb2d311c69822184c6a019083