[INFO] updating cached repository majewsky/rust-i3status [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/majewsky/rust-i3status [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/majewsky/rust-i3status" "work/ex/clippy-test-run/sources/stable/gh/majewsky/rust-i3status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/majewsky/rust-i3status'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/majewsky/rust-i3status" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majewsky/rust-i3status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majewsky/rust-i3status'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6acf7e0916311255843a4b40e1d4c958d80c136f [INFO] sha for GitHub repo majewsky/rust-i3status: 6acf7e0916311255843a4b40e1d4c958d80c136f [INFO] validating manifest of majewsky/rust-i3status on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of majewsky/rust-i3status on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing majewsky/rust-i3status [INFO] finished frobbing majewsky/rust-i3status [INFO] frobbed toml for majewsky/rust-i3status written to work/ex/clippy-test-run/sources/stable/gh/majewsky/rust-i3status/Cargo.toml [INFO] started frobbing majewsky/rust-i3status [INFO] finished frobbing majewsky/rust-i3status [INFO] frobbed toml for majewsky/rust-i3status written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majewsky/rust-i3status/Cargo.toml [INFO] crate majewsky/rust-i3status has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting majewsky/rust-i3status against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/majewsky/rust-i3status:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38acf7554013111784413516f3a5f5a9e5b314fa9a3e579ad990ab45ffcf8ec9 [INFO] running `"docker" "start" "-a" "38acf7554013111784413516f3a5f5a9e5b314fa9a3e579ad990ab45ffcf8ec9"` [INFO] [stderr] Checking pnet_base v0.20.0 [INFO] [stderr] Compiling pnet v0.20.0 [INFO] [stderr] Checking ipnetwork v0.12.7 [INFO] [stderr] Checking json v0.11.12 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.20.0 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling thread_local v0.3.4 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Checking pnet_macros_support v0.20.0 [INFO] [stderr] Checking pnet_datalink v0.20.0 [INFO] [stderr] Compiling regex v0.2.3 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.20.0 [INFO] [stderr] Compiling pnet_packet v0.20.0 [INFO] [stderr] Checking pnet_transport v0.20.0 [INFO] [stderr] Checking custom-i3status v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | const ENERGY_FULL_PATH: &'static str = "/sys/class/power_supply/BAT0/energy_full"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | const ENERGY_NOW_PATH: &'static str = "/sys/class/power_supply/BAT0/energy_now"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | const POWER_ONLINE_PATH: &'static str = "/sys/class/power_supply/AC0/online"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers/battery.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return Some(BatteryData { [INFO] [stderr] 72 | | energy_percent: energy_now * 100 / energy_full, [INFO] [stderr] 73 | | is_charging: power_online > 0, [INFO] [stderr] 74 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Some(BatteryData { [INFO] [stderr] 72 | energy_percent: energy_now * 100 / energy_full, [INFO] [stderr] 73 | is_charging: power_online > 0, [INFO] [stderr] 74 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/brightness.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const SCREEN_MAX_PATH: &'static str = "/sys/class/backlight/intel_backlight/max_brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/brightness.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | const SCREEN_NOW_PATH: &'static str = "/sys/class/backlight/intel_backlight/brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | const ENERGY_FULL_PATH: &'static str = "/sys/class/power_supply/BAT0/energy_full"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | const ENERGY_NOW_PATH: &'static str = "/sys/class/power_supply/BAT0/energy_now"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/battery.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | const POWER_ONLINE_PATH: &'static str = "/sys/class/power_supply/AC0/online"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers/battery.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return Some(BatteryData { [INFO] [stderr] 72 | | energy_percent: energy_now * 100 / energy_full, [INFO] [stderr] 73 | | is_charging: power_online > 0, [INFO] [stderr] 74 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Some(BatteryData { [INFO] [stderr] 72 | energy_percent: energy_now * 100 / energy_full, [INFO] [stderr] 73 | is_charging: power_online > 0, [INFO] [stderr] 74 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/brightness.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const SCREEN_MAX_PATH: &'static str = "/sys/class/backlight/intel_backlight/max_brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/brightness.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | const SCREEN_NOW_PATH: &'static str = "/sys/class/backlight/intel_backlight/brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/providers/network.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if ips.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ips.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/providers/network.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if ips.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ips.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/threads.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if let Ok(_) = io::stdin().read_line(&mut s) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 37 | | sink.send(Event::Command(s)).unwrap(); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________- help: try this: `if io::stdin().read_line(&mut s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/threads.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if let Ok(_) = io::stdin().read_line(&mut s) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 37 | | sink.send(Event::Command(s)).unwrap(); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________- help: try this: `if io::stdin().read_line(&mut s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.36s [INFO] running `"docker" "inspect" "38acf7554013111784413516f3a5f5a9e5b314fa9a3e579ad990ab45ffcf8ec9"` [INFO] running `"docker" "rm" "-f" "38acf7554013111784413516f3a5f5a9e5b314fa9a3e579ad990ab45ffcf8ec9"` [INFO] [stdout] 38acf7554013111784413516f3a5f5a9e5b314fa9a3e579ad990ab45ffcf8ec9